Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Remote Application Platform (RAP) » [GEF] "Drag-Job" on progress view
[GEF] "Drag-Job" on progress view [message #728545] Fri, 23 September 2011 13:10 Go to next message
Arnaud MERGEY is currently offline Arnaud MERGEY
Messages: 131
Registered: March 2010
Location: France
Senior Member
Hello,

Using GEF in RAP, "Drag-Job" jobs are displayed on progress view. It would probably be cleaner to hide these jobs by having them as system jobs.

I attach a patch, if it makes sense to hide them.

Regards,
Arnaud
  • Attachment: patch.txt
    (Size: 1.31KB, Downloaded 57 times)
Re: [GEF] "Drag-Job" on progress view [message #728595 is a reply to message #728545] Fri, 23 September 2011 14:07 Go to previous messageGo to next message
Rüdiger Herrmann is currently offline Rüdiger Herrmann
Messages: 335
Registered: July 2009
Senior Member
Hi Arnaud,

thanks for the patch. I would also agree to hide this kind of Jobs. Even
though the change is small, I suggest to first submit the patch to GEF.
If it gets accepted there, it can be integrated into RAP and we avoid
that both projects diverge unnecessarily.

More generally, to contribute a patch to RAP (or any other Eclipse
project), it should be attached to a bug. This makes it easy to keep a
clean IP log [1].

Cheers,
Rüdiger

[1] http://wiki.eclipse.org/Development_Resources/IP_Log#Contributions

On 23.09.2011 15:10, Arnaud MERGEY wrote:
> Hello,
>
> Using GEF in RAP, "Drag-Job" jobs are displayed on progress view. It would probably be cleaner to hide these jobs by having them as system jobs.
>
> I attach a patch, if it makes sense to hide them.
>
> Regards,
> Arnaud
--
Rüdiger Herrmann

Twitter: @EclipseRAP
Blog: http://eclipsesource.com/blogs/

Professional services for RAP and RCP?
http://eclipsesource.com/services/rap/
Re: [GEF] "Drag-Job" on progress view [message #728612 is a reply to message #728595] Fri, 23 September 2011 14:39 Go to previous messageGo to next message
Arnaud MERGEY is currently offline Arnaud MERGEY
Messages: 131
Registered: March 2010
Location: France
Senior Member
Hello Rudiger
I think the Drag-Job thing is specific to RAP as it is created with a class called RAPDragTracker, and also with comment // HACK for DND in RAP
, so I think my patch is relevant in RAP port for GEF.
But before creating a bug to attach my patch, I wanted to be sure, it is why I had posted it here first. Could you confirm me I can assign the bug to rap incubator component ?
Thanks and best regards,
Arnaud


Re: [GEF] "Drag-Job" on progress view [message #728619 is a reply to message #728612] Fri, 23 September 2011 14:44 Go to previous messageGo to next message
Rüdiger Herrmann is currently offline Rüdiger Herrmann
Messages: 335
Registered: July 2009
Senior Member
On 23.09.2011 16:39, Arnaud MERGEY wrote:
> Hello Rudiger
> I think the Drag-Job thing is specific to RAP as it is created with a
> class called RAPDragTracker, and also with comment // HACK for DND in RAP
> , so I think my patch is relevant in RAP port for GEF.
I see, sorry that I didn't read the patch properly.

> But before creating a bug to attach my patch, I wanted to be sure, it is
> why I had posted it here first. Could you confirm me I can assign the
> bug to rap incubator component ?
Yes, even if it is a hack that gets removed somewhen I agree that the
Job should be marked as 'system'.

> Thanks and best regards,
> Arnaud
>
>
>
--
Rüdiger Herrmann

Twitter: @EclipseRAP
Blog: http://eclipsesource.com/blogs/

Professional services for RAP and RCP?
http://eclipsesource.com/services/rap/
Re: [GEF] "Drag-Job" on progress view [message #728666 is a reply to message #728619] Fri, 23 September 2011 15:59 Go to previous message
Arnaud MERGEY is currently offline Arnaud MERGEY
Messages: 131
Registered: March 2010
Location: France
Senior Member
Bug 358741 created

Thanks
Arnaud
Previous Topic:[ANN] RAP 1.4 SR1 is available
Next Topic:Adding HTTP Response Header
Goto Forum:
  


Current Time: Mon Sep 15 09:33:02 GMT 2014

Powered by FUDForum. Page generated in 0.02349 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software