Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Nebula » GridTableViewer - CellModifier problem with collapsed GridColumnGroup?
GridTableViewer - CellModifier problem with collapsed GridColumnGroup? [message #44209] Thu, 29 November 2007 05:46 Go to next message
Philippe Ravaine is currently offline Philippe Ravaine
Messages: 4
Registered: July 2009
Junior Member
Hi all,

working with Nebula latest release, I have a problem with editable cells
on a GridTableViewer, with collapsed GridColumnGroup.

Let's assume I have 3 GridColumn (col1,col2,col3).
The one in the middle has : col2.setSummary(false);

The table shows the right values, GridColumngroup Expanded and Collapsed ;
meaning that the LabelProvider works well GridColumnGroup.

When GridColumnGroup expanded, a click on any cell of any column allows to
edit the right value.
When Collapsed, a click on col3 give the opportunity to edit hidden col2.
The methods of the CellModifier are given wrong "property" argument by the
GridTableViewer.

In fact, this problem happens when clicking at a position a hidden column
was located when the GridColumnGroup was expanded.

To sum up :

--------------------
| group << |
|----|----|--------|
|col1|col2| col3 |
|----|----|--------|
| | | |

---------------
| group >> |
|----|--------|
|col1| col3 |
|----|--------|
| |XXXXXYYY|

When clicking on XXXXX, you edit col2
When clicking on YYY, you edit col3


The problem comes with the CellModifier. Has anyone else the same problem ?
Any idea to solve this ?


Cheers,
Philippe
Re: GridTableViewer - CellModifier problem with collapsed GridColumnGroup? [message #44240 is a reply to message #44209] Thu, 29 November 2007 06:12 Go to previous messageGo to next message
Thomas Schindl is currently offline Thomas Schindl
Messages: 5256
Registered: July 2009
Senior Member
Hi,

It seems that the algorithm to find the correct column to edit is not
working. I suppose the problem is found in
GridViewerRow#getColumnIndex(Point) where we try to correct index.

I think we never tested this at least I haven't so it is fairly likely
that it's not working as expected. Another problem in this area could be
tabbing support.

Ravaine would you mind to creating a snippet (we can run without
modifications) to reproduce the problem and file a bugzilla. I'll take
at it look then.

Tom

Ravaine Philippe schrieb:
> Hi all,
>
> working with Nebula latest release, I have a problem with editable cells
> on a GridTableViewer, with collapsed GridColumnGroup.
>
> Let's assume I have 3 GridColumn (col1,col2,col3).
> The one in the middle has : col2.setSummary(false);
>
> The table shows the right values, GridColumngroup Expanded and Collapsed
> ; meaning that the LabelProvider works well GridColumnGroup.
>
> When GridColumnGroup expanded, a click on any cell of any column allows
> to edit the right value.
> When Collapsed, a click on col3 give the opportunity to edit hidden col2.
> The methods of the CellModifier are given wrong "property" argument by
> the GridTableViewer.
>
> In fact, this problem happens when clicking at a position a hidden
> column was located when the GridColumnGroup was expanded.
>
> To sum up :
>
> --------------------
> | group << |
> |----|----|--------|
> |col1|col2| col3 |
> |----|----|--------|
> | | | |
>
> ---------------
> | group >> |
> |----|--------|
> |col1| col3 |
> |----|--------|
> | |XXXXXYYY|
>
> When clicking on XXXXX, you edit col2
> When clicking on YYY, you edit col3
>
>
> The problem comes with the CellModifier. Has anyone else the same problem ?
> Any idea to solve this ?
>
>
> Cheers,
> Philippe
>
>


--
B e s t S o l u t i o n . at
------------------------------------------------------------ --------
Tom Schindl JFace-Committer
------------------------------------------------------------ --------
Re: GridTableViewer - CellModifier problem with collapsed GridColumnGroup? [message #44269 is a reply to message #44240] Thu, 29 November 2007 11:47 Go to previous messageGo to next message
Philippe Ravaine is currently offline Philippe Ravaine
Messages: 4
Registered: July 2009
Junior Member
Hi Tom,

As you were assuming, another problem in the area is tabbing support.

I just created a snippet and attach it to the new bug I reported : Bug
211466
Hope you'll get time to have a look at it.

Cheers,

Philippe Ravaine
Re: GridTableViewer - CellModifier problem with collapsed GridColumnGroup? [message #44299 is a reply to message #44269] Thu, 29 November 2007 12:36 Go to previous messageGo to next message
Thomas Schindl is currently offline Thomas Schindl
Messages: 5256
Registered: July 2009
Senior Member
Thank you for the great snippet Philippe. This makes fixing bugs fun :-)

Tom

Ravaine Philippe schrieb:
> Hi Tom,
>
> As you were assuming, another problem in the area is tabbing support.
>
> I just created a snippet and attach it to the new bug I reported : Bug
> 211466
> Hope you'll get time to have a look at it.
>
> Cheers,
>
> Philippe Ravaine
>


--
B e s t S o l u t i o n . at
------------------------------------------------------------ --------
Tom Schindl JFace-Committer
------------------------------------------------------------ --------
Re: GridTableViewer - CellModifier problem with collapsed GridColumnGroup? [message #44389 is a reply to message #44299] Thu, 29 November 2007 18:08 Go to previous message
Chris Gross is currently offline Chris Gross
Messages: 253
Registered: July 2009
Senior Member
Bug fixed :)

And I agree with Tom - great bug report! Thanks.

-Chris

Tom Schindl wrote:
> Thank you for the great snippet Philippe. This makes fixing bugs fun :-)
>
> Tom
>
> Ravaine Philippe schrieb:
>> Hi Tom,
>>
>> As you were assuming, another problem in the area is tabbing support.
>>
>> I just created a snippet and attach it to the new bug I reported : Bug
>> 211466
>> Hope you'll get time to have a look at it.
>>
>> Cheers,
>>
>> Philippe Ravaine
>>
>
>
Re: GridTableViewer - CellModifier problem with collapsed GridColumnGroup? [message #586760 is a reply to message #44209] Thu, 29 November 2007 06:12 Go to previous message
Thomas Schindl is currently offline Thomas Schindl
Messages: 5256
Registered: July 2009
Senior Member
Hi,

It seems that the algorithm to find the correct column to edit is not
working. I suppose the problem is found in
GridViewerRow#getColumnIndex(Point) where we try to correct index.

I think we never tested this at least I haven't so it is fairly likely
that it's not working as expected. Another problem in this area could be
tabbing support.

Ravaine would you mind to creating a snippet (we can run without
modifications) to reproduce the problem and file a bugzilla. I'll take
at it look then.

Tom

Ravaine Philippe schrieb:
> Hi all,
>
> working with Nebula latest release, I have a problem with editable cells
> on a GridTableViewer, with collapsed GridColumnGroup.
>
> Let's assume I have 3 GridColumn (col1,col2,col3).
> The one in the middle has : col2.setSummary(false);
>
> The table shows the right values, GridColumngroup Expanded and Collapsed
> ; meaning that the LabelProvider works well GridColumnGroup.
>
> When GridColumnGroup expanded, a click on any cell of any column allows
> to edit the right value.
> When Collapsed, a click on col3 give the opportunity to edit hidden col2.
> The methods of the CellModifier are given wrong "property" argument by
> the GridTableViewer.
>
> In fact, this problem happens when clicking at a position a hidden
> column was located when the GridColumnGroup was expanded.
>
> To sum up :
>
> --------------------
> | group << |
> |----|----|--------|
> |col1|col2| col3 |
> |----|----|--------|
> | | | |
>
> ---------------
> | group >> |
> |----|--------|
> |col1| col3 |
> |----|--------|
> | |XXXXXYYY|
>
> When clicking on XXXXX, you edit col2
> When clicking on YYY, you edit col3
>
>
> The problem comes with the CellModifier. Has anyone else the same problem ?
> Any idea to solve this ?
>
>
> Cheers,
> Philippe
>
>


--
B e s t S o l u t i o n . at
------------------------------------------------------------ --------
Tom Schindl JFace-Committer
------------------------------------------------------------ --------
Re: GridTableViewer - CellModifier problem with collapsed GridColumnGroup? [message #586772 is a reply to message #44240] Thu, 29 November 2007 11:47 Go to previous message
Philippe Ravaine is currently offline Philippe Ravaine
Messages: 4
Registered: July 2009
Junior Member
Hi Tom,

As you were assuming, another problem in the area is tabbing support.

I just created a snippet and attach it to the new bug I reported : Bug
211466
Hope you'll get time to have a look at it.

Cheers,

Philippe Ravaine
Re: GridTableViewer - CellModifier problem with collapsed GridColumnGroup? [message #586781 is a reply to message #44269] Thu, 29 November 2007 12:36 Go to previous message
Thomas Schindl is currently offline Thomas Schindl
Messages: 5256
Registered: July 2009
Senior Member
Thank you for the great snippet Philippe. This makes fixing bugs fun :-)

Tom

Ravaine Philippe schrieb:
> Hi Tom,
>
> As you were assuming, another problem in the area is tabbing support.
>
> I just created a snippet and attach it to the new bug I reported : Bug
> 211466
> Hope you'll get time to have a look at it.
>
> Cheers,
>
> Philippe Ravaine
>


--
B e s t S o l u t i o n . at
------------------------------------------------------------ --------
Tom Schindl JFace-Committer
------------------------------------------------------------ --------
Re: GridTableViewer - CellModifier problem with collapsed GridColumnGroup? [message #586838 is a reply to message #44299] Thu, 29 November 2007 18:08 Go to previous message
Chris Gross is currently offline Chris Gross
Messages: 471
Registered: July 2009
Senior Member
Bug fixed :)

And I agree with Tom - great bug report! Thanks.

-Chris

Tom Schindl wrote:
> Thank you for the great snippet Philippe. This makes fixing bugs fun :-)
>
> Tom
>
> Ravaine Philippe schrieb:
>> Hi Tom,
>>
>> As you were assuming, another problem in the area is tabbing support.
>>
>> I just created a snippet and attach it to the new bug I reported : Bug
>> 211466
>> Hope you'll get time to have a look at it.
>>
>> Cheers,
>>
>> Philippe Ravaine
>>
>
>
Previous Topic:GridViewer and SWT.VIRTUAL
Next Topic:Re: Using Nebula CalendarCombo and DataBinding
Goto Forum:
  


Current Time: Tue Jul 29 23:04:17 EDT 2014

Powered by FUDForum. Page generated in 0.01959 seconds