Eclipse Community Forums: EGit / JGit » Reword: Add change id for gerrit

Help

Home

Home » Eclipse Projects » EGit / JGit » Reword: Add change id for gerrit

Show: Today's Messages :: Show Polls :: Message Navigator

Reword: Add change id for gerrit [message #1402791]

Thu, 17 July 2014 13:55

Felix Dorner

Messages: 295
Registered: March 2012

Senior Member

Hi,

I accidentally made a few commits without adding a change id for gerrit.
How can I reword these commits, adding a gerrit change Id? Is it
sufficient to just add the Change-Id:00000.... "template" and the real
id will be filled in on commit?

Felix

Report message to a moderator

Re: Reword: Add change id for gerrit [message #1402813 is a reply to message #1402791]

Thu, 17 July 2014 14:47

Felix Dorner

Messages: 295
Registered: March 2012

Senior Member

On 17/07/2014 15:55, Felix Dorner wrote:
> Hi,
>
> I accidentally made a few commits without adding a change id for gerrit.
> How can I reword these commits, adding a gerrit change Id? Is it
> sufficient to just add the Change-Id:00000.... "template" and the real
> id will be filled in on commit?
>
Managed to do it with a sequence of soft resets + cherry picks.

Report message to a moderator

Re: Reword: Add change id for gerrit [message #1403393 is a reply to message #1402791]

Wed, 23 July 2014 12:10

Matthias Sohn

Messages: 1268
Registered: July 2009

Senior Member

The easiest way is to use interactive rebase and "edit" all commits which lack the changeId and click the "Add Change-Id button" in the staging view while editing each of these commits. Adding the Change-Id template
Change-Id: I0000000000000000000000000000000000000000 in the reword dialog unfortunately doesn't work.

In order to simplify this we should add the "Add Change-Id" and "Add Signed-off-by" buttons in the dialog coming up when using "Reword" during interactive rebase.

Report message to a moderator