Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Web Tools Project (WTP) » Vex: "Insert Element" shortcut doesn't work
Vex: "Insert Element" shortcut doesn't work [message #233514] Mon, 13 July 2009 00:04 Go to next message
David O'Shea is currently offline David O'Shea
Messages: 3
Registered: July 2009
Junior Member
Hi all,

With the Vex build I20090616151716 in Eclipse 3.5.0 (and also with
I20090309041723 in Galileo RC3), both under Windows, I find that whatever
shortcut is set for the "Insert Element" command in Window -> Preferences
-> General -> Keys doesn't work. I have tried with it left at the
default, the Insert key, and found that nothing happens when I hit that
key, and tried changing it to my usual preference, Ctrl-Space, and found
that this just causes a space to be inserted. I note that right-clicking
and selecting "Insert Element" works, though.

This works for me with Vex 1.2.1 in Eclipse 3.1.2 under Windows (where the
default was Ctrl-Space - hence my preference :) ) and Vex 1.2.2 under
Fedora Eclipse (not sure which version it is that came with Fedora 10 -
can check if required).

Thanks in advance,
David
Re: Vex: "Insert Element" shortcut doesn't work [message #233522 is a reply to message #233514] Mon, 13 July 2009 03:55 Go to previous messageGo to next message
Eclipse User
Originally posted by: dcarver.starstandard.org

VEX doesn't use the standard Eclipse editor, it has it's own graphical
editing widget. It sounds like there is a bug in some of the
conversion when it migrated from sourceforge to eclipse. Please open a
bug report in the WTP Incubator for this, and patches are always welcome.

Dave


David O'Shea wrote:
> Hi all,
>
> With the Vex build I20090616151716 in Eclipse 3.5.0 (and also with
> I20090309041723 in Galileo RC3), both under Windows, I find that
> whatever shortcut is set for the "Insert Element" command in Window ->
> Preferences -> General -> Keys doesn't work. I have tried with it left
> at the default, the Insert key, and found that nothing happens when I
> hit that key, and tried changing it to my usual preference, Ctrl-Space,
> and found that this just causes a space to be inserted. I note that
> right-clicking and selecting "Insert Element" works, though.
>
> This works for me with Vex 1.2.1 in Eclipse 3.1.2 under Windows (where
> the default was Ctrl-Space - hence my preference :) ) and Vex 1.2.2
> under Fedora Eclipse (not sure which version it is that came with Fedora
> 10 - can check if required).
>
> Thanks in advance,
> David
>
Re: Vex: "Insert Element" shortcut doesn't work [message #233538 is a reply to message #233522] Mon, 13 July 2009 06:22 Go to previous messageGo to next message
David O'Shea is currently offline David O'Shea
Messages: 3
Registered: July 2009
Junior Member
Hi David,

David Carver wrote:

> VEX doesn't use the standard Eclipse editor, it has it's own graphical
> editing widget. It sounds like there is a bug in some of the
> conversion when it migrated from sourceforge to eclipse. Please open a
> bug report in the WTP Incubator for this, and patches are always welcome.

I've filed https://bugs.eclipse.org/bugs/show_bug.cgi?id=283293, please
accept my apologies for any errors as this is my first time filing an
Eclipse bug and I didn't run across any obvious guidelines!

I don't mind the idea of trying to fix it myself, but I've never done any
Eclipse plugin work before. I imagine I won't have too much trouble
finding some tutorials, but would you by any chance be able to suggest
what part of the code would be responsible for this behaviour?

Thanks in advance,
David
Re: Vex: "Insert Element" shortcut doesn't work [message #233578 is a reply to message #233538] Mon, 13 July 2009 10:16 Go to previous messageGo to next message
Eclipse User
Originally posted by: dcarver.starstandard.org

David O'Shea wrote:
> Hi David,
>
> David Carver wrote:
> I don't mind the idea of trying to fix it myself, but I've never done
> any Eclipse plugin work before. I imagine I won't have too much trouble
> finding some tutorials, but would you by any chance be able to suggest
> what part of the code would be responsible for this behaviour?
>

It's been a while since I looked at the VEX code, but I would check the
VEX Editor, or the plugin.xml for the extension points for the
keybindings and action handlers. These actually need to be converted
at some point to the new command and handler framework, but that hasn't
been started yet. Let me see if I can get some time this morning to
take a quick look to point you in the correct direction.

Dave
Re: Vex: "Insert Element" shortcut doesn't work [message #233626 is a reply to message #233578] Mon, 13 July 2009 19:18 Go to previous messageGo to next message
David O'Shea is currently offline David O'Shea
Messages: 3
Registered: July 2009
Junior Member
David Carver wrote:

> It's been a while since I looked at the VEX code

Does that mean that it's been a while since anyone looked at the code?

> Let me see if I can get some time this morning to
> take a quick look to point you in the correct direction.

Thanks, I saw the update in the bug report. With respect to the multi
page editor, if the keyboard shortcuts are implemented there, is there any
reason I shouldn't just try using that? Why are you suggesting it should
be removed - does it have other problems?

Regards,
David
Re: Vex: "Insert Element" shortcut doesn't work [message #233639 is a reply to message #233626] Mon, 13 July 2009 22:12 Go to previous message
Eclipse User
Originally posted by: dcarver.starstandard.org

I'm the sole developer on the code at the moment. The last time I
touched it was couple of months ago, but pulled away to concentrate on
getting Galileo items out the door. It is still being worked.

You can try the keyboard short cuts from there, but the MultiPage editor
doesn't synchronize the XML source and the VEX Visual Designer
correctly. Plus the VEX data model doesn't correctly handle items like
Namespaces, Processing Instructions or Comments. You loose these when
loading the XML into the VEX Model. This isn't a MultiPage Editor issue
per-say, but makes it very difficult to synchronize the two models.

You can try the MultiPage Editor and it should still work, but results
may vary on it.

Dave


David O'Shea wrote:
> David Carver wrote:
>
>> It's been a while since I looked at the VEX code
>
> Does that mean that it's been a while since anyone looked at the code?
>
>> Let me see if I can get some time this morning to take a quick look to
>> point you in the correct direction.
>
> Thanks, I saw the update in the bug report. With respect to the multi
> page editor, if the keyboard shortcuts are implemented there, is there
> any reason I shouldn't just try using that? Why are you suggesting it
> should be removed - does it have other problems?
>
> Regards,
> David
>
Previous Topic:Why does not folding Outline view in Galileo.....
Next Topic:Glassfishv3 Startup Failure
Goto Forum:
  


Current Time: Wed Aug 27 15:23:10 EDT 2014

Powered by FUDForum. Page generated in 0.07143 seconds