Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » GEF » SpaceTreeLayoutAlgorithm performance issue(Layouting takes forever with SpaceTreeLayoutAlgorithm )
SpaceTreeLayoutAlgorithm performance issue [message #1272976] Wed, 19 March 2014 04:04 Go to next message
Robert Walter is currently offline Robert Walter
Messages: 29
Registered: July 2011
Junior Member
Hi,

I just tried out Zest. After I was able to display a graph I noticed that I was using a very old Update Site which gave me some Zest 1.X stuff. I read about the new stuff of Zest 2 and migrated my first app (BTW: It is a pain to find the actual update sites. A lot of dead/old links, e.g. here http://www.eclipse.org/gef/updates/index.php; the ACTUAL update sites provided here http://download.eclipse.org/tools/gef/gef4/updates/milestones point either to a dead end (releases) or contain only parts of the plugins (milestones only offers "geometry").
Why is it still so hard to maintain links to update sites?

Anyway, I used "integration" now, I was able to get GEF4/Zest from there.

When using SpaceTreeLayoutAlgorithm with a graph containing some 100 nodes, the layouting takes forever (like, more than a minute). Even if the graph is very simple (just a chain of nodes). I tracked down the bottle neck to the call "layoutAlgorithm.applyLayout(clean);" in InternalLayoutContext (line 367). Didn't want to debug the algorithm itself.

Anyway, let me know if you are aware of that problem and if there are any adjustments one can make to use this layout.
Re: SpaceTreeLayoutAlgorithm performance issue [message #1273132 is a reply to message #1272976] Wed, 19 March 2014 11:09 Go to previous messageGo to next message
Alexander Nyssen is currently offline Alexander Nyssen
Messages: 40
Registered: July 2009
Location: Lünen
Member
The links provided at http://www.eclipse.org/gef/updates/index.php are not dead. These are the update-sites related to Draw2d/GEF (MVC) 3.x and Zest 1.x, which are still the production components. The update-sites for GEF4 (into which the Zest2 code base was merged) are listed in the GEF4 wiki. In addition, all sites are also listed on (https://projects.eclipse.org/projects/tools.gef/downloads), while due to a bug in the Eclipse dashboard they currently get truncated there (which is the reason why we still list them in the other locations as well).

Concerning the GEF4 releases and milestone sites I have to say that these are not populated yet because there are no milestones/releases yet. You are right, there was an early version of GEF Geometry published to the milestone site for testing purposes; I have cleaned that away (so milestone site is now empty as well) and added a comment that these sites are not yet populated.

Concerning your other issues, please report a bug.
Re: SpaceTreeLayoutAlgorithm performance issue [message #1273144 is a reply to message #1273132] Wed, 19 March 2014 11:40 Go to previous messageGo to next message
Robert Walter is currently offline Robert Walter
Messages: 29
Registered: July 2011
Junior Member
Hi Alexander,
thanks for the quick response and the clarification.
Sometimes it just gets frustrating when you have an idea but it takes you for hours before you actually can get started.
Robert
Re: SpaceTreeLayoutAlgorithm performance issue [message #1278836 is a reply to message #1272976] Thu, 27 March 2014 19:03 Go to previous messageGo to next message
Zoltan Ujhelyi is currently offline Zoltan Ujhelyi
Messages: 200
Registered: July 2009
Senior Member
Hi Robert,

I guess I have found the root cause of your performance issues related to the SpaceTreeLayoutAlgorithm.

When animations are turned on, the algorithm is really slow; and you have explicitely turned on animations via the second parameter (new SpaceTreeLayoutAlgorithm(SpaceTreeLayoutAlgorithm.LEFT_DOWN, true)Wink, as you have displayed in the bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=430851#c1

I don't have time right now to find out why are animations so slow, but as a workaround, I turned off animations by default, and suggest not to turn it on via the second constructor parameter. Additionally, I have opened bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=431417 for future references.

Could you please check that turning off animations do speed up your application with larger models?

Thanks,
Zoltán
Re: SpaceTreeLayoutAlgorithm performance issue [message #1278965 is a reply to message #1278836] Fri, 28 March 2014 00:08 Go to previous messageGo to next message
Robert Walter is currently offline Robert Walter
Messages: 29
Registered: July 2011
Junior Member
Yes, switching off the animation is a tremendous performance boost, thanks!

I can definitely use this layout algorthm now. However, when exchanging the TreeLayoutAlgorithm with the SpaceTreeLayoutAlgorithm, my implementation of IEntityStyleProvider for fishEyeNode seems to be ignored. I assume I cannot use fisheye-nodes with STLA, am I right?

Robert
Re: SpaceTreeLayoutAlgorithm performance issue [message #1279101 is a reply to message #1278965] Fri, 28 March 2014 04:29 Go to previous message
Zoltan Ujhelyi is currently offline Zoltan Ujhelyi
Messages: 200
Registered: July 2009
Senior Member
Thanks for the feedback!

I don't know the internals of these layouts fully, but I know that SpaceTreeLayoutAlgorithm uses subtree rendering that is different to the default rendering, that might conflict with the fishEyeNode implementation. I suggest opening a bug for this, and then someone will look into it.

Cheers,
Zoltán
Previous Topic:Zest - GraphContainer with Custom Nodes
Next Topic:Customize a GraphContainer
Goto Forum:
  


Current Time: Tue Jul 29 19:12:50 EDT 2014

Powered by FUDForum. Page generated in 0.02667 seconds