Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Buckminster » is git.auto.fetch implemented at all?
is git.auto.fetch implemented at all? [message #1226792] Thu, 02 January 2014 13:21 Go to next message
Lorenzo Bettini is currently offline Lorenzo Bettini
Messages: 1321
Registered: July 2009
Senior Member
Hi

Is git.auto.fetch considered during materialization?

I have it in my rmap, but if I materialize an eclipse workspace again
(using the same cloned repository) it never auto pulls changes (I saw
also this http://www.eclipse.org/forums/index.php/t/221619/ ). The same
holds if I remove the eclipse workspace and start the materialization again.

Indeed, by looking at
http://git.eclipse.org/c/buckminster/buckminster.git/tree/org.eclipse.buckminster.git/src/org/eclipse/buckminster/git/internal/RepositoryAccess.java
the property is stored in the field autoFetch but never used later...

cheers
Lorenzo

--
Lorenzo Bettini, PhD in Computer Science, DI, Univ. Torino
HOME: http://www.lorenzobettini.it
Xtext Book:
http://www.packtpub.com/implementing-domain-specific-languages-with-xtext-and-xtend/book
Re: is git.auto.fetch implemented at all? [message #1229407 is a reply to message #1226792] Thu, 09 January 2014 06:33 Go to previous messageGo to next message
Lorenzo Bettini is currently offline Lorenzo Bettini
Messages: 1321
Registered: July 2009
Senior Member
anyone?

On 02/01/2014 19:21, Lorenzo Bettini wrote:
> Hi
>
> Is git.auto.fetch considered during materialization?
>
> I have it in my rmap, but if I materialize an eclipse workspace again
> (using the same cloned repository) it never auto pulls changes (I saw
> also this http://www.eclipse.org/forums/index.php/t/221619/ ). The same
> holds if I remove the eclipse workspace and start the materialization again.
>
> Indeed, by looking at
> http://git.eclipse.org/c/buckminster/buckminster.git/tree/org.eclipse.buckminster.git/src/org/eclipse/buckminster/git/internal/RepositoryAccess.java
> the property is stored in the field autoFetch but never used later...
>
> cheers
> Lorenzo
>


--
Lorenzo Bettini, PhD in Computer Science, DI, Univ. Torino
HOME: http://www.lorenzobettini.it
Xtext Book:
http://www.packtpub.com/implementing-domain-specific-languages-with-xtext-and-xtend/book
Re: is git.auto.fetch implemented at all? [message #1233781 is a reply to message #1226792] Mon, 20 January 2014 08:04 Go to previous messageGo to next message
Thomas Hallgren is currently offline Thomas Hallgren
Messages: 3228
Registered: July 2009
Senior Member
On 2014-01-02 19:21, Lorenzo Bettini wrote:
> Hi
>
> Is git.auto.fetch considered during materialization?
>
Not really. That functionality was written as part of the first incarnation of the git support feature. I didn't know
enough about git to do a proper evaluation for a requirement spec. My current recommendation would be to not use it. If
someone has the time to look into how this should be implemented properly, then I'd be very interested in reviewing a
patch. One thing that comes to mind immediately is that the auto.fetch should be called auto.pull (since that's what it
was intended as).

- thomas

> I have it in my rmap, but if I materialize an eclipse workspace again
> (using the same cloned repository) it never auto pulls changes (I saw
> also this http://www.eclipse.org/forums/index.php/t/221619/ ). The same
> holds if I remove the eclipse workspace and start the materialization again.
>
> Indeed, by looking at
> http://git.eclipse.org/c/buckminster/buckminster.git/tree/org.eclipse.buckminster.git/src/org/eclipse/buckminster/git/internal/RepositoryAccess.java
> the property is stored in the field autoFetch but never used later...
>
> cheers
> Lorenzo
>
Re: is git.auto.fetch implemented at all? [message #1236869 is a reply to message #1233781] Tue, 28 January 2014 04:06 Go to previous message
Lorenzo Bettini is currently offline Lorenzo Bettini
Messages: 1321
Registered: July 2009
Senior Member
On 20/01/2014 14:04, Thomas Hallgren wrote:
> On 2014-01-02 19:21, Lorenzo Bettini wrote:
>> Hi
>>
>> Is git.auto.fetch considered during materialization?
>>
> Not really. That functionality was written as part of the first
> incarnation of the git support feature. I didn't know enough about git
> to do a proper evaluation for a requirement spec. My current
> recommendation would be to not use it. If someone has the time to look
> into how this should be implemented properly, then I'd be very
> interested in reviewing a patch. One thing that comes to mind
> immediately is that the auto.fetch should be called auto.pull (since
> that's what it was intended as).

OK, I'll submit a bug and see whether I can come up with something :)

cheers
Lorenzo

--
Lorenzo Bettini, PhD in Computer Science, DI, Univ. Torino
HOME: http://www.lorenzobettini.it
Xtext Book:
http://www.packtpub.com/implementing-domain-specific-languages-with-xtext-and-xtend/book
Previous Topic:Executing plugIn unit tests with buckminster headless
Next Topic:Cross-platform builds with buckminster 4.3
Goto Forum:
  


Current Time: Thu Aug 21 18:18:22 EDT 2014

Powered by FUDForum. Page generated in 0.05584 seconds