Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Buckminster dev » Including Orbit jars in Buckminster built update site
Including Orbit jars in Buckminster built update site [message #18977] Thu, 29 May 2008 14:19 Go to next message
Eclipse UserFriend
Originally posted by: ohurley.iona.com

As part of the STP build I'm pulling in some Orbit jars that are specific
to the STP components - org.jdom for example.

Here's the way I have it set up. Component x will have a feature called
x.feature. This is what goes into the roll-up update site.

x.feature will have a plugin dependency on org.jdom

I'll do a build, and org.jdom gets materialized as expected. When I
build the site, however, I expected org.jdom to be in there, but it
isn't.

I'm currently using 1.1.0.r09308 headless. With previous versions, I
did see the org.jdom bundle going into the site archive. Perhaps the
rule have changed and I need to specify org.jdom somewhere in the
cspec? Suggestions are appreciated!

best regards
Oisin

--
Oisin Hurley at IONA
http://blogs.iona.com/ohurley/
Re: Including Orbit jars in Buckminster built update site [message #18999 is a reply to message #18977] Thu, 29 May 2008 18:44 Go to previous messageGo to next message
Thomas Hallgren is currently offline Thomas HallgrenFriend
Messages: 3229
Registered: July 2009
Senior Member
Hi Oisin,

Oisin Hurley wrote:
> As part of the STP build I'm pulling in some Orbit jars that are specific
> to the STP components - org.jdom for example.
>
> Here's the way I have it set up. Component x will have a feature called
> x.feature. This is what goes into the roll-up update site.
>
> x.feature will have a plugin dependency on org.jdom
>
> I'll do a build, and org.jdom gets materialized as expected. When I
> build the site, however, I expected org.jdom to be in there, but it
> isn't.
>
> I'm currently using 1.1.0.r09308 headless. With previous versions, I
> did see the org.jdom bundle going into the site archive. Perhaps the
> rule have changed and I need to specify org.jdom somewhere in the
> cspec? Suggestions are appreciated!
>
Nothing has changed that should have an impact on that (our own build
would break if that was the case). If you cspec for the update site
includes the feature that in turn includes the org.jdom, then it should
be included in the generated site.

How is the org.jdom materialized from Orbit? Are you using the
eclipse.import reader?

Regards,
Thomas Hallgren
Re: Including Orbit jars in Buckminster built update site [message #19021 is a reply to message #18999] Thu, 29 May 2008 20:00 Go to previous messageGo to next message
Eclipse UserFriend
Originally posted by: ohurley.iona.com

Thomas Hallgren wrote:
> Nothing has changed that should have an impact on that (our own build
> would break if that was the case). If you cspec for the update site
> includes the feature that in turn includes the org.jdom, then it should
> be included in the generated site.

Indeed, that is what I thought. It could be that I am missing something
basic as per usual :|

There's a build dir set up at /shared/stp/build/trunk/buckminster on
build.eclipse.org - I build from there using

ant -Dbase.directory=`pwd`/testbuild build stp.build.site

to make the site. Which, I might add, is very convenient, thanks :)

> How is the org.jdom materialized from Orbit? Are you using the
> eclipse.import reader?

Here's the searchPath piece for Orbit - I basically just match on *, i.e.
Orbit is the 'fallthru' :

<searchPath name="orbit">
<provider readerType="eclipse.import" componentTypes="osgi.bundle"
mutable="false" source="false">
<uri format=" http://download.eclipse.org/tools/orbit/downloads/drops/S200 80
527182727/orbitBundles-S20080527182727.map"
/>
</provider>
</searchPath>
(see [1])

best regards
Oisin

[1] http://dev.eclipse.org/svnroot/stp/build/trunk/buckminster/s tp.rmap

--
Oisin Hurley at IONA
http://blogs.iona.com/ohurley/
Re: Including Orbit jars in Buckminster built update site [message #19041 is a reply to message #19021] Fri, 30 May 2008 05:48 Go to previous messageGo to next message
Thomas Hallgren is currently offline Thomas HallgrenFriend
Messages: 3229
Registered: July 2009
Senior Member
HI Oisin,
I ran you build and took a snapshot of the result. I'll analyze that and
get back to you.

Regards,
Thomas Hallgren

Oisin Hurley wrote:
> Thomas Hallgren wrote:
>> Nothing has changed that should have an impact on that (our own build
>> would break if that was the case). If you cspec for the update site
>> includes the feature that in turn includes the org.jdom, then it should
>> be included in the generated site.
>
> Indeed, that is what I thought. It could be that I am missing something
> basic as per usual :|
>
> There's a build dir set up at /shared/stp/build/trunk/buckminster on
> build.eclipse.org - I build from there using
>
> ant -Dbase.directory=`pwd`/testbuild build stp.build.site
>
> to make the site. Which, I might add, is very convenient, thanks :)
>
>> How is the org.jdom materialized from Orbit? Are you using the
>> eclipse.import reader?
>
> Here's the searchPath piece for Orbit - I basically just match on *, i.e.
> Orbit is the 'fallthru' :
>
> <searchPath name="orbit">
> <provider readerType="eclipse.import" componentTypes="osgi.bundle"
> mutable="false" source="false">
> <uri format=" http://download.eclipse.org/tools/orbit/downloads/drops/S200 80
> 527182727/orbitBundles-S20080527182727.map"
> />
> </provider>
> </searchPath>
> (see [1])
>
> best regards
> Oisin
>
> [1] http://dev.eclipse.org/svnroot/stp/build/trunk/buckminster/s tp.rmap
>
Re: Including Orbit jars in Buckminster built update site [message #19059 is a reply to message #19021] Fri, 30 May 2008 06:16 Go to previous messageGo to next message
Thomas Hallgren is currently offline Thomas HallgrenFriend
Messages: 3229
Registered: July 2009
Senior Member
I found the problem.

The build.stp.site action found in buckminster.cspec in your
org.eclipse.stp.build.root project has the following limited prerequisite:

<cs:attribute name="bundle.jars" alias="plugins"
includePattern=".*\.stp\..*"/>

The includePattern effectively rules out all bundles that doesn't have
..stp. in their names. We have a similar rule in our build. We use it to
exclude all bundles that stem from the target platform from the
resulting update-site.

This rule must be maintained when new bundles are added. Currently this
is the only way to tell Buckminster that not everything in the
transitive scope of the included features is supposed to be in the
generated site. Suggestions on how to improve this are welcome.

I made a change to your setting so that it now read:

<cs:attribute name="bundle.jars" alias="plugins"
includePattern=".*\.(stp\.|jdom).*"/>

I retried the build and now the org.jdom is included in the produced site.

Regards,
Thomas Hallgren


Oisin Hurley wrote:
> Thomas Hallgren wrote:
>> Nothing has changed that should have an impact on that (our own build
>> would break if that was the case). If you cspec for the update site
>> includes the feature that in turn includes the org.jdom, then it should
>> be included in the generated site.
>
> Indeed, that is what I thought. It could be that I am missing something
> basic as per usual :|
>
> There's a build dir set up at /shared/stp/build/trunk/buckminster on
> build.eclipse.org - I build from there using
>
> ant -Dbase.directory=`pwd`/testbuild build stp.build.site
>
> to make the site. Which, I might add, is very convenient, thanks :)
>
>> How is the org.jdom materialized from Orbit? Are you using the
>> eclipse.import reader?
>
> Here's the searchPath piece for Orbit - I basically just match on *, i.e.
> Orbit is the 'fallthru' :
>
> <searchPath name="orbit">
> <provider readerType="eclipse.import" componentTypes="osgi.bundle"
> mutable="false" source="false">
> <uri format=" http://download.eclipse.org/tools/orbit/downloads/drops/S200 80
> 527182727/orbitBundles-S20080527182727.map"
> />
> </provider>
> </searchPath>
> (see [1])
>
> best regards
> Oisin
>
> [1] http://dev.eclipse.org/svnroot/stp/build/trunk/buckminster/s tp.rmap
>
Re: Including Orbit jars in Buckminster built update site [message #19218 is a reply to message #19059] Fri, 30 May 2008 10:54 Go to previous message
Eclipse UserFriend
Originally posted by: ohurley.iona.com

Thomas Hallgren wrote:
> The build.stp.site action found in buckminster.cspec in your
> org.eclipse.stp.build.root project has the following limited prerequisite:
>
> <cs:attribute name="bundle.jars" alias="plugins"
> includePattern=".*\.stp\..*"/>

Tested and confirmed - thanks Thomas! I guess this is how I could
make a huge all-in-one update site, if the includePattern just had
".*", it would include everything that got materialized and the
platform itself into one enormous update site :)

For the moment I'll just stick to the pieces that come from Orbit.

best regards
Oisin

--
Oisin Hurley at IONA
http://blogs.iona.com/ohurley/
Previous Topic:Re: [buckminster-dev] Strange resolver behaviour when resolving PDE plugins - using "native&quo
Next Topic:[buckminster-dev] 3.4 headless site a bit unwell?
Goto Forum:
  


Current Time: Mon Nov 24 18:07:42 GMT 2014

Powered by FUDForum. Page generated in 0.02731 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software