Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Modeling » Compare » Potential Bug in ProximityEObjectMatcher
Potential Bug in ProximityEObjectMatcher [message #1181115] Mon, 11 November 2013 11:33 Go to next message
Benjamin Klatt is currently offline Benjamin Klatt
Messages: 36
Registered: September 2010
Member
Hi,

I do not have any test code to provide, but during code reading I noticed this code line in the ProximityEObjectMatcher:

while (leftEObjects.hasNext() || rightEObjects.hasNext() || leftEObjects.hasNext()) {


http://git.eclipse.org/c/emfcompare/org.eclipse.emf.compare.git/tree/plugins/org.eclipse.emf.compare/src/org/eclipse/emf/compare/match/eobject/ProximityEObjectMatcher.java#n94

According to the code, I would expect the third condition to be originEObjects.hasNext()

while (leftEObjects.hasNext() || rightEObjects.hasNext() || originEObjects.hasNext()) {


All the best
Benjamin
Re: Potential Bug in ProximityEObjectMatcher [message #1196051 is a reply to message #1181115] Tue, 19 November 2013 08:14 Go to previous message
Axel RICHARD is currently offline Axel RICHARD
Messages: 19
Registered: September 2010
Location: France
Junior Member
Hi Benjamin,

Thanks to you. A review to fix the problem has been proposed (https://git.eclipse.org/r/#/c/18547/) and will be integrate soon.

Axel.


Axel Richard
Obeo
Previous Topic:Merging conflicting models?
Next Topic:Single-Side Match and location of ADD Diff
Goto Forum:
  


Current Time: Sat Oct 25 02:52:45 GMT 2014

Powered by FUDForum. Page generated in 0.01648 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software