Eclipse Community Forums: Graphiti » Problems view not refreshed after undo / redo

Help

Home

Home » Modeling » Graphiti » Problems view not refreshed after undo / redo

Show: Today's Messages :: Show Polls :: Message Navigator

Problems view not refreshed after undo / redo [message #1151264]

Wed, 23 October 2013 08:25

Laurent Le Moux

Messages: 184
Registered: September 2011

Senior Member

Hi all,

I recently implemented some kind of diagram validation.
My validator is executed a first time when I instanciate my "GraphitiToolBehaviorProvider" so that markers are created and displayed in the problems view when the diagram is first loaded.

	public GraphitiToolBehaviorProvider(IDiagramTypeProvider diagramTypeProvider) {
		super(diagramTypeProvider);
		if ((diagValidator = ((GraphitiDiagramTypeProvider)diagramTypeProvider).getDiagramValidator()) != null)
			diagValidator.validate(getFeatureProvider());
	}

Then, the validator is run again in my GraphitiToolBehaviorProvider#postExecute implementation. Actually validation occurs only for some determined features.

	public void postExecute(IExecutionInfo executionInfo) {
		if (diagValidator != null) {
			IFeatureAndContext[] array = executionInfo.getExecutionList();
			if (array.length > 0) {
				IFeatureAndContext fac = array[0];
				if (fac.getFeature() instanceof IAddFeature || fac.getFeature() instanceof IRemoveFeature
						|| fac.getFeature() instanceof IDeleteFeature || fac.getFeature() instanceof IDirectEditingFeature
						|| fac.getFeature() instanceof IUpdateFeature)
					diagValidator.validate(fac.getFeature().getFeatureProvider());
			}
		}
	}

All this works fine, except with undo / redo. In this case, there's no invocation of postExecute. So, validation is not triggered and the problems view not refreshed accordingly.

It seems a validator invocation is missing elsewhere.
Could somebody please tell where to add it ?

Regards,

Laurent

Report message to a moderator

Re: Problems view not refreshed after undo / redo [message #1151462 is a reply to message #1151264]

Wed, 23 October 2013 11:13

Michael Wenz

Messages: 1931
Registered: July 2009
Location: Walldorf, Germany

Senior Member

Laurent,

that appears to be a gap, there is no global hook to be called when
undo/redo is performed. There are however callbacks in the feature, butthat
would require you to call to validation in each features undo and redo
method...

Would you please file an enhamcement bugzilla for this against Graphiti? I
think there should be hooks postUndo() and postRedo() just like the
postExecute().

Thanks,
Michael

Report message to a moderator