Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Modeling » Papyrus » Problems with Loading of Controlled Units
Problems with Loading of Controlled Units [message #1090720] Tue, 20 August 2013 10:54 Go to next message
Christian W. Damus is currently offline Christian W. Damus
Messages: 701
Registered: July 2009
Senior Member
Hi,

There are several strategies that the user can choose from in the
preferences to indicate how to handle controlled units when loading
model content. Some of these options result in a controlled unit's
resource not being loaded, either because the user said 'no' when
prompted or because the preference was set to not ask the user.

But, how is the user supposed to change this decision and load a
controlled unit? I don't see any action in the Model Explorer context
menu to load an unloaded unit. In fact, I have the option to create a
controlled unit but it already is controlled! It just isn't loaded and
so is a proxy.

(note also that it is difficult to distinguish multiple unloaded units
because all that they show in the explorer is the identical package
icon; no names)

It seems that I have to use the "Load Resource..." context menu action
(contributed by EMF) in a diagram to load the appropriate .uml file.
This is not intuitive, nor is it helpful for resources in CDO
repositories because EMF only supports browsing the filesystem and
workspace (users will have to know how to type the CDO resource URI
themselves).

However, even this has problems, because the "Unresolved tab" page for
unloaded diagrams doesn't resolve itself when I use the "Load
Resource..." action to load the appropriate *.di and *.notation
resources. So, I can never access the diagram if I didn't initially
say "yes" to the prompt to load the unit.

Am I missing something? Or are any of these known issues? I'll be
happy to contribute fixes.

I am using the Papyrus sources from git master as of this morning, 20
August. I see these issues in workspace models (not considering CDO
for the moment).

Thanks,

Christian
Re: Problems with Loading of Controlled Units [message #1091424 is a reply to message #1090720] Wed, 21 August 2013 09:33 Go to previous messageGo to next message
Mathieu Velten is currently offline Mathieu Velten
Messages: 5
Registered: August 2010
Junior Member
Hi Christian,

It looks like a backport from the 0.8.X-EYY branch is missing, I backported the core model loading functionality but forgot the model explorer integration part :
You should have Load & Unloaded commands available on controlled resources with it.

Regarding the unresolved tab if I remember correctly it was handled manually by going over the tabs and refresh if needed in the load command handler, which is not ideal (it would be better to react to an EMF event). I think this is one of the reason I didn't backport it last time (conjugated with lack of time to rewrite it).

I can look into it but I can't really commit to a date right now.
If you are stuck because of that you can have a look at the plugin org.eclipse.papyrus.modelexplorer.resourceloading on the EYY branch.

Regards

Addendum :
After looking quickly at the git the plugin seems to be in place on trunk (org.eclipse.papyrus.views.modelexplorer.resourceloading) and seems to be included in the build so this is likely a bug.
Re: Problems with Loading of Controlled Units [message #1091433 is a reply to message #1091424] Wed, 21 August 2013 09:44 Go to previous messageGo to next message
Christian W. Damus is currently offline Christian W. Damus
Messages: 701
Registered: July 2009
Senior Member
Thanks for the pointers, Mathieu.

Indeed, the Model Explorer actions are made visible according to
property testers (isAllLoaded, isAllNotLoaded) that target the
IStructuredSelection type. That seems suspicious; I don't know how it
could work because property testers are applied by Eclipse to the
elements contained in the selection, not to the selection object as a
whole.

I'm currently using Kepler release as my target platform.

When I get a chance, I'll look into it.

cW


On 2013-08-21 13:33:31 +0000, Mathieu Velten said:

> Hi Christian,
>
> It looks like a backport from the 0.8.X-EYY branch is missing, I
> backported the core model loading functionality but forgot the model
> explorer integration part :
> You should have Load & Unloaded commands available on controlled
> resources with it.
>
> Regarding the unresolved tab if I remember correctly it was handled
> manually by going over the tabs and refresh if needed in the load
> command handler, which is not ideal (it would be better to react to an
> EMF event). I think this is one of the reason I didn't backport it last
> time (conjugated with lack of time to rewrite it).
>
> I can look into it but I can't really commit to a date right now.
> If you are stuck because of that you can have a look at the plugin
> org.eclipse.papyrus.modelexplorer.resourceloading on the EYY branch.
>
> Regards
>
> Addendum :
> After looking quickly at the git the plugin seems to be in place on
> trunk (org.eclipse.papyrus.views.modelexplorer.resourceloading) and
> seems to be included in the build so this is likely a bug.
Re: Problems with Loading of Controlled Units [message #1091679 is a reply to message #1091433] Wed, 21 August 2013 17:06 Go to previous message
Christian W. Damus is currently offline Christian W. Damus
Messages: 701
Registered: July 2009
Senior Member
To follow this up again, I have fixed this problem in bug

https://bugs.eclipse.org/bugs/show_bug.cgi?id=415588

for Kepler SR1 as it basically completely hobbles the "controlled
resources" feature, even in the workspace (never mind CDO).

However, there are follow-up issues that I have to raise but will not
have time to look into:

* as mentioned before, after loading a previously unloaded unit,
unresolved tabs
don't seem to be updated, so they are still duds

* the Unload action hangs the workbench (on Mac with JRE 1.7)

I'll raise bugs for these problems, but I likely won't have time to
look into them because all of my time is allocated to the CDO
integration bits. Help wanted!

cW


On 2013-08-21 13:44:28 +0000, Christian W. Damus said:

> Thanks for the pointers, Mathieu.
>
> Indeed, the Model Explorer actions are made visible according to
> property testers (isAllLoaded, isAllNotLoaded) that target the
> IStructuredSelection type. That seems suspicious; I don't know how it
> could work because property testers are applied by Eclipse to the
> elements contained in the selection, not to the selection object as a
> whole.
>
> I'm currently using Kepler release as my target platform.
>
> When I get a chance, I'll look into it.
>
> cW
>
>
> On 2013-08-21 13:33:31 +0000, Mathieu Velten said:
>
>> Hi Christian,
>>
>> It looks like a backport from the 0.8.X-EYY branch is missing, I
>> backported the core model loading functionality but forgot the model
>> explorer integration part :
>> You should have Load & Unloaded commands available on controlled
>> resources with it.
>>
>> Regarding the unresolved tab if I remember correctly it was handled
>> manually by going over the tabs and refresh if needed in the load
>> command handler, which is not ideal (it would be better to react to an
>> EMF event). I think this is one of the reason I didn't backport it last
>> time (conjugated with lack of time to rewrite it).
>>
>> I can look into it but I can't really commit to a date right now.
>> If you are stuck because of that you can have a look at the plugin
>> org.eclipse.papyrus.modelexplorer.resourceloading on the EYY branch.
>>
>> Regards
>>
>> Addendum :
>> After looking quickly at the git the plugin seems to be in place on
>> trunk (org.eclipse.papyrus.views.modelexplorer.resourceloading) and
>> seems to be included in the build so this is likely a bug.
Previous Topic:Does Stereotype display not working in Papyrus?
Next Topic:change visibility of Standard Palette
Goto Forum:
  


Current Time: Wed Apr 16 03:34:58 EDT 2014

Powered by FUDForum. Page generated in 0.01991 seconds