Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Sapphire » Sapphire 0.7 upgrade and SDEF content include params
Sapphire 0.7 upgrade and SDEF content include params [message #1067897] Thu, 11 July 2013 07:36 Go to next message
Greg Amerson is currently offline Greg AmersonFriend
Messages: 118
Registered: March 2010
Senior Member
Hi guys,

I'm working on migrating our editors to use new Sapphire 0.7 version. So for its been great, it seems a little bit faster and no more @GenerateImpl yeah! Byebye nasty PDE/JDT/APT bug.

One problem I'm having with one of our existing editors is the content include that uses parameters. Previously we had shared component that was included in other places. So the shared section looks like this:

<composite>
    <id>support.eventdef.composite</id>
    <content>
        <property-editor>
            <property>@{Property}</property>
            <child-property>Qname</child-property>
            <child-property>Description</child-property>
            <show-label>false</show-label>
            <span>true</span>
        </property-editor>
    </content>
</composite>


And then in two other places we would include that composite like this:
                <section>
                    <label>Supported Processing Events</label>
                    <content>
                        <include>
                            <part>support.eventdef.composite</part>
                            <param>
                                <value>SupportedProcessingEvents</value>
                                <name>Property</name>
                            </param>
                        </include>
                    </content>
                    <collapsible>true</collapsible>
                </section>
                <section>
                    <label>Supported Publishing Events</label>
                    <collapsible>true</collapsible>
                    <content>
                        <include>
                            <part>support.eventdef.composite</part>
                            <param>
                                <name>Property</name>
                                <value>SupportedPublishingEvents</value>
                            </param>
                        </include>
                    </content>
                </section>


You can see that in the two includes we would pass in the value for the Property argument. This worked in sapphire 0.6 but not in 0.7 In 0.7 it throws an error:

java.lang.RuntimeException: Property editors property reference path "{0}" is invalid.
	at org.eclipse.sapphire.ui.PropertyEditorPart.init(PropertyEditorPart.java:126)
	at org.eclipse.sapphire.ui.SapphirePart.init(SapphirePart.java:186)
	at org.eclipse.sapphire.ui.SapphirePart.create(SapphirePart.java:1247)
	at org.eclipse.sapphire.ui.FormPart.initChildParts(FormPart.java:126)
	at org.eclipse.sapphire.ui.FormPart.init(FormPart.java:42)
	at org.eclipse.sapphire.ui.SapphirePart.init(SapphirePart.java:186)
	at org.eclipse.sapphire.ui.SapphirePart.create(SapphirePart.java:1247)
	at org.eclipse.sapphire.ui.SapphirePart.create(SapphirePart.java:1206)
	at org.eclipse.sapphire.ui.FormPart.initChildParts(FormPart.java:126)
	at org.eclipse.sapphire.ui.FormPart.init(FormPart.java:42)
	at org.eclipse.sapphire.ui.SectionPart.init(SectionPart.java:72)
	at org.eclipse.sapphire.ui.SapphirePart.init(SapphirePart.java:186)
	at org.eclipse.sapphire.ui.form.editors.masterdetails.MasterDetailsContentNode.init(MasterDetailsContentNode.java:250)
	at org.eclipse.sapphire.ui.SapphirePart.init(SapphirePart.java:186)
Re: Sapphire 0.7 upgrade and SDEF content include params [message #1068019 is a reply to message #1067897] Thu, 11 July 2013 17:29 Go to previous messageGo to next message
Konstantin Komissarchik is currently offline Konstantin KomissarchikFriend
Messages: 962
Registered: July 2009
Senior Member
Looks like a regression. Could you open a bug?
Re: Sapphire 0.7 upgrade and SDEF content include params [message #1068082 is a reply to message #1068019] Fri, 12 July 2013 02:26 Go to previous messageGo to next message
Konstantin Komissarchik is currently offline Konstantin KomissarchikFriend
Messages: 962
Registered: July 2009
Senior Member
Never mind on opening a bug. I found the change the introduced the regression and attached the fix to that. Try the next build.

http://git.eclipse.org/c/sapphire/org.eclipse.sapphire.git/commit/?id=4c9b9c7c8560eb580c438208bf21bce039a9d105

[Updated on: Fri, 12 July 2013 02:26]

Report message to a moderator

Re: Sapphire 0.7 upgrade and SDEF content include params [message #1068098 is a reply to message #1068082] Fri, 12 July 2013 07:39 Go to previous messageGo to next message
Greg Amerson is currently offline Greg AmersonFriend
Messages: 118
Registered: March 2010
Senior Member
Sorry just saw your note. I'll give the new commit a try.
Re: Sapphire 0.7 upgrade and SDEF content include params [message #1068110 is a reply to message #1068098] Fri, 12 July 2013 08:35 Go to previous message
Greg Amerson is currently offline Greg AmersonFriend
Messages: 118
Registered: March 2010
Senior Member
Just updated and it working fine now. thanks for quick turnaround!
Previous Topic:Undo/Redo functionality in ui editor
Next Topic:New build server for Sapphire
Goto Forum:
  


Current Time: Sat Dec 20 13:55:17 GMT 2014

Powered by FUDForum. Page generated in 0.04310 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software