Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Hudson » Git plugin push notification
Git plugin push notification [message #1061745] Mon, 03 June 2013 17:38 Go to next message
Eric Smith is currently offline Eric SmithFriend
Messages: 2
Registered: June 2013
Junior Member
Are there plans to implement 'push notification' for the Hudson Git plugin?
//hudsonServer/git/notifyCommit?url=<git repository url>&branches=develop


Here is the corresponding Hudson SVN plugin capability:
wiki.hudson-ci.org/display/HUDSON/Subversion+Plugin#SubversionPlugin-Postcommithook

Here is the corresponding Jenkins Git plugin capability:
wiki.jenkins-ci.org/display/JENKINS/Git+Plugin#GitPlugin-Pushnotificationfromrepository

Thanks.
Re: Git plugin push notification [message #1061760 is a reply to message #1061745] Mon, 03 June 2013 19:36 Go to previous messageGo to next message
Bob Foster is currently offline Bob FosterFriend
Messages: 74
Registered: January 2013
Member
Obviously a good thing to have. I'll put it on my list near the top. If all goes well, in a couple of days..
Re: Git plugin push notification [message #1062745 is a reply to message #1061760] Mon, 10 June 2013 15:12 Go to previous messageGo to next message
Winston Prakash is currently offline Winston PrakashFriend
Messages: 434
Registered: August 2011
Location: Fremont, CA USA
Senior Member
Eric, could you please file a bug for tracking purpose. Thanks

Winston Prakash
Eclipse Hudson team
Re: Git plugin push notification [message #1062771 is a reply to message #1062745] Mon, 10 June 2013 16:27 Go to previous messageGo to next message
Eric Smith is currently offline Eric SmithFriend
Messages: 2
Registered: June 2013
Junior Member
No problem. https://bugs.eclipse.org/bugs/show_bug.cgi?id=410363
Re: Git plugin push notification [message #1066364 is a reply to message #1062771] Tue, 02 July 2013 10:53 Go to previous messageGo to next message
k z is currently offline k zFriend
Messages: 71
Registered: October 2012
Member
Any progress on this issue? I've noticed that Jenkins implementation does not require authentication even on the secured instance. Could it also apply to SVN plugin?
Re: Git plugin push notification [message #1225613 is a reply to message #1066364] Mon, 30 December 2013 09:43 Go to previous messageGo to next message
Lukasz Jader is currently offline Lukasz JaderFriend
Messages: 35
Registered: October 2013
Member
Since GIT is nowadays widely used this feature/bug seems urgent in my opinion. What are plans for fixing this?
Re: Git plugin push notification [message #1231607 is a reply to message #1225613] Wed, 15 January 2014 03:18 Go to previous messageGo to next message
Winston Prakash is currently offline Winston PrakashFriend
Messages: 434
Registered: August 2011
Location: Fremont, CA USA
Senior Member
Can you please check git plugin version 2.2.5. It is already implemented.

http://wiki.hudson-ci.org/display/HUDSON/Git+Plugin#GitPlugin-PostCommitHook


Winston Prakash
Eclipse Hudson team
Re: Git plugin push notification [message #1232149 is a reply to message #1061745] Thu, 16 January 2014 10:06 Go to previous messageGo to next message
Damian Rzeszot is currently offline Damian RzeszotFriend
Messages: 6
Registered: January 2014
Junior Member
I'm using git plugin 2.2.5 and it need auth

$ curl http:/ /aaa/git/notifyCommit?url=https:/ /bbb/d.rzeszot/test-git-pull.git -v
[...]
> GET /git/notifyCommit?url=https:/ /bbb/d.rzeszot/test-git-pull.git HTTP/1.1
> User-Agent: curl/7.22.0 (x86_64-pc-linux-gnu) libcurl/7.22.0 OpenSSL/1.0.1 zlib/1.2.3.4 libidn/1.23 librtmp/2.3
> Host: aaa
> Accept: */*
>

< HTTP/1.1 403 Forbidden
< Date: Thu, 16 Jan 2014 14:32:25 GMT
< Server: Apache/2.2.20 (Ubuntu)
< Set-Cookie: JSESSIONID=A0D6EB97F3A9BBBB11111D4E3A47E3; Path=/
< Vary: Accept-Encoding
< Content-Length: 563
< Content-Type: text/html;charset=UTF-8

<html><head><meta http-equiv='refresh' content='1;url=/login?from=%2Fgit%2FnotifyCommit'/><script>window.location.replace('/login?from=%2Fgit%2FnotifyCommit');</script></head><body style='background-color:white; color:white;'>Authentication required</body></html>                                                                                                                                                                                                                                                                                                            d


But with auth everything is ok (curl with --user "user:pass").


Perhaps this is the problem:
1) https: //git.eclipse.org/c/hudson/org.eclipse.hudson.core.git/tree/hudson-core/src/main/java/hudson/model/Hudson.java#n3751
2) UnprotectedRootAction => https: //github.com/hudson3-plugins/git-plugin/blob/master/src/main/java/hudson/plugins/git/GitStatus.java#L37

[Updated on: Thu, 16 January 2014 14:52]

Report message to a moderator

Re: Git plugin push notification [message #1232301 is a reply to message #1232149] Thu, 16 January 2014 16:29 Go to previous messageGo to next message
Winston Prakash is currently offline Winston PrakashFriend
Messages: 434
Registered: August 2011
Location: Fremont, CA USA
Senior Member
Thanks for the sleuthing. I will take a look at it.

Winston Prakash
Eclipse Hudson team
Re: Git plugin push notification [message #1232380 is a reply to message #1232301] Thu, 16 January 2014 20:24 Go to previous messageGo to next message
Winston Prakash is currently offline Winston PrakashFriend
Messages: 434
Registered: August 2011
Location: Fremont, CA USA
Senior Member
Hmm.. I just tested. It does work for me, even with security enabled.
One issue, I see was even though I specified a specific git URL,
the polling happens on all jobs for which SCM polling is specified.
This needs a fix


wjprakash@seaview:~$ curl http://ci.hudson-ci.org/git/notifyCommit?url=https://github.com/wjprakash/hudson-test.git
Scheduled polling of core.hudson_core
Scheduled polling of core.stapler_core
Scheduled polling of core.test-harness_core
Scheduled polling of plugins.birt-chart-plugin_hr
Scheduled polling of plugins.clover-plugin_hr
Scheduled polling of plugins.cobertura-plugin_hr
Scheduled polling of plugins.collabnet-plugin_hr
Scheduled polling of plugins.console-column-plugin_hr
Scheduled polling of plugins.copyartifact-plugin_hr
Scheduled polling of plugins.crowd2-plugin_hr
Scheduled polling of plugins.cvs-plugin_hr
Scheduled polling of plugins.dashboard-view-plugin_hr
Scheduled polling of plugins.deploy-plugin_hr
Scheduled polling of plugins.disk-usage-plugin_hr
Scheduled polling of plugins.extreme-feedback-panel-plugin_hr
Scheduled polling of plugins.git-plugin_hr
Scheduled polling of plugins.groovy-support-plugin_hr
Scheduled polling of plugins.gwt-plugin_hr
Scheduled polling of plugins.jaxb-plugin_hr
Scheduled polling of plugins.jcaptcha-plugin_hr
Scheduled polling of plugins.jdepend-plugin_hr
Scheduled polling of plugins.jfreechart-plugin_hr
Scheduled polling of plugins.jna-native-plugin_hr
Scheduled polling of plugins.legacy-maven-plugin_hr
Scheduled polling of plugins.math-lib
Scheduled polling of plugins.maven-hpi-plugin_core
Scheduled polling of plugins.maven3-plugin_hr
Scheduled polling of plugins.multiline-tabbar-plugin_hr
Scheduled polling of plugins.plot-plugin_hr
Scheduled polling of plugins.rest-plugin_hr
Scheduled polling of plugins.ssh-slaves-plugin_hr
Scheduled polling of plugins.Subversion Plugin
Scheduled polling of plugins.windows-azure-storage-plugin-hr
Scheduled polling of plugins.windows-slaves-plugin_hr
Scheduled polling of Test.simple-test


Winston Prakash
Eclipse Hudson team

[Updated on: Thu, 16 January 2014 20:25]

Report message to a moderator

Re: Git plugin push notification [message #1232587 is a reply to message #1061745] Fri, 17 January 2014 09:28 Go to previous messageGo to next message
Damian Rzeszot is currently offline Damian RzeszotFriend
Messages: 6
Registered: January 2014
Junior Member
User Anonymous has no rights. This is our user case.

Maybe that is the reason why it don't works.
Can you tak a look at it?

[Updated on: Fri, 17 January 2014 11:22]

Report message to a moderator

Re: Git plugin push notification [message #1232744 is a reply to message #1232587] Fri, 17 January 2014 16:09 Go to previous messageGo to next message
Winston Prakash is currently offline Winston PrakashFriend
Messages: 434
Registered: August 2011
Location: Fremont, CA USA
Senior Member
Damian, actually I tested with that scenario in mind. The authorization scheme is team management.
If you go to http://ci.hudson-ci.org and click on the "Tests" tab, you don't see any jobs (unless logged in as a user
who has authorized to view those jobs). This is because, Anonymous has no rights to read those jobs.
However, from command line I tried "push notify" one of the jobs in that team (Test.simple-test).
You can see in the above list "Scheduled polling of Test.simple-test"


Winston Prakash
Eclipse Hudson team
Re: Git plugin push notification [message #1234100 is a reply to message #1232744] Tue, 21 January 2014 08:36 Go to previous messageGo to next message
Damian Rzeszot is currently offline Damian RzeszotFriend
Messages: 6
Registered: January 2014
Junior Member
I have Active Directory and Role-Based Strategy. Do you see any solution?
Re: Git plugin push notification [message #1250674 is a reply to message #1232380] Wed, 19 February 2014 13:26 Go to previous messageGo to next message
Damian Rzeszot is currently offline Damian RzeszotFriend
Messages: 6
Registered: January 2014
Junior Member
Has 'polling all jobs' been fixed? We need to have this as soon as possible.

[Updated on: Thu, 20 February 2014 09:49]

Report message to a moderator

icon14.gif  Re: Git plugin push notification [message #1282547 is a reply to message #1232380] Wed, 02 April 2014 13:17 Go to previous messageGo to next message
Lukasz Jader is currently offline Lukasz JaderFriend
Messages: 35
Registered: October 2013
Member
Hi, I've fixed issue with triggering polling for all jobs from onNotifyCommit when using push notification - Pull Request:
https://github.com/hudson3-plugins/git-plugin/pull/6
Re: Git plugin push notification [message #1282720 is a reply to message #1282547] Wed, 02 April 2014 18:06 Go to previous messageGo to next message
Winston Prakash is currently offline Winston PrakashFriend
Messages: 434
Registered: August 2011
Location: Fremont, CA USA
Senior Member
Hi Lukasz, thanks for the patch. I merged the pull request

Winston Prakash
Eclipse Hudson team
Re: Git plugin push notification [message #1295839 is a reply to message #1282720] Mon, 14 April 2014 16:23 Go to previous messageGo to next message
Geoff Waymark is currently offline Geoff WaymarkFriend
Messages: 26
Registered: July 2012
Junior Member
Cross posting from -> http://www.eclipse.org/forums/index.php/m/1295817

Hi Lukasz,

I've been testing the new plugin and while most cases are fixed, I've found that a cascaded job with a different git URL will still be triggered if the job it cascaded from has a git URL matching the post-commit hook trigger. Winston is going to take a look and see if it's an easy fix and then we should be ready to go quite quickly after that.

Thanks,
Geoff


Geoff Waymark
Eclipse Hudson team
Re: Git plugin push notification [message #1297032 is a reply to message #1295839] Tue, 15 April 2014 11:19 Go to previous messageGo to next message
Geoff Waymark is currently offline Geoff WaymarkFriend
Messages: 26
Registered: July 2012
Junior Member
The git-plugin will be released later today by Winston.

Further details in this post =>
http://www.eclipse.org/forums/index.php/m/1297031/#msg_1297031


Geoff Waymark
Eclipse Hudson team
Re: Git plugin push notification [message #1298181 is a reply to message #1297032] Wed, 16 April 2014 05:10 Go to previous message
Winston Prakash is currently offline Winston PrakashFriend
Messages: 434
Registered: August 2011
Location: Fremont, CA USA
Senior Member
Git plugin version 2.2.6 is now available in the update center

Winston Prakash
Eclipse Hudson team
Previous Topic:Problems : Unable to read .../hudson/hudson_home/hudson-security.xml
Next Topic:Accept pull request which adds option to ignore notifications from post-commit hooks in git-plugin
Goto Forum:
  


Current Time: Thu Nov 27 04:42:46 GMT 2014

Powered by FUDForum. Page generated in 0.02654 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software