Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Eclipse 4 » IEditorPart loses custom icon on detach/move(After moving an Eclipse 3.x style editor to another stack or detach it, its icon moves to the default)
icon5.gif  IEditorPart loses custom icon on detach/move [message #1045007] Fri, 19 April 2013 12:27 Go to next message
Norman Schoene is currently offline Norman Schoene
Messages: 5
Registered: April 2013
Junior Member
Hi,

we recently moved our application to Eclipse 4.2.2 to make use of the "detachable editors" feature (mainly for that).

Now I am facing the problem, that old Eclipse 3.x style editors implementing "IEditorPart" (we don't have any that use Injection) are losing their title icon when moved (i.e. detached or even just to another tab group).
If the editors have a default icon set via the extension defintion in the plugin.xml, they switch to that, otherwise they do not show any icon anymore.

Problem is that we are using the same editor for different contributor plug-ins, but they can specify the icons to show. The icon is set using "setTitleImage" in the editor's init() call.

I checked whether the active icon is disposed or something, but its not and I also tried overriding "getDefaultImage" / "getTitleImage" and things like that, but these never even get called on moving the editor window.

Since the issue is so "visible" it really gives a bad impression to the users.

Any ideas? I also could not find a known bug for this issue.

Thanks,
Norman

Re: IEditorPart loses custom icon on detach/move [message #1045417 is a reply to message #1045007] Sat, 20 April 2013 03:49 Go to previous messageGo to next message
Thomas Schindl is currently offline Thomas Schindl
Messages: 5005
Registered: July 2009
Senior Member
This sounds like a bug, when the editor is moved new CTabItem is created
for it and it sounds like the renderer is always using the default icon
(stored in the workbench.xmi).

Tom

On 19.04.13 18:53, Norman Schoene wrote:
> Hi,
>
> we recently moved our application to Eclipse 4.2.2 to make use of the
> "detachable editors" feature (mainly for that).
>
> Now I am facing the problem, that old Eclipse 3.x style editors
> implementing "IEditorPart" (we don't have any that use Injection) are
> losing their title icon when moved (i.e. detached or even just to
> another tab group).
> If the editors have a default icon set via the extension defintion in
> the plugin.xml, they switch to that, otherwise they do not show any icon
> anymore.
>
> Problem is that we are using the same editor for different contributor
> plug-ins, but they can specify the icons to show. The icon is set using
> "setTitleImage" in the editor's init() call.
>
> I checked whether the active icon is disposed or something, but its not
> and I also tried overriding "getDefaultImage" / "getTitleImage" and
> things like that, but these never even get called on moving the editor
> window.
> Since the issue is so "visible" it really gives a bad impression to the
> users.
>
> Any ideas? I also could not find a known bug for this issue.
>
> Thanks,
> Norman
>
>
Re: IEditorPart loses custom icon on detach/move [message #1050134 is a reply to message #1045007] Fri, 26 April 2013 15:05 Go to previous messageGo to next message
Norman Schoene is currently offline Norman Schoene
Messages: 5
Registered: April 2013
Junior Member
Thanks for the reply.

do you know if it is possible to change / set / enhance the renderer used to get around this?

Norman
Re: IEditorPart loses custom icon on detach/move [message #1064140 is a reply to message #1050134] Mon, 17 June 2013 14:51 Go to previous messageGo to next message
Eric Moffatt is currently offline Eric Moffatt
Messages: 105
Registered: July 2009
Senior Member
Norman, please open a Bugzilla for this (I haven't seen one yet and this *is* a defect).
Re: IEditorPart loses custom icon on detach/move [message #1064173 is a reply to message #1064140] Tue, 18 June 2013 01:37 Go to previous messageGo to next message
Norman Schoene is currently offline Norman Schoene
Messages: 5
Registered: April 2013
Junior Member
Created: Bug 410973
Re: IEditorPart loses custom icon on detach/move [message #1064882 is a reply to message #1064173] Fri, 21 June 2013 10:05 Go to previous message
Eric Moffatt is currently offline Eric Moffatt
Messages: 105
Registered: July 2009
Senior Member
Thanks, I've added a few comments on the defect...
Previous Topic:Invalid Thread Access on EclipseContext.dispose()
Next Topic:org.eclipse.ui.forms
Goto Forum:
  


Current Time: Thu Apr 17 00:09:55 EDT 2014

Powered by FUDForum. Page generated in 0.01613 seconds