Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Modeling » Compare » org.eclipse.emf.compare.edit might be in the wrong feature
org.eclipse.emf.compare.edit might be in the wrong feature [message #1031563] Mon, 01 April 2013 19:43 Go to next message
Lothar Werzinger is currently offline Lothar Werzinger
Messages: 148
Registered: July 2009
Location: Bay Area
Senior Member
Keplers M6 EMF Compare has the org.eclipse.emf.compare.edit plugin contained in the org.eclipse.emf.compare.ide.ui feature.

As EMF edit is a non UI API I think org.eclipse.emf.compare.edit should be contained in the org.eclipse.emf.compare feature instead.
Re: org.eclipse.emf.compare.edit might be in the wrong feature [message #1032607 is a reply to message #1031563] Wed, 03 April 2013 03:47 Go to previous messageGo to next message
Laurent Goubet is currently offline Laurent Goubet
Messages: 1609
Registered: July 2009
Senior Member
Hi,

The "org.eclipse.emf.compare" feature is the minimal core of EMF Compare, which doesn't even depend on Eclipse (see the wiki for the dependencies of this core). edit does not have its place there. We made the choice of not having an "ide" feature containing the edit but not the ui in order not to have too many features (we already have a handful).

"org.eclipse.emf.compare.edit" is provided by the "org.eclipse.emf.compare.rcp.ui" feature if you wish to have fewer dependencies... though that still depends on some UI things.

If you need to have the core of EMF Compare along with its edit support, but without any UI dependencies... we're short one feature. You could depend directly on the o.e.e.c.edit plugin though: p2 will be able to take only that plugin instead of the whole ui feature when installing your product if you do so.

Laurent Goubet
Obeo
Re: org.eclipse.emf.compare.edit might be in the wrong feature [message #1032613 is a reply to message #1032607] Wed, 03 April 2013 03:56 Go to previous messageGo to next message
Lothar Werzinger is currently offline Lothar Werzinger
Messages: 148
Registered: July 2009
Location: Bay Area
Senior Member
Quote:

The "org.eclipse.emf.compare" feature is the minimal core of EMF Compare, which doesn't even depend on Eclipse (see the wiki for the dependencies of this core).


Given that a feature only has meaning for eclipse / p2 (and not for plain Java or OSGi like Felix) this reasoning is a bit strange, but I'll accept it as is.

I still think there are use cases for using EMF Compare where regular UI plugins won't work (like RAP or command line tools), but I also understand your desire to minimize the number of features.

Thanks for the explanation.
Re: org.eclipse.emf.compare.edit might be in the wrong feature [message #1032838 is a reply to message #1032613] Wed, 03 April 2013 09:55 Go to previous message
Laurent Goubet is currently offline Laurent Goubet
Messages: 1609
Registered: July 2009
Senior Member
The fact that "core" does not depend on eclipse was not the main point, I was only mentionning it Wink. The core is what users (and we do ourselves) can depend on if they only need to programmatically compare models (within unit tests for example).

The real issue is that "edit" really lives in another "world"... it does not really belong in ide.ui, nor does it belong in the core. The missing feature(s) are o.e.e.c.ide and o.e.e.c.rcp... it would not cost much to add them to our repository, but that does little more than multiplying the available options and confusing the end-users. Many users won't even realize the difference between our "rcp" and "ide" plugins, nor do they care about "SDK" ones...

Could you raise an enhancement request about this? It might be interesting to look at how we could categorize further or provide additional features while still "hiding" them in some way (no category for example).

Laurent Goubet
Obeo
Previous Topic:Ignoring Elements completely in custom Match and Diff Engine
Next Topic:Guava 11?
Goto Forum:
  


Current Time: Thu Apr 17 23:40:11 EDT 2014

Powered by FUDForum. Page generated in 0.01607 seconds