|Re: Regression in URI parsing? [message #1020900 is a reply to message #1020856]
||Tue, 19 March 2013 06:25
| Ed Merks
Registered: July 2009
As I commented in the bug, I think the whole this is questionable at
best. Firstly, unless the entire string is hard coded, it's
questionable to call
URI.createPlatformResourceURI(<workspace-relative-path>, false) because
you can't know if the path contains characters that need to be encoded.
It's also questionable whether fragments and queries are part of the
concept of a workspace relative path in the first place. If the problem
is indeed restricted to "questionably written" test cases, I think it's
better to change them in favor of an API that behaves consistently with
its description and consistently with respect to encode being true or
On 19/03/2013 4:39 AM, Christian W. Damus wrote:
> In fact, it was easy to work around in my case simply by changing the
> test code to parse the resource URI and then ask the URI to append a
> fragment ... several times in a few different test classes.
> This is not bug 403547. The fragments are UUIDs, not paths. There are
> no GenModels.
> I think it is a valid request of the URI class to parse a string that
> includes a fragment. Such a string is a URI. I would expect other
> code already in production to break when upgrading EMF. Accordingly, I
> have raised bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=403708 .
Powered by FUDForum
. Page generated in 0.04272 seconds