Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Subversive » [RESOLVED] Empty "Post-commit hook failure notification" dialog is always raised
[RESOLVED] Empty "Post-commit hook failure notification" dialog is always raised [message #1016504] Wed, 06 March 2013 17:04 Go to next message
Guillaume P. is currently offline Guillaume P.Friend
Messages: 69
Registered: June 2010
Location: Toulouse, France
Member
I just updated subversive to 1.0.1 (org.eclipse.team.svn.ui_1.0.1.I20130301-1700), and I have now a warning message dialog "Post-commit hook failure notification" opened without any text inside after each commit.

After a quick look to the code, it seems to be a bug in the code of subversive. In the class ShowPostCommitErrorsOperation, there is the following check before opening the message dialog:

protected void runImpl(IProgressMonitor monitor) throws Exception {
      SVNPostCommitError []errors = this.provider.getPostCommitErrors();
      if (errors != null) {
            ... (display error message)
      }
}


But, lokking a operation providing postCommitErrors, they always initialize the error array at the beginning, and then fill it if needed. So the above check always get an array (empty in there is no problem) instead of null, and so always displays the error message...

[Updated on: Wed, 13 March 2013 09:08]

Report message to a moderator

Re: Empty "Post-commit hook failure notification" dialog is always raised [message #1016514 is a reply to message #1016504] Wed, 06 March 2013 17:54 Go to previous messageGo to next message
Guillaume P. is currently offline Guillaume P.Friend
Messages: 69
Registered: June 2010
Location: Toulouse, France
Member
Sorry, I posted the wrong piece of code. I changed it into the initial post.
Re: Empty "Post-commit hook failure notification" dialog is always raised [message #1016755 is a reply to message #1016514] Thu, 07 March 2013 15:22 Go to previous messageGo to next message
Konrad Windszus is currently offline Konrad WindszusFriend
Messages: 6
Registered: July 2009
Junior Member
https://bugs.eclipse.org/bugs/show_bug.cgi?id=402491. It is already fixed in the latest update.
Re: Empty "Post-commit hook failure notification" dialog is always raised [message #1018149 is a reply to message #1016755] Wed, 13 March 2013 09:08 Go to previous message
Guillaume P. is currently offline Guillaume P.Friend
Messages: 69
Registered: June 2010
Location: Toulouse, France
Member
Great !
Previous Topic:Eclipse Subversive, one commit, multiple revision numbers?
Next Topic:{root_prefix} label decorator does not work in Juno, worked in indigo
Goto Forum:
  


Current Time: Sun Dec 21 20:07:43 GMT 2014

Powered by FUDForum. Page generated in 0.08239 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software