Eclipse Community Forums: Java Development Tools (JDT) » Equals/HashCode Generator sorting fields

Home » Language IDEs » Java Development Tools (JDT) » Equals/HashCode Generator sorting fields(first check primitive fiels to have early-out)

Show: Today's Messages :: Show Polls :: Message Navigator

Equals/HashCode Generator sorting fields [message #959255]

Fri, 26 October 2012 11:18

Andre Albert
Messages: 25
Registered: July 2009

Junior Member

When running the eclipse Hash/Equals Generator, it looks like the relevant fields are sorted alphabetically in the code.
I guess that it would be nicer when the code first checks primitive types (java.lang) then complex types, and then arrays (or Iterables - if possible).
This might help to avoid deep tree traversals when first checking an equal complex field type before checking the (for example) name field value of the object that does not match.

This might help improving the performance for applications with a lot of "contains"-operations and big tree-like objects

Report message to a moderator

Re: Equals/HashCode Generator sorting fields [message #961761 is a reply to message #959255]

Sun, 28 October 2012 11:24

Stephan Herrmann
Messages: 779
Registered: July 2009

Senior Member

Andre Albert wrote on Fri, 26 October 2012 17:18

I guess that it would be nicer [...]
This might help to avoid deep tree traversals when first checking an equal complex field type before checking the (for example) name field value of the object that does not match.

This might help improving the performance for applications with a lot of "contains"-operations and big tree-like objects

Do you have any performance figures backing this claim? Otherwise it sounds a bit like speculative optimization, s.t. JDT should not get involved with, IMO.

Think of it this way: what are the odds that a big tree-like object structure is infact equal while a direct field (like "name") differs? If all criteria must be fulfilled for "equals", do you know which comparisons are more likely to allow an early "return false"?

best,
Stephan

Report message to a moderator

Previous Topic:	How to find out how is Tomcat started in Eclipse?
Next Topic:	Weird Java editor behaviour

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Mon May 20 03:08:32 EDT 2013