Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Modeling » Epsilon » EVL validation fixes are not usable when having multiple EVL files(the not-so-old fixes are removed)
EVL validation fixes are not usable when having multiple EVL files [message #891875] Tue, 26 June 2012 07:58 Go to next message
Maarten Bezemer is currently offline Maarten Bezemer
Messages: 109
Registered: February 2012
Senior Member
Hi all,

I am taking another look at the EVL validation fixes and am having another problem.
I use multiple EVL files for validation (generally grouped by object type to prevent a big and messy evl file). My problem is that the EvlValidator#validate() removes the old fixes before validating using:
EvlMarkerResolutionGenerator.INSTANCE.removeFixesFor(eObject);


This results in not so old fixes getting removed as well due to the multiple EVL files. Say if the 'first' EVL file found a problem for which a fix is available it gets registered. After that the 'second' EVL file is used for validation and the fix of the 'first' EVL file is removed already...

Is this a known problem, or should I open a new bug report?

First I have to fix some other things, but after that I am willing to take a look at it and provide a patch (if it indeed is a bug and not my error).
For example, the EVLFixInstance class could be extended by storing the EVL URI, so when remove fixes only the ones for a specific URI are included.

Note: The EVLFixInstance class is not in org.eclipse.epsilon.evl.emf.validation (but in org.eclipse.epsilon.evl) I would expect it to be present in the former plugin as it is a validation related class?
Re: EVL validation fixes are not usable when having multiple EVL files [message #891959 is a reply to message #891875] Tue, 26 June 2012 12:11 Go to previous messageGo to next message
Steffen Zschaler is currently offline Steffen Zschaler
Messages: 228
Registered: July 2009
Senior Member
Could you not import all of your EVL files from one central EVL file and
use that instead to run only a single round of validation?

Best,

Steffen

On 26/06/2012 12:58, Maarten Bezemer wrote:
> Hi all,
>
> I am taking another look at the EVL validation fixes and am having
> another problem.
> I use multiple EVL files for validation (generally grouped by object
> type to prevent a big and messy evl file). My problem is that the
> EvlValidator#validate() removes the old fixes before validating using:
>
> EvlMarkerResolutionGenerator.INSTANCE.removeFixesFor(eObject);
>
>
> This results in not so old fixes getting removed as well due to the
> multiple EVL files. Say if the 'first' EVL file found a problem for
> which a fix is available it gets registered. After that the 'second'
> EVL file is used for validation and the fix of the 'first' EVL file is
> removed already...
>
> Is this a known problem, or should I open a new bug report?
>
> First I have to fix some other things, but after that I am willing to
> take a look at it and provide a patch (if it indeed is a bug and not
> my error).
> For example, the EVLFixInstance class could be extended by storing the
> EVL URI, so when remove fixes only the ones for a specific URI are
> included.
>
> Note: The EVLFixInstance class is not in
> org.eclipse.epsilon.evl.emf.validation (but in
> org.eclipse.epsilon.evl) I would expect it to be present in the former
> plugin as it is a validation related class?
Re: EVL validation fixes are not usable when having multiple EVL files [message #892134 is a reply to message #891959] Wed, 27 June 2012 03:47 Go to previous messageGo to next message
Maarten Bezemer is currently offline Maarten Bezemer
Messages: 109
Registered: February 2012
Senior Member
Yes, that would be possible as work-around.
As I have made quite a few changes in the EVL validation already, I applied a 'hack' to make it usable for my current situation before I (or someone else) have time to properly fix it
Re: EVL validation fixes are not usable when having multiple EVL files [message #892151 is a reply to message #892134] Wed, 27 June 2012 04:48 Go to previous message
Maarten Bezemer is currently offline Maarten Bezemer
Messages: 109
Registered: February 2012
Senior Member
Oops I started a thread on this subject before (lots of things on my head, it must have been slipped my mind).
Previous Topic:EGL/EOL java code
Next Topic:Global Variables in imported EOL
Goto Forum:
  


Current Time: Mon Jul 28 08:31:50 EDT 2014

Powered by FUDForum. Page generated in 0.09483 seconds