Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Mylyn » Push a patch for approval?(Using Gerrit...)
Push a patch for approval? [message #875991] Wed, 23 May 2012 13:38 Go to next message
Jeremie Bresson is currently offline Jeremie Bresson
Messages: 117
Registered: November 2010
Senior Member
I am trying to work on bug 379783 (as casual individual contributor). It is on WikiText, but I understood the workflow is the same for all Mylyn projects.

I am very new to these modern technologies (git, gerrit, mylyn, ...). I am trying to use the contributor reference, but I did not understood everything.

I published a first patch on bugzilla.
David Green pushed it as a first review on gerrit: https://git.eclipse.org/r/#change,6020

We both agreed that my patch also needed a "loop detection" in the mediawiki template resolution.

I published a second patch... I assumed after some times, that I might had to pushed it myself on the gerrit server.

Therefore I made a checkout as proposed by gerrit:
git fetch git://git.eclipse.org/gitroot/mylyn/org.eclipse.mylyn.docs refs/changes/20/6020/1 && git checkout FETCH_HEAD


I applied my patch and commit it in my local repository (new commit, not as git amend)
Now I have this:

index.php/fa/9894/0/

I have tried:
git push gerrit
fatal: 'gerrit' does not appear to be a git repository


but I need to define gerrit as remote repository (I did not do this, because I do not know how).

Some other questions:
- I am not a project commiter. Do I have right to push someting on gerrit ?
- How do I push a second change on gerrit, so that the change appears at the same place (in order to have a single point of discussion on gerrit) ?

NB: I am not sure that the section 4.8 Reviews is up to date... The gerrit instance http://review.mylyn.org/ is not used any longer, isn't it?

Re: Push a patch for approval? [message #876253 is a reply to message #875991] Thu, 24 May 2012 04:36 Go to previous messageGo to next message
Jeremie Bresson is currently offline Jeremie Bresson
Messages: 117
Registered: November 2010
Senior Member
I just found here some inputs: http://wiki.eclipse.org/Gerrit

* I needed to "Confirm you agree" (Individual Contributor)
* I found my username on the page "jbresson"
* I found that the project is "mylyn/org.eclipse.mylyn.docs"

I tried:
git push ssh://jbresson@git.eclipse.org:29418/mylyn/org.eclipse.mylyn.docs.git HEAD:refs/changes/20/6020/1


Got this back:
Counting objects: 38, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (11/11), done.
Writing objects: 100% (22/22), 2.31 KiB, done.
Total 22 (delta 6), reused 0 (delta 0)
remote: Resolving deltas:   0% (0/6)
To ssh://jbresson@git.eclipse.org:29418/mylyn/org.eclipse.mylyn.docs.git
 ! [remote rejected] HEAD -> refs/changes/20/6020/1 (prohibited by Gerrit)
error: failed to push some refs to 'ssh://jbresson@git.eclipse.org:29418/mylyn/org.eclipse.mylyn.docs.git'

[Updated on: Thu, 24 May 2012 05:31]

Report message to a moderator

Re: Push a patch for approval? [message #876293 is a reply to message #876253] Thu, 24 May 2012 06:21 Go to previous message
Jeremie Bresson is currently offline Jeremie Bresson
Messages: 117
Registered: November 2010
Senior Member
Gerrit has a nice documentation.

Uploading content:
Gerrit Code Review - Uploading Changes
git push ssh://jbresson@git.eclipse.org:29418/mylyn/org.eclipse.mylyn.docs.git HEAD:refs/for/master


Publishing a second patch to a open changed requires a change id line (as the last line of the commit message):
Gerrit Code Review - Change-Ids

If you are a git newbie like me you might get some error message. For this you get some help too:
* squash commits first
* missing Change-Id in commit message
Previous Topic:WikiText to MediaWiki Connector?
Next Topic:Review for Eclipse (R4E) 0.10.0 is now available
Goto Forum:
  


Current Time: Thu Jul 31 05:31:20 EDT 2014

Powered by FUDForum. Page generated in 0.03437 seconds