Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Dali » Preselected JPA Platform and Implementation on JPA Facet page?
Preselected JPA Platform and Implementation on JPA Facet page? [message #817067] Fri, 09 March 2012 15:43 Go to next message
Kenneth Cheung is currently offline Kenneth CheungFriend
Messages: 9
Registered: July 2009
Junior Member
Hi,

What is the logic for the Preselected JPA Platform and Implementation on JPA Facet page?

We get our own "default" JPA Platform preselected on Eclipse 3.6 and 3.7 but the "Generic 2.0" on 4.2. We are not sure if it is random or deterministic.

Also for JPA Implementation it seems that if runtime target is selected it would be Library Provided by Target Runtime, otherwise it would be Disable Library Configuration. It is very logical. However it seems that the next time the wizard is lauched the previous JPA Platform and Implementation gets preselected regardless of the runtime. The last setting is stored in <workspace>\.metadata\plugins\.plugins\org.eclipse.wst.common.project.facet.core\prefs.xml

Do we get the existing logic correct? If so it seems a bit unconventional. If a user create a JPA project without target runtime then one with a runtime, he may unknowingly have the project with Diable Library Configuration and missing the runtime library.

Thanks.
Re: Preselected JPA Platform and Implementation on JPA Facet page? [message #817099 is a reply to message #817067] Fri, 09 March 2012 16:31 Go to previous messageGo to next message
Paul Fullbright is currently offline Paul FullbrightFriend
Messages: 200
Registered: July 2009
Senior Member
Is this all with a clean workspace? I don't believe the logic has changed. There may however be interactions with user preferences. If a user has made a selection before, and that selection is available, it is preselected.

As far as runtime library configuration, we find that many users do not use a runtime-provided JPA implementation. Many use either a user library or plugins for their library configuration. At any rate, the same logic applies. If an available selection was chosen the last time, it is preselected.
Re: Preselected JPA Platform and Implementation on JPA Facet page? [message #817217 is a reply to message #817099] Fri, 09 March 2012 20:10 Go to previous messageGo to next message
Kenneth Cheung is currently offline Kenneth CheungFriend
Messages: 9
Registered: July 2009
Junior Member
Thanks for confirming it is preselecing the previous JPA Platform and Implementation

In a clean workspace though, "Generic 2.0" is preselected even we have "default" platforms defined like:
<extension point="org.eclipse.jpt.jpa.core.jpaPlatforms">
<jpaPlatform
id="myPlatform"
label="%MyPlatformLabel1_0"
default="true"
factoryClass="org.eclipse.jpt.jpa.core.internal.GenericJpaPlatformFactory"
jpaFacetVersion="1.0">
</jpaPlatform>

<jpaPlatform
id="myPlatform_jpa2_0"
label="%MyPlatformLabel2_0"
default="true"
factoryClass="org.eclipse.jpt.jpa.core.internal.jpa2.Generic2_0JpaPlatformFactory"
jpaFacetVersion="2.0">
</jpaPlatform>
</extension>

In Eclipse 3.7 and below our default platform is preselected. Is "default" still honoured in Juno? Thanks again.
Re: Preselected JPA Platform and Implementation on JPA Facet page? [message #819179 is a reply to message #817217] Mon, 12 March 2012 15:39 Go to previous messageGo to next message
Paul Fullbright is currently offline Paul FullbrightFriend
Messages: 200
Registered: July 2009
Senior Member
OK, I'm seeing a problem with initializing runtime preferences (which is where default platform settings are applied). I'll investigate and update with a bug or whatever other information is applicable.
Re: Preselected JPA Platform and Implementation on JPA Facet page? [message #819240 is a reply to message #819179] Mon, 12 March 2012 17:06 Go to previous messageGo to next message
Paul Fullbright is currently offline Paul FullbrightFriend
Messages: 200
Registered: July 2009
Senior Member
https://bugs.eclipse.org/bugs/show_bug.cgi?id=373990

Bug logged. Fix in testing. I'm really surprised this wasn't noticed before now.

Re: Preselected JPA Platform and Implementation on JPA Facet page? [message #819281 is a reply to message #819240] Mon, 12 March 2012 18:04 Go to previous messageGo to next message
Paul Fullbright is currently offline Paul FullbrightFriend
Messages: 200
Registered: July 2009
Senior Member
Are you guys *sure* you're not getting this behavior in 3.7? In a clean workspace?
Re: Preselected JPA Platform and Implementation on JPA Facet page? [message #819325 is a reply to message #819281] Mon, 12 March 2012 19:30 Go to previous messageGo to next message
Kenneth Cheung is currently offline Kenneth CheungFriend
Messages: 9
Registered: July 2009
Junior Member
No I lied. It must have been on 3.6.2. Thanks for confirming the defect.
Re: Preselected JPA Platform and Implementation on JPA Facet page? [message #821563 is a reply to message #819325] Thu, 15 March 2012 14:25 Go to previous message
Paul Fullbright is currently offline Paul FullbrightFriend
Messages: 200
Registered: July 2009
Senior Member
Fix committed for 3.0 stream and in head.
Previous Topic:Generate tables from entities stop to work after convert JPA into a OSGi project
Next Topic:Configure Default on New JPA Project Wizard
Goto Forum:
  


Current Time: Thu Dec 18 02:41:04 GMT 2014

Powered by FUDForum. Page generated in 0.01829 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software