Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Eclipse 4 » Programmatic Contribution Factories not supported
Programmatic Contribution Factories not supported [message #760907] Mon, 05 December 2011 09:51 Go to next message
Matthias Villiger is currently offline Matthias Villiger
Messages: 77
Registered: September 2011
Member
Hi

I have a question concerning the compatibility layer and menu contribution factories.
In eclipse 3.7 we extended the ExtensionContributionFactory to programmatically contribute CommandContributionItems using the org.eclipse.ui.menus extension point.

As far as I can see this is not yet supported in the compatibility layer of our eclipse version (Build id: 20111110-1543).
When I check org.eclipse.ui.internal.menus.MenuPersistence there is some removed (commented out) code in the readAdditions() method together with a system-out informing that these factories are not supported.

Now to my question:
Is it planned to integrate this feature in a later build?
If yes: what is the plan on that? By when can we expect to make use of menu contribution factories?
If no: what is the alternative to use?

Thanks
Matthias

[Updated on: Mon, 05 December 2011 10:54]

Report message to a moderator

Re: Programmatic Contribution Factories not supported [message #761112 is a reply to message #760907] Mon, 05 December 2011 18:06 Go to previous messageGo to next message
Brian de Alwis is currently offline Brian de Alwis
Messages: 242
Registered: July 2009
Senior Member
One work around might be to provide an MMenuContribution object. It should be straight forward.

Or you could take a stab at implementing it and contributing it back -- it should also be pretty straight forward.

Brian.
Re: Programmatic Contribution Factories not supported [message #762460 is a reply to message #761112] Thu, 08 December 2011 00:38 Go to previous messageGo to next message
Matthias Zimmermann is currently offline Matthias Zimmermann
Messages: 79
Registered: February 2010
Member
Hi Brian

As we from Eclipse Scout are trying hard to maintain backward compatibility with 3.x (all our productive code is there) using MMenuContribution does not seem to be a valid option. So far we were assuming that all public API will be supported by the compatibility layer. This is working great in our case, except for the programmatic contribution factories.

To futher track this issue we opend bug 365903. Many thanks for quickly assigning target milestone M5!

Matthias
Re: Programmatic Contribution Factories not supported [message #762697 is a reply to message #762460] Thu, 08 December 2011 09:21 Go to previous message
Paul Webster is currently offline Paul Webster
Messages: 6859
Registered: July 2009
Location: Ottawa
Senior Member

We will support programmitic contribution factories in 4.2 (and in Eclipse 4 they're done differently, via snippets or ModelProcessors or IEventBroker event handlers).


But I've gotta ask, why are you using them? What functionality do they give you over org.eclipse.ui.menus and something like the compound element (a org.eclipse.ui.actions.CompoundContributionItem) or a org.eclipse.ui.menus.CommandContributionItem and a org.eclipse.ui.commands.IElementUpdater?

PW


Previous Topic:How can I create toolbar icons with labels under them?
Next Topic:How to setup a pure e4 Target Definition
Goto Forum:
  


Current Time: Tue Jul 29 06:59:36 EDT 2014

Powered by FUDForum. Page generated in 0.10339 seconds