Eclipse Community Forums: EGit / JGit » commit gui reformats modified hard-wrapped text badly

Home » Eclipse Projects » EGit / JGit » commit gui reformats modified hard-wrapped text badly(amended commit comment is badly formatted if hard-wrap is enabled)

Show: Today's Messages :: Show Polls :: Message Navigator

commit gui reformats modified hard-wrapped text badly [message #730004]

Tue, 27 September 2011 13:05

R Shapiro

Messages: 386
Registered: June 2011

Senior Member

When the commit message is amended by inserting text, the existing text that gets moved to the next line by the hard wrapper ends up with each word on a line by itself. So if the first two lines of my original message looks like this:

Read manifests and missions files into minimal objects rather than
blah blah blah

and I then insert "some inserted text" after "minimal", I end up with:

Read manifests and missions files into minimal some inserted text
objects
rather
than
blah blah blah

I then have to clean up all these extra line breaks manually, by deleting them one at a time. That doesn't seem right. I think either the reformatter in this case should do the right thing, only adding line breaks where needed, or we need a 'reformat' toolbar item that will hard-wrap all the text after editing is complete.

This problem is specific to hard-wrap -- soft wrapping works more reasonably.

Report message to a moderator

Re: commit gui reformats modified hard-wrapped text badly [message #730126 is a reply to message #730004]

Tue, 27 September 2011 16:47

R Shapiro

Messages: 386
Registered: June 2011

Senior Member

Forgot to mention:

Egit version: 1.2.0.201109261000 (but this issue has been around at least since 1.0, maybe longer)
Platform: Mac OS X 10.7.1

Report message to a moderator

Re: commit gui reformats modified hard-wrapped text badly [message #730375 is a reply to message #730126]

Wed, 28 September 2011 09:29

Matthias Sohn

Messages: 1268
Registered: July 2009

Senior Member

Could you file a bug for this problem ?

Report message to a moderator

Re: commit gui reformats modified hard-wrapped text badly [message #730674 is a reply to message #730126]

Wed, 28 September 2011 20:33

Robin Rosenberg

Messages: 332
Registered: July 2009

Senior Member

R Shapiro skrev 2011-09-27 18.47:
> Forgot to mention:
>
> Egit version: 1.2.0.201109261000 (but this issue has been around at
> least since 1.0, maybe longer)
> Platform: Mac OS X 10.7.1
>

I've been looking into it in order to get something better, based
on the same heuristis as the commit message viewer uses to decide
on whether to reflow a line or not. It seems like it might work,
but I'm still not sure one wants the hard wrap while typing. Maybe it is
better handled as something we do explicitly or when focus is lost, or
(automatically) when starting a new paragraph, or some other criteria.

-- robin

Report message to a moderator

Re: commit gui reformats modified hard-wrapped text badly [message #730675 is a reply to message #730375]

Wed, 28 September 2011 20:36

Robin Rosenberg

Messages: 332
Registered: July 2009

Senior Member

Matthias Sohn skrev 2011-09-28 11.29:
> Could you file a bug for this problem ?

There is one: https://bugs.eclipse.org/bugs/show_bug.cgi?id=356925

-- robin

Report message to a moderator

Re: commit gui reformats modified hard-wrapped text badly [message #731315 is a reply to message #730675]

Fri, 30 September 2011 15:55

R Shapiro

Messages: 386
Registered: June 2011

Senior Member

One simple option might be a 'format' toolbar item that would re-wrap on demand, analogous to the 'Source -> Format' command in editor views.

Report message to a moderator

Re: commit gui reformats modified hard-wrapped text badly [message #731373 is a reply to message #731315]

Fri, 30 September 2011 18:50

prusswan

Messages: 3
Registered: September 2011

Junior Member

What is the intended purpose of hard-wrap anyway? I intend to update my commits a lot on my local branch, so having to backspace my previous commit message while updating it does not make much sense, until I realize there is a setting for it.

Report message to a moderator