Eclipse Community Forums: Eclipse Platform » Odd enablement of menu vs. toolbar

Help

Home

Home » Eclipse Projects » Eclipse Platform » Odd enablement of menu vs. toolbar

Show: Today's Messages :: Show Polls :: Message Navigator

Odd enablement of menu vs. toolbar [message #726898]

Mon, 19 September 2011 20:29

Ric Wright

Messages: 70
Registered: July 2009

Member

I have implemented a menu and a toolbar for an app using the Commands
framework. All works as expected EXCEPT for one odd behaviour that
looks like a bug, but perhaps not. There is a menu entry and toolbar
button both tied to a single command handler. Initially, neither is
enabled. All fine. Then the app changes state and both the menu entry
and the toolbar button should be enabled. However, only the MENU ENTRY
gets enabled. But if I select the menu entry and it works as expected
- including that is then disabled. Then I change the app state again
and now BOTH the menu entry and the toolbar button are enabled. From
then on all works perfectly.

I find this rather baffling. Does this suggest anything to anybody?
Somehow menus and toolbars are initially different?

TIA, Ric

Report message to a moderator

Re: Odd enablement of menu vs. toolbar [message #727244 is a reply to message #726898]

Tue, 20 September 2011 16:57

Ric Wright

Messages: 70
Registered: July 2009

Member

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta http-equiv="Content-Style-Type" content="text/css">
<title></title>
<meta name="Generator" content="Cocoa HTML Writer">
<meta name="CocoaVersion" content="1038.36">
<style type="text/css">
p.p1 {margin: 0.0px 0.0px 0.0px 0.0px; line-height: 15.0px; font: 14.0px Verdana}
p.p2 {margin: 0.0px 0.0px 0.0px 0.0px; line-height: 15.0px; font: 14.0px Verdana; min-height: 17.0px}
p.p3 {margin: 0.0px 0.0px 0.0px 12.0px; line-height: 17.0px; font: 14.0px Verdana; color: #150b91}
p.p4 {margin: 0.0px 0.0px 0.0px 12.0px; line-height: 17.0px; font: 14.0px Verdana; color: #150b91; min-height: 17.0px}
p.p5 {margin: 0.0px 0.0px 0.0px 0.0px; line-height: 17.0px; font: 14.0px Verdana; min-height: 17.0px}
p.p6 {margin: 0.0px 0.0px 0.0px 0.0px; line-height: 17.0px; font: 14.0px Verdana}
p.p7 {margin: 0.0px 0.0px 0.0px 0.0px; font: 13.0px 'Lucida Sans Typewriter'; color: #150b92}
p.p8 {margin: 0.0px 0.0px 0.0px 0.0px; font: 13.0px 'Lucida Sans Typewriter'; color: #0d9103}
p.p9 {margin: 0.0px 0.0px 0.0px 0.0px; font: 13.0px 'Lucida Sans Typewriter'}
span.s1 {color: #000000}
span.s2 {color: #150b92}
span.s3 {color: #0d9103}
span.Apple-tab-span {white-space:pre}
</style>
</head>
<body>
On 2011-09-19 15:29:06 -0500, Ric Wright said:
 
I have implemented a menu and a toolbar for an app using the Commands framework. All works as expected EXCEPT for one odd behaviour that looks like a bug, but perhaps not. There is a menu entry and toolbar button both tied to a single command handler. Initially, neither is enabled. All fine. Then the app changes state and both the menu entry and the toolbar button should be enabled. However, only the MENU ENTRY gets enabled. But if I select the menu entry and it works as expected - including that is then disabled. Then I change the app state again and now BOTH the menu entry and the toolbar button are enabled. From then on all works perfectly.
 
I find this rather baffling. Does this suggest anything to anybody? Somehow menus and toolbars are initially different?
 
TIA, Ric
 
Poked at this a little more. Here's some additional info. The commands are dependent on a variable (the clockstate, which is an enum) and the particular command can be enabled for two states. This is the plugin.xml:
 
 <handler
 class="com.geofx.gms.controller.TerminateSimHandler"
 commandId="com.geofx.gms.commands.TerminateSim">
 <enabledWhen>
 <or>
 <with 
 variable="com.geofx.gms.commands.clockState">
 <equals 
 value="running" >
 </equals>
 </with>
 <with 
 variable="com.geofx.gms.commands.clockState">
 <equals 
 value="paused" >
 </equals>
 </with>
 </or>
 </enabledWhen>
 </handler>
 
and the handler class correctly implements isEnabled and updateEnabled, even calling command.refreshElements(). 
 
The odd thing I have noted last night is that if I comment out the second "with" element above (so the command won't be enabled if the clock is "paused" and do the same in the handler class (i.e. not enabling if it is "paused") then everything works perfectly. Is the code in plugin.xml wrong perhaps? This is my first foray into this command handler area, so it may be pilot error on my part. Still doesn't explain why the menu would be correct and the toolbar not, initially, but... who knows? Not I.
</body>
</html>

Report message to a moderator