Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Technology Project and PMC » Modifying soruce code Vs. Using the extension point
Modifying soruce code Vs. Using the extension point [message #75734] Thu, 27 November 2008 02:13 Go to next message
xingyun is currently offline xingyun
Messages: 27
Registered: July 2009
Location: Bei jing
Junior Member
Hi
My Goal:
Develop a plugin for Eclipse, this plugin has a dependeny on "plugin
X"

My Problem:
Some of features is not provided in the extension points of "plugin
X"

I'm curious:
I can achieve some of my targets via modifying the source code of
"plugin X" and re-publish "plugin X"
I know it's not a good practice

But what're the disadvantages of modifying source code directly?

Thanks

Xing Yun
Re: Modifying soruce code Vs. Using the extension point [message #75750 is a reply to message #75734] Thu, 27 November 2008 03:30 Go to previous messageGo to next message
Wayne Beaton is currently offline Wayne Beaton
Messages: 502
Registered: July 2009
Senior Member
For one, if you modify the code, then you have to distribute it with
your code. You run the risk that your changes might not be compatible
with other plug-in providers. Further, as changes are made to the
original code, you will have to maintain yours.

If you think something needs to be changed, you could consider filing a
bug report to ask for it to be changed/added (you can contribute code
for the change).

Be sure to abide by the EPL if you do decide to change code.

Wayne

xing yun wrote:
> Hi
> My Goal:
> Develop a plugin for Eclipse, this plugin has a dependeny on "plugin
> X"
>
> My Problem:
> Some of features is not provided in the extension points of "plugin
> X"
>
> I'm curious:
> I can achieve some of my targets via modifying the source code of
> "plugin X" and re-publish "plugin X"
> I know it's not a good practice
>
> But what're the disadvantages of modifying source code directly?
>
> Thanks
>
> Xing Yun
>
>
Re: Modifying soruce code Vs. Using the extension point [message #75767 is a reply to message #75750] Thu, 27 November 2008 05:01 Go to previous message
xingyun is currently offline xingyun
Messages: 27
Registered: July 2009
Location: Bei jing
Junior Member
Thaks a lot for the quick reply
:)
Regards
Xing Yun

"Wayne Beaton" <wayne@eclipse.org> wrote in message
news:ggl4aj$v8s$1@build.eclipse.org...
> For one, if you modify the code, then you have to distribute it with your
> code. You run the risk that your changes might not be compatible with
> other plug-in providers. Further, as changes are made to the original
> code, you will have to maintain yours.
>
> If you think something needs to be changed, you could consider filing a
> bug report to ask for it to be changed/added (you can contribute code for
> the change).
>
> Be sure to abide by the EPL if you do decide to change code.
>
> Wayne
>
> xing yun wrote:
>> Hi
>> My Goal:
>> Develop a plugin for Eclipse, this plugin has a dependeny on
>> "plugin X"
>>
>> My Problem:
>> Some of features is not provided in the extension points of
>> "plugin X"
>>
>> I'm curious:
>> I can achieve some of my targets via modifying the source code of
>> "plugin X" and re-publish "plugin X"
>> I know it's not a good practice
>>
>> But what're the disadvantages of modifying source code directly?
>>
>> Thanks
>>
>> Xing Yun
Re: Modifying soruce code Vs. Using the extension point [message #601881 is a reply to message #75734] Thu, 27 November 2008 03:30 Go to previous message
Wayne Beaton is currently offline Wayne Beaton
Messages: 502
Registered: July 2009
Senior Member
For one, if you modify the code, then you have to distribute it with
your code. You run the risk that your changes might not be compatible
with other plug-in providers. Further, as changes are made to the
original code, you will have to maintain yours.

If you think something needs to be changed, you could consider filing a
bug report to ask for it to be changed/added (you can contribute code
for the change).

Be sure to abide by the EPL if you do decide to change code.

Wayne

xing yun wrote:
> Hi
> My Goal:
> Develop a plugin for Eclipse, this plugin has a dependeny on "plugin
> X"
>
> My Problem:
> Some of features is not provided in the extension points of "plugin
> X"
>
> I'm curious:
> I can achieve some of my targets via modifying the source code of
> "plugin X" and re-publish "plugin X"
> I know it's not a good practice
>
> But what're the disadvantages of modifying source code directly?
>
> Thanks
>
> Xing Yun
>
>
Re: Modifying soruce code Vs. Using the extension point [message #601886 is a reply to message #75750] Thu, 27 November 2008 05:01 Go to previous message
xingyun is currently offline xingyun
Messages: 27
Registered: July 2009
Location: Bei jing
Junior Member
Thaks a lot for the quick reply
:)
Regards
Xing Yun

"Wayne Beaton" <wayne@eclipse.org> wrote in message
news:ggl4aj$v8s$1@build.eclipse.org...
> For one, if you modify the code, then you have to distribute it with your
> code. You run the risk that your changes might not be compatible with
> other plug-in providers. Further, as changes are made to the original
> code, you will have to maintain yours.
>
> If you think something needs to be changed, you could consider filing a
> bug report to ask for it to be changed/added (you can contribute code for
> the change).
>
> Be sure to abide by the EPL if you do decide to change code.
>
> Wayne
>
> xing yun wrote:
>> Hi
>> My Goal:
>> Develop a plugin for Eclipse, this plugin has a dependeny on
>> "plugin X"
>>
>> My Problem:
>> Some of features is not provided in the extension points of
>> "plugin X"
>>
>> I'm curious:
>> I can achieve some of my targets via modifying the source code of
>> "plugin X" and re-publish "plugin X"
>> I know it's not a good practice
>>
>> But what're the disadvantages of modifying source code directly?
>>
>> Thanks
>>
>> Xing Yun
Previous Topic:Modifying soruce code Vs. Using the extension point
Next Topic:Error in eclipse Ant Build using ibator
Goto Forum:
  


Current Time: Thu Oct 23 21:21:02 GMT 2014

Powered by FUDForum. Page generated in 0.01693 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software