Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Mylyn » minor annoyance with change method signature refactor
minor annoyance with change method signature refactor [message #6710] Sat, 30 June 2007 22:02 Go to next message
Alen Vrecko is currently offline Alen VreckoFriend
Messages: 10
Registered: July 2009
Junior Member
Hi,

am new to Eclipse newsgroups, hope this is the right place to post.

I find Mylyn a pleasure to work with. It is great that it only shows the
stuff that is relevant.

Cheers for the 2.0 release.

But I noticed a very minor annoyance when using the change method
signature refactor. I am using Mylyn 2.0 (same issue with 1.0) under
Eclipse 2.2.1 and have the following problem:

Let say you open X class for editing (opened Java Editor)
Then you wish to use the change method signature refactor, go over
method (ctrl+shift+C) the dialog pops up. And if you use ctrl+space key
on any of the type fields. Then the Java Editor at the back would get
closed. Surprising this always happens if I am editing an Interface and
rarely if a Java file.

While I rarely use change method signature refactor and didn't want to
mention this but there is nothing more annoying than Mylyn closing the
Java editor I am just using. Maybe if somebody could take a look?

Regards,
Alen
Re: minor annoyance with change method signature refactor [message #6719 is a reply to message #6710] Sun, 01 July 2007 06:03 Go to previous messageGo to next message
Konstantin Scheglov is currently offline Konstantin ScheglovFriend
Messages: 555
Registered: July 2009
Senior Member
Alen Vrecko wrote:

> I find Mylyn a pleasure to work with. It is great that it only shows the
> stuff that is relevant.
>
> Cheers for the 2.0 release.
>
> But I noticed a very minor annoyance when using the change method
> signature refactor. I am using Mylyn 2.0 (same issue with 1.0) under
> Eclipse 2.2.1 and have the following problem:
>
> Let say you open X class for editing (opened Java Editor)
> Then you wish to use the change method signature refactor, go over
> method (ctrl+shift+C) the dialog pops up. And if you use ctrl+space key
> on any of the type fields. Then the Java Editor at the back would get
> closed. Surprising this always happens if I am editing an Interface and
> rarely if a Java file.
>
> While I rarely use change method signature refactor and didn't want to
> mention this but there is nothing more annoying than Mylyn closing the
> Java editor I am just using. Maybe if somebody could take a look?

Same (closing editor) happens when I rename field (may be also method).

I've downloaded RCP package of Eclipse 3.3 mostly for Mylyn. I've
removed XML support from it (because I have already commercial XML
editor that is better). But it seems that Mylyn is still causes problems
as it was several months ago. :-(

I see also that eclipse.exe hangs in memory when I close Eclipse. May
be this is problem of Mylyn, but may be not (I've placed .mylar in
remote folder).


Konstantin Scheglov,
Google, Inc.
Re: minor annoyance with change method signature refactor [message #6725 is a reply to message #6719] Sun, 01 July 2007 20:35 Go to previous messageGo to next message
Konstantin Scheglov is currently offline Konstantin ScheglovFriend
Messages: 555
Registered: July 2009
Senior Member
Konstantin Scheglov wrote:

>> While I rarely use change method signature refactor and didn't want to
>> mention this but there is nothing more annoying than Mylyn closing the
>> Java editor I am just using. Maybe if somebody could take a look?
>
> Same (closing editor) happens when I rename field (may be also method).
>
> I've downloaded RCP package of Eclipse 3.3 mostly for Mylyn. I've
> removed XML support from it (because I have already commercial XML
> editor that is better). But it seems that Mylyn is still causes problems
> as it was several months ago. :-(

Same problem also happens when I use Eclipse code assist to implement
methods in abstract class (Ctrl+Space) here "new Runnable(${cursor})".

>
> I see also that eclipse.exe hangs in memory when I close Eclipse. May
> be this is problem of Mylyn, but may be not (I've placed .mylar in
> remote folder).

OK, this is really not problem with Mylyn.


Konstantin Scheglov,
Google, Inc.
Re: minor annoyance with change method signature refactor [message #6731 is a reply to message #6725] Mon, 02 July 2007 11:43 Go to previous messageGo to next message
Alen Vrecko is currently offline Alen VreckoFriend
Messages: 10
Registered: July 2009
Junior Member
>> I see also that eclipse.exe hangs in memory when I close Eclipse.
>> May be this is problem of Mylyn, but may be not (I've placed .mylar in
>> remote folder).
>
> OK, this is really not problem with Mylyn.

My Eclipse crashed when I clicked on the radio button next to the task
name in task list. That isn't very nice. Most probably I need to
increase the heap size.

Is there a bug filed for ctrl+space problem since I probably don't need
to mention how annoying that is?

And one more thing why is not possible to add a class as landmark? For
example I will be working with SomeDAO.java and SomeBL.java, now I wish
not to wait for Mylyn to pick this up but I want to predefine this, if I
right click on lets say SomeDAO.java and select Add as Landmark I get
"Not a valid landmark" message. How can a Java file not be a landmark?

This is greately reducing my productivity since I would like to
predefine some classes I know I will need(for a particular task) in the
package explorer. Mylyn while smart as it is should listen to my needs
ahead of time and not just in time:)

Is there a bug filed for this?

Cheers,
Alen
Re: minor annoyance with change method signature refactor [message #6744 is a reply to message #6731] Mon, 02 July 2007 12:28 Go to previous messageGo to next message
Stefan Langer is currently offline Stefan LangerFriend
Messages: 236
Registered: July 2009
Senior Member
You need to click on the class and no the file name in the
PackageExplorer. As far as I know this is stated in the documentation
for Mylin.

Regards
Stefan

Alen Vrecko schrieb:
>
>>> I see also that eclipse.exe hangs in memory when I close Eclipse.
>>> May be this is problem of Mylyn, but may be not (I've placed .mylar
>>> in remote folder).
>>
>> OK, this is really not problem with Mylyn.
>
> My Eclipse crashed when I clicked on the radio button next to the task
> name in task list. That isn't very nice. Most probably I need to
> increase the heap size.
>
> Is there a bug filed for ctrl+space problem since I probably don't need
> to mention how annoying that is?
>
> And one more thing why is not possible to add a class as landmark? For
> example I will be working with SomeDAO.java and SomeBL.java, now I wish
> not to wait for Mylyn to pick this up but I want to predefine this, if I
> right click on lets say SomeDAO.java and select Add as Landmark I get
> "Not a valid landmark" message. How can a Java file not be a landmark?
>
> This is greately reducing my productivity since I would like to
> predefine some classes I know I will need(for a particular task) in the
> package explorer. Mylyn while smart as it is should listen to my needs
> ahead of time and not just in time:)
>
> Is there a bug filed for this?
>
> Cheers,
> Alen
Re: minor annoyance with change method signature refactor [message #6751 is a reply to message #6744] Mon, 02 July 2007 13:32 Go to previous messageGo to next message
Alen Vrecko is currently offline Alen VreckoFriend
Messages: 10
Registered: July 2009
Junior Member
> You need to click on the class and no the file name in the
> PackageExplorer. As far as I know this is stated in the documentation
> for Mylin.
>

Sorry to be a bit blunt: That is not very user friendly way, since
normally I would like to select lets say 4 files at once (holding ctrl)
and add them as landmark.

Surprisingly even if I select a class(not a file) I get "Not a valid
landmark" message but if I select a method within the class then it is a
valid landmark.

IMHO: Landmarking needs some refinement. While I think it is sufficient
if you are doing (minor) bug fixes it breaks down if for example you are
doing some more substantial refactoring or adding some functionality to
existing code.

I know there is (Ctrl + Shift + R (Quick open)) but I would fell much
more at ease if all the files that are revelant to me are displayed in
the package explorer(that would still reduce quite a load of files).

Cheers,
Alen
Re: minor annoyance with change method signature refactor [message #6787 is a reply to message #6725] Wed, 04 July 2007 04:10 Go to previous messageGo to next message
Eclipse UserFriend
Originally posted by: beatmik.acm.org

Konstantin Scheglov wrote:
> Konstantin Scheglov wrote:
>
>>> While I rarely use change method signature refactor and didn't want
>>> to mention this but there is nothing more annoying than Mylyn closing
>>> the Java editor I am just using. Maybe if somebody could take a look?
>>
>> Same (closing editor) happens when I rename field (may be also method).
>>
>> I've downloaded RCP package of Eclipse 3.3 mostly for Mylyn. I've
>> removed XML support from it (because I have already commercial XML
>> editor that is better). But it seems that Mylyn is still causes
>> problems as it was several months ago. :-(
>
> Same problem also happens when I use Eclipse code assist to implement
> methods in abstract class (Ctrl+Space) here "new Runnable(${cursor})".

Alex, Konstantin: If you haven't yet, could you please file a bug report
for this? I use the mechanisms that you mention very frequently and do
not see this problem, so we need to diagnose in more detail to
understand where the bad interaction is coming from.

http://www.eclipse.org/mylyn/bugs/

Mik
Re: minor annoyance with change method signature refactor [message #6794 is a reply to message #6751] Wed, 04 July 2007 04:19 Go to previous messageGo to next message
Eclipse UserFriend
Originally posted by: beatmik.acm.org

Alen Vrecko wrote:
> Sorry to be a bit blunt: That is not very user friendly way, since
> normally I would like to select lets say 4 files at once (holding ctrl)
> and add them as landmark.
>
> Surprisingly even if I select a class(not a file) I get "Not a valid
> landmark" message but if I select a method within the class then it is a
> valid landmark.
>
> IMHO: Landmarking needs some refinement. While I think it is sufficient
> if you are doing (minor) bug fixes it breaks down if for example you are
> doing some more substantial refactoring or adding some functionality to
> existing code.
>
> I know there is (Ctrl + Shift + R (Quick open)) but I would fell much
> more at ease if all the files that are revelant to me are displayed in
> the package explorer(that would still reduce quite a load of files).

As Stefan points out this is technically by design, but we have
definitely noticed it get in people's way, especially when getting
started with Mylyn and relying on manual landmarking rather than the
automatic landmarking. So we need to do something about it.

The reason that files cannot be made landmarks when the structure of a
file is understood by Mylyn (e.g. as it is for Java) is that the file is
just a container for the structured elements, and we do not allow
containers to be landmarks. One consequence of allowing them to be
landmarks is that you would see a lot more bold in your Package Explorer
than would be useful. But what we could do is something like have the
landmarking operation on the file propagate down to the first element
contained within the file (e.g. the Java class declaration). Please
post your use case on the following bug, and vote for it to help us
prioritize it:

162335: Allow "Make Landmark" to work anywhere in the file
https://bugs.eclipse.org/bugs/show_bug.cgi?id=162335

Mik
Re: minor annoyance with change method signature refactor [message #6815 is a reply to message #6787] Wed, 04 July 2007 09:49 Go to previous message
Alen Vrecko is currently offline Alen VreckoFriend
Messages: 10
Registered: July 2009
Junior Member
Added bug report 195361 (for closing editor).

https://bugs.eclipse.org/bugs/show_bug.cgi?id=195361

Have also voted on the landmark feature and added comments.

Cheers,
Alen
Re: minor annoyance with change method signature refactor [message #569252 is a reply to message #6710] Sun, 01 July 2007 06:03 Go to previous message
Konstantin Scheglov is currently offline Konstantin ScheglovFriend
Messages: 555
Registered: July 2009
Senior Member
Alen Vrecko wrote:

> I find Mylyn a pleasure to work with. It is great that it only shows the
> stuff that is relevant.
>
> Cheers for the 2.0 release.
>
> But I noticed a very minor annoyance when using the change method
> signature refactor. I am using Mylyn 2.0 (same issue with 1.0) under
> Eclipse 2.2.1 and have the following problem:
>
> Let say you open X class for editing (opened Java Editor)
> Then you wish to use the change method signature refactor, go over
> method (ctrl+shift+C) the dialog pops up. And if you use ctrl+space key
> on any of the type fields. Then the Java Editor at the back would get
> closed. Surprising this always happens if I am editing an Interface and
> rarely if a Java file.
>
> While I rarely use change method signature refactor and didn't want to
> mention this but there is nothing more annoying than Mylyn closing the
> Java editor I am just using. Maybe if somebody could take a look?

Same (closing editor) happens when I rename field (may be also method).

I've downloaded RCP package of Eclipse 3.3 mostly for Mylyn. I've
removed XML support from it (because I have already commercial XML
editor that is better). But it seems that Mylyn is still causes problems
as it was several months ago. :-(

I see also that eclipse.exe hangs in memory when I close Eclipse. May
be this is problem of Mylyn, but may be not (I've placed .mylar in
remote folder).


Konstantin Scheglov,
Google, Inc.
Re: minor annoyance with change method signature refactor [message #569301 is a reply to message #6719] Sun, 01 July 2007 20:35 Go to previous message
Konstantin Scheglov is currently offline Konstantin ScheglovFriend
Messages: 555
Registered: July 2009
Senior Member
Konstantin Scheglov wrote:

>> While I rarely use change method signature refactor and didn't want to
>> mention this but there is nothing more annoying than Mylyn closing the
>> Java editor I am just using. Maybe if somebody could take a look?
>
> Same (closing editor) happens when I rename field (may be also method).
>
> I've downloaded RCP package of Eclipse 3.3 mostly for Mylyn. I've
> removed XML support from it (because I have already commercial XML
> editor that is better). But it seems that Mylyn is still causes problems
> as it was several months ago. :-(

Same problem also happens when I use Eclipse code assist to implement
methods in abstract class (Ctrl+Space) here "new Runnable(${cursor})".

>
> I see also that eclipse.exe hangs in memory when I close Eclipse. May
> be this is problem of Mylyn, but may be not (I've placed .mylar in
> remote folder).

OK, this is really not problem with Mylyn.


Konstantin Scheglov,
Google, Inc.
Re: minor annoyance with change method signature refactor [message #569327 is a reply to message #6725] Mon, 02 July 2007 11:43 Go to previous message
Alen Vrecko is currently offline Alen VreckoFriend
Messages: 10
Registered: July 2009
Junior Member
>> I see also that eclipse.exe hangs in memory when I close Eclipse.
>> May be this is problem of Mylyn, but may be not (I've placed .mylar in
>> remote folder).
>
> OK, this is really not problem with Mylyn.

My Eclipse crashed when I clicked on the radio button next to the task
name in task list. That isn't very nice. Most probably I need to
increase the heap size.

Is there a bug filed for ctrl+space problem since I probably don't need
to mention how annoying that is?

And one more thing why is not possible to add a class as landmark? For
example I will be working with SomeDAO.java and SomeBL.java, now I wish
not to wait for Mylyn to pick this up but I want to predefine this, if I
right click on lets say SomeDAO.java and select Add as Landmark I get
"Not a valid landmark" message. How can a Java file not be a landmark?

This is greately reducing my productivity since I would like to
predefine some classes I know I will need(for a particular task) in the
package explorer. Mylyn while smart as it is should listen to my needs
ahead of time and not just in time:)

Is there a bug filed for this?

Cheers,
Alen
Re: minor annoyance with change method signature refactor [message #569371 is a reply to message #6731] Mon, 02 July 2007 12:28 Go to previous message
Stefan Langer is currently offline Stefan LangerFriend
Messages: 236
Registered: July 2009
Senior Member
You need to click on the class and no the file name in the
PackageExplorer. As far as I know this is stated in the documentation
for Mylin.

Regards
Stefan

Alen Vrecko schrieb:
>
>>> I see also that eclipse.exe hangs in memory when I close Eclipse.
>>> May be this is problem of Mylyn, but may be not (I've placed .mylar
>>> in remote folder).
>>
>> OK, this is really not problem with Mylyn.
>
> My Eclipse crashed when I clicked on the radio button next to the task
> name in task list. That isn't very nice. Most probably I need to
> increase the heap size.
>
> Is there a bug filed for ctrl+space problem since I probably don't need
> to mention how annoying that is?
>
> And one more thing why is not possible to add a class as landmark? For
> example I will be working with SomeDAO.java and SomeBL.java, now I wish
> not to wait for Mylyn to pick this up but I want to predefine this, if I
> right click on lets say SomeDAO.java and select Add as Landmark I get
> "Not a valid landmark" message. How can a Java file not be a landmark?
>
> This is greately reducing my productivity since I would like to
> predefine some classes I know I will need(for a particular task) in the
> package explorer. Mylyn while smart as it is should listen to my needs
> ahead of time and not just in time:)
>
> Is there a bug filed for this?
>
> Cheers,
> Alen
Re: minor annoyance with change method signature refactor [message #569384 is a reply to message #6744] Mon, 02 July 2007 13:32 Go to previous message
Alen Vrecko is currently offline Alen VreckoFriend
Messages: 10
Registered: July 2009
Junior Member
> You need to click on the class and no the file name in the
> PackageExplorer. As far as I know this is stated in the documentation
> for Mylin.
>

Sorry to be a bit blunt: That is not very user friendly way, since
normally I would like to select lets say 4 files at once (holding ctrl)
and add them as landmark.

Surprisingly even if I select a class(not a file) I get "Not a valid
landmark" message but if I select a method within the class then it is a
valid landmark.

IMHO: Landmarking needs some refinement. While I think it is sufficient
if you are doing (minor) bug fixes it breaks down if for example you are
doing some more substantial refactoring or adding some functionality to
existing code.

I know there is (Ctrl + Shift + R (Quick open)) but I would fell much
more at ease if all the files that are revelant to me are displayed in
the package explorer(that would still reduce quite a load of files).

Cheers,
Alen
Re: minor annoyance with change method signature refactor [message #569657 is a reply to message #6725] Wed, 04 July 2007 04:10 Go to previous message
Mik Kersten is currently offline Mik KerstenFriend
Messages: 287
Registered: July 2009
Senior Member
Konstantin Scheglov wrote:
> Konstantin Scheglov wrote:
>
>>> While I rarely use change method signature refactor and didn't want
>>> to mention this but there is nothing more annoying than Mylyn closing
>>> the Java editor I am just using. Maybe if somebody could take a look?
>>
>> Same (closing editor) happens when I rename field (may be also method).
>>
>> I've downloaded RCP package of Eclipse 3.3 mostly for Mylyn. I've
>> removed XML support from it (because I have already commercial XML
>> editor that is better). But it seems that Mylyn is still causes
>> problems as it was several months ago. :-(
>
> Same problem also happens when I use Eclipse code assist to implement
> methods in abstract class (Ctrl+Space) here "new Runnable(${cursor})".

Alex, Konstantin: If you haven't yet, could you please file a bug report
for this? I use the mechanisms that you mention very frequently and do
not see this problem, so we need to diagnose in more detail to
understand where the bad interaction is coming from.

http://www.eclipse.org/mylyn/bugs/

Mik
Re: minor annoyance with change method signature refactor [message #569679 is a reply to message #6751] Wed, 04 July 2007 04:19 Go to previous message
Mik Kersten is currently offline Mik KerstenFriend
Messages: 287
Registered: July 2009
Senior Member
Alen Vrecko wrote:
> Sorry to be a bit blunt: That is not very user friendly way, since
> normally I would like to select lets say 4 files at once (holding ctrl)
> and add them as landmark.
>
> Surprisingly even if I select a class(not a file) I get "Not a valid
> landmark" message but if I select a method within the class then it is a
> valid landmark.
>
> IMHO: Landmarking needs some refinement. While I think it is sufficient
> if you are doing (minor) bug fixes it breaks down if for example you are
> doing some more substantial refactoring or adding some functionality to
> existing code.
>
> I know there is (Ctrl + Shift + R (Quick open)) but I would fell much
> more at ease if all the files that are revelant to me are displayed in
> the package explorer(that would still reduce quite a load of files).

As Stefan points out this is technically by design, but we have
definitely noticed it get in people's way, especially when getting
started with Mylyn and relying on manual landmarking rather than the
automatic landmarking. So we need to do something about it.

The reason that files cannot be made landmarks when the structure of a
file is understood by Mylyn (e.g. as it is for Java) is that the file is
just a container for the structured elements, and we do not allow
containers to be landmarks. One consequence of allowing them to be
landmarks is that you would see a lot more bold in your Package Explorer
than would be useful. But what we could do is something like have the
landmarking operation on the file propagate down to the first element
contained within the file (e.g. the Java class declaration). Please
post your use case on the following bug, and vote for it to help us
prioritize it:

162335: Allow "Make Landmark" to work anywhere in the file
https://bugs.eclipse.org/bugs/show_bug.cgi?id=162335

Mik
Re: minor annoyance with change method signature refactor [message #569780 is a reply to message #6787] Wed, 04 July 2007 09:49 Go to previous message
Alen Vrecko is currently offline Alen VreckoFriend
Messages: 10
Registered: July 2009
Junior Member
Added bug report 195361 (for closing editor).

https://bugs.eclipse.org/bugs/show_bug.cgi?id=195361

Have also voted on the landmark feature and added comments.

Cheers,
Alen
Previous Topic:What happened to the generic web connector?
Next Topic:Extension points definition
Goto Forum:
  


Current Time: Fri Dec 19 03:22:24 GMT 2014

Powered by FUDForum. Page generated in 0.04227 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software