Eclipse Community Forums: GMF (Graphical Modeling Framework) » Bug in hide selection / ShapeNodeEditPart: Not restoring edges/links properly on undo

Home » Modeling » GMF (Graphical Modeling Framework) » Bug in hide selection / ShapeNodeEditPart: Not restoring edges/links properly on undo

Show: Today's Messages :: Show Polls :: Message Navigator

Bug in hide selection / ShapeNodeEditPart: Not restoring edges/links properly on undo [message #691844]

Sat, 02 July 2011 14:45

Ivar Refsdal

Messages: 24
Registered: May 2011

Junior Member

Hi

Thanks for a nice framework so far!

However, I ran into a problem where the edges weren't restored on undo.
It can be reproduced in the ecore diagram editor like the following (I
suppose in any GMF editor):

1. Create two classes A and B.
2. Create an inheritance link from A to B, i.e. A -> B.
3. Hide B, then hide A separately (right click, filter, hide selection).
4. Do Ctrl-z two times.

Bug: The inheritance link/edge does not appear.

Solution:
Instead of using
org.eclipse.gmf.runtime.diagram.core.util.ViewUtil.get[Target|Source]ConnectionsConnectingVisibleViews(View)
as
org.eclipse.gmf.runtime.diagram.ui.editparts.ShapeNodeEditPart.getModel[Target|Source]Connections()
does, one can use
org.eclipse.gmf.runtime.diagram.core.util.ViewUtil.get[Target|Source]Connections(View)

I suppose there is a good reason for using the more complex VisibleViews
method.. Anyone knows why?

Should I file a bug-report for this?

Best regards,
Ivar Refsdal

Report message to a moderator