Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Dynamic Languages Toolkit (DLTK) » (no subject)
(no subject) [message #685498] Fri, 17 June 2011 16:15 Go to next message
Bruno Medeiros is currently offline Bruno Medeiros
Messages: 14
Registered: July 2009
Junior Member
I was looking at ScriptElementImageDescriptor today, and I found this
code in the equals() method:

return (other.fFlags == this.fFlags) &&
(fBaseImage.equals(other.fBaseImage) == fSize.equals(other.fSize));

Is that a bug? Because if the fBaseImage is not equal, and the fSize is
not equal as well, then the equals result will be true. That doesn't
seem right.

- Bruno Medeiros
D Development Tools: http://code.google.com/a/eclipselabs.org/p/ddt/
Re: Bug in ScriptElementImageDescriptor ? [message #883026 is a reply to message #685498] Thu, 07 June 2012 17:04 Go to previous message
Alex Panchenko is currently offline Alex Panchenko
Messages: 3
Registered: July 2009
Junior Member
Hi Bruno,

This bug was fixed.

Thanks,
Alex

On 06/17/2011 11:15 PM, Bruno Medeiros wrote:
> I was looking at ScriptElementImageDescriptor today, and I found this
> code in the equals() method:
>
> return (other.fFlags == this.fFlags) &&
> (fBaseImage.equals(other.fBaseImage) == fSize.equals(other.fSize));
>
> Is that a bug? Because if the fBaseImage is not equal, and the fSize is
> not equal as well, then the equals result will be true. That doesn't
> seem right.
>
> - Bruno Medeiros
> D Development Tools: http://code.google.com/a/eclipselabs.org/p/ddt/
Previous Topic:Extend DLTK/JavaScript model
Next Topic:TCL Templates (Snippets) not working
Goto Forum:
  


Current Time: Thu Oct 23 15:12:25 GMT 2014

Powered by FUDForum. Page generated in 0.30535 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software