P2 normally asks the following version format "major.minor.service.qualifier" for plug-ins, though it's not really mandatory. What I think is mandatory is to have the version number be monotonically increasing. The usual pattern is to include the source control id in the qualifier. Unfortunately, git uses hash codes as ids, which doesn't ensure that the number increases with versions.
So how does it work for plug-in versions stored using git? I noticed that eGit and JGit plug-ins don't use the qualifier at the end of the version number: Should we do just that, forget about the qualifier?
Paul Webster Messages: 6859 Registered: July 2009 Location: Ottawa
On 02/15/2011 05:44 AM, Maxime Jeanmart wrote:
> So how does it work for plug-in versions stored using git? I noticed
> that eGit and JGit plug-ins don't use the qualifier at the end of the
> version number: Should we do just that, forget about the qualifier?
egit and jgit do use the qualifier, at least for the nightlies. I guess
just not for the release. That means technically the nightly plugin is
"greater" than the released plugin.
But I didn't have any trouble updating from a nightly to the release, I
guess it doesn't matter so much.
But in e4 we use git repos and map files with PDE build and the Git
fetch factory, and it produces plugins with the traditional increasing
I think it makes sense indeed. Since the qualifier starts with the date, the nightly build always produces a higher qualifier, whatever the id after the date.
I guess we just have to take care if we do more than a build a day for some reasons, which should not happen too often.