Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Eclipse Platform » Compare bug, have patch, any chance for 3.6.2?
Compare bug, have patch, any chance for 3.6.2? [message #651642] Tue, 01 February 2011 02:16 Go to next message
Gergely Nagy is currently offline Gergely Nagy
Messages: 17
Registered: July 2009
Junior Member
When upgrading from our product from 3.3 to 3.6.1 (finally got the green light from managers after some fights),
I've run into a this regression..
basically Compare framework does not seem to work with non-textual/non-steam input any more, ContentMergeViewers are not created as they should.

It's https://bugs.eclipse.org/bugs/show_bug.cgi?id=293926,
reported >1 year ago, trivial patch is provided around that time, verified it -> it works.

Added several comments to clarify -> got no response yet. - am unsure if some is looking it at all. Is there a better place to push this forward (mailing list, another forum, IRC, raise another bug, tagging, etc...)?

Is there a way that this patch be included 3.6.2 (out soon as I understand).
No pressure:) but ... I would much prefer to upgrade to an official Eclipse version than having to build a custom patch.

Thank you in advance,Gergely

[Updated on: Tue, 01 February 2011 11:26]

Report message to a moderator

Re: Compare bug, have patch, any chance for 3.6.2? [message #651712 is a reply to message #651642] Tue, 01 February 2011 11:38 Go to previous messageGo to next message
Mauro Molinari is currently offline Mauro Molinari
Messages: 278
Registered: July 2009
Senior Member
Il 01/02/2011 03:16, Gergely Nagy ha scritto:
> Added several comments to clarify -> got no response yet. - am unsure if
> some is looking it at all. Is there a better place to push this forward
> (mailing list, another forum, IRC, raise another bug, tagging, etc...)?

I think the best is to keep on posting comments on that bug until
someone replies...

Good luck!
Mauro.
Re: Compare bug, have patch, any chance for 3.6.2? [message #651744 is a reply to message #651712] Tue, 01 February 2011 13:01 Go to previous messageGo to next message
Deepak Azad is currently offline Deepak Azad
Messages: 545
Registered: July 2009
Senior Member
On 2/1/2011 5:08 PM, Mauro Molinari wrote:
> Il 01/02/2011 03:16, Gergely Nagy ha scritto:
>> Added several comments to clarify -> got no response yet. - am unsure if
>> some is looking it at all. Is there a better place to push this forward
>> (mailing list, another forum, IRC, raise another bug, tagging, etc...)?
>
> I think the best is to keep on posting comments on that bug until
> someone replies...
>
> Good luck!
> Mauro.
Yep, you can ping on the bug once a week. Someone will respond..
Re: Compare bug, have patch, any chance for 3.6.2? [message #651754 is a reply to message #651744] Tue, 01 February 2011 13:34 Go to previous messageGo to next message
Gergely Nagy is currently offline Gergely Nagy
Messages: 17
Registered: July 2009
Junior Member
Thanks for the replies hint - I'll try that Smile


The only thing is I'd really like this to happen within 3.6.2, otherwise I'd have to either build my own patched org.eclipse.compare bundle, or wait at least another year (actually this is not really an option).

Is there a clean way to deploy patches with these 1-line kind of fixes into my app? I understand fragments might work but that's not a reliable way.
Should I just import it into Eclipse, add fix, change version (qualifier?) rebuild, export plugin from Eclipse, and replace old jar in the app with the new one?
Re: Compare bug, have patch, any chance for 3.6.2? [message #651776 is a reply to message #651754] Tue, 01 February 2011 14:50 Go to previous messageGo to next message
Deepak Azad is currently offline Deepak Azad
Messages: 545
Registered: July 2009
Senior Member
On 2/1/2011 7:04 PM, Gergely Nagy wrote:
> Thanks for the replies hint - I'll try that :)
>
>
> The only thing is I'd really like this to happen within 3.6.2, otherwise
> I'd have to either build my own patched org.eclipse.compare bundle, or
> wait at least another year (actually this is not really an option).
The next release - 3.7 - will happen in June, so the wait is not a year :)


> Should I just import it into Eclipse, add fix, change version
> (qualifier?) rebuild, export plugin from Eclipse, and replace old jar in
> the app with the new one?
Sure you can do this, but note that if you change the version you also
have to fiddle with p2 to get it to work. But if you keep the same
version and then replace the old jar, then things should work just fine.
Re: Compare bug, have patch, any chance for 3.6.2? [message #651882 is a reply to message #651776] Tue, 01 February 2011 21:31 Go to previous messageGo to next message
Gergely Nagy is currently offline Gergely Nagy
Messages: 17
Registered: July 2009
Junior Member
Deepak Azad wrote on Tue, 01 February 2011 09:50
On 2/1/2011 7:04 PM, Gergely Nagy wrote:
> wait at least another year (actually this is not really an option).
The next release - 3.7 - will happen in June, so the wait is not a year Smile
.

Ok, well as an ISV I prefer to wait for SR1-2 to get less bugs to hack around

Quote:

> Should I just import it into Eclipse, add fix, change version
> (qualifier?) rebuild, export plugin from Eclipse, and replace old jar in
> the app with the new one?
Sure you can do this, but note that if you change the version you also
have to fiddle with p2 to get it to work. But if you keep the same
version and then replace the old jar, then things should work just fine.

Good point, although I managed to avoid the P2 minefield so far. Just overwriting existing jar with no version change sounds dirty and dangerous too.
Any guidelines, best practices for patch versioning?
Thanks.
Re: Compare bug, have patch, any chance for 3.6.2? [message #651912 is a reply to message #651882] Wed, 02 February 2011 03:54 Go to previous messageGo to next message
Deepak Azad is currently offline Deepak Azad
Messages: 545
Registered: July 2009
Senior Member
On 2/2/2011 3:01 AM, Gergely Nagy wrote:
> Quote:
>> > Should I just import it into Eclipse, add fix, change version
>> > (qualifier?) rebuild, export plugin from Eclipse, and replace old
>> jar in
>> > the app with the new one?
>> Sure you can do this, but note that if you change the version you also
>> have to fiddle with p2 to get it to work. But if you keep the same
>> version and then replace the old jar, then things should work just fine.
>
> Good point, although I managed to avoid the P2 minefield so far. Just
> overwriting existing jar with no version change sounds dirty and
> dangerous too.
> Any guidelines, best practices for patch versioning?
> Thanks.
The right way is to go via p2 - the export wizard also lets you install
into the host eclipse (though I have not tried this option to install a
plugin into another eclipse installation).

Overwriting the existing jar is just a quick and dirty way, but not
dangerous ;-)
Re: Compare bug, have patch, any chance for 3.6.2? [message #651980 is a reply to message #651882] Wed, 02 February 2011 10:54 Go to previous messageGo to next message
Dani Megert is currently offline Dani Megert
Messages: 3801
Registered: July 2009
Senior Member
On 01.02.2011 22:31, Gergely Nagy wrote:
> Deepak Azad wrote on Tue, 01 February 2011 09:50
>> On 2/1/2011 7:04 PM, Gergely Nagy wrote:
>> > wait at least another year (actually this is not really an option).
>> The next release - 3.7 - will happen in June, so the wait is not a
>> year :)
>> .
>
> Ok, well as an ISV I prefer to wait for SR1-2 to get less bugs to hack
> around
>
> Quote:
>> > Should I just import it into Eclipse, add fix, change version
>> > (qualifier?) rebuild, export plugin from Eclipse, and replace old
>> jar in
>> > the app with the new one?
>> Sure you can do this, but note that if you change the version you
>> also have to fiddle with p2 to get it to work. But if you keep the
>> same version and then replace the old jar, then things should work
>> just fine.
>
> Good point, although I managed to avoid the P2 minefield so far. Just
> overwriting existing jar with no version change sounds dirty and
> dangerous too.
> Any guidelines, best practices for patch versioning?
See
http://help.eclipse.org/helios/index.jsp?topic=/org.eclipse. pde.doc.user/guide/tools/project_wizards/new_feature_patch.h tm

Dani
> Thanks.
Re: Compare bug, have patch, any chance for 3.6.2? [message #651993 is a reply to message #651980] Wed, 02 February 2011 11:35 Go to previous message
Deepak Azad is currently offline Deepak Azad
Messages: 545
Registered: July 2009
Senior Member
On 2/2/2011 4:24 PM, Daniel Megert wrote:

>> Good point, although I managed to avoid the P2 minefield so far. Just
>> overwriting existing jar with no version change sounds dirty and
>> dangerous too.
>> Any guidelines, best practices for patch versioning?
> See
> http://help.eclipse.org/helios/index.jsp?topic=/org.eclipse. pde.doc.user/guide/tools/project_wizards/new_feature_patch.h tm
>
>
> Dani
>> Thanks.
Oh, wasn't aware of this :)

See also -
http://aniefer.blogspot.com/2009/06/patching-features-with-p 2.html
http://aniefer.blogspot.com/2009/06/patching-features-part-2 .html
Previous Topic:Linking to a toc.xml which doesn't have any html contents
Next Topic:PLS HELP compression in java using eclipse
Goto Forum:
  


Current Time: Tue Sep 16 09:39:50 GMT 2014

Powered by FUDForum. Page generated in 0.02510 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software