Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » EGit » Is reusing diff editor intentional?
Is reusing diff editor intentional? [message #639111] Mon, 15 November 2010 06:02 Go to next message
Ruth Alkema is currently offline Ruth Alkema
Messages: 4
Registered: July 2009
Junior Member
Hi,

since commit e2436108447d6dac104c52a2688e7acd5ebde19f the same editor is used, each time I double click on a changed file in a commit.

Personally I don't like this behaviour, I prefer to open all modified files of one commit side by side, so that I can easily review the code changes by my team members.

This is now no longer possible, so I patched the CommitFileDiffViewer, so that it reopens a new editor each time. (1 line patch):
-               CompareUtils.openInCompare(site.getWorkbenchWindow().getActivePage(),
-                               in);
+               CompareUI.openCompareEditor(in);


Now I wonder if this change is intentional, or perhaps there could be made a preference for it, or should I file a bug, or submit my patch to gerrit, in order to restore the old behaviour?
Re: Is reusing diff editor intentional? [message #639231 is a reply to message #639111] Mon, 15 November 2010 12:11 Go to previous messageGo to next message
Chris Aniszczyk is currently offline Chris Aniszczyk
Messages: 674
Registered: July 2009
Senior Member
I would create a bug and upload a patch to Gerrit.

I think we could make this a preference.
Re: Is reusing diff editor intentional? [message #639356 is a reply to message #639231] Tue, 16 November 2010 04:01 Go to previous message
Matthias Sohn is currently offline Matthias Sohn
Messages: 543
Registered: July 2009
Senior Member
+1 to make this configurable in preferences
Previous Topic:ExtensionPoint for CommitDialog?
Next Topic:Password storage [OS X]
Goto Forum:
  


Current Time: Mon Jul 28 04:22:28 EDT 2014

Powered by FUDForum. Page generated in 0.01446 seconds