Home » Archived » Eclipse Communications Framework (ECF) » Patch needed to compile current ECF HEAD on 3.2.1 platform?
| Patch needed to compile current ECF HEAD on 3.2.1 platform? [message #612048] |
Sun, 28 January 2007 20:42  |
 Mario Scalas
Messages: 32
Registered: July 2009 |
Member |
|
|
--nextPart1258168.qdQ16aRYg4
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8Bit
Hi all,
I've checked out my ECF copy and saw that the following patch is needed
to make it compile successfully on my 3.2.1 platform: is this wanted? (API
changes in 3.3 perhaps?)
What is there reference platform current ECF HEAD is to compile against?
Stable 3.2 or HEAD (future 3.3)?
Thanks
Mario
--
Mario Scalas
Ph.D. student
Collaborative Development Group
University of Bari - C.S. Dept.
Via E. Orabona, 4
70125 Bari - ITALY
web: http://cdg.di.uniba.it/scalas/
email: scalas (at) di.uniba.it
"Relax. You don't have to be a great designer --you just have to be
creatively lazy." (Kent Beck)
--nextPart1258168.qdQ16aRYg4
Content-Type: text/x-diff; name="org.eclipse.ecf.examples.clients.patch"
Content-Transfer-Encoding: 8Bit
Content-Disposition: attachment; filename="org.eclipse.ecf.examples.clients.patch"
### Eclipse Workspace Patch 1.0
#P org.eclipse.ecf.example.clients
Index: src/org/eclipse/ecf/example/clients/Activator.java
============================================================ =======
RCS file: /cvsroot/technology/org.eclipse.ecf/plugins/org.eclipse.ecf. example.clients/src/org/eclipse/ecf/example/clients/Activato r.java,v
retrieving revision 1.2
diff -u -r1.2 Activator.java
--- src/org/eclipse/ecf/example/clients/Activator.java 26 Jan 2007 21:46:07 -0000 1.2
+++ src/org/eclipse/ecf/example/clients/Activator.java 28 Jan 2007 20:15:26 -0000
@@ -17,7 +17,7 @@
public class Activator extends AbstractUIPlugin {
private static Activator instance = null;
-
+
public static final String PLUGIN_ID = "org.eclipse.ecf.example.clients"; //$NON-NLS-1$
public Activator() {
super();
@@ -27,9 +27,9 @@
public static Activator getDefault() {
return instance;
}
-
+
public void log(int status, String message, Throwable exception) {
- getLog().log(new Status(status,PLUGIN_ID,message,exception));
+ getLog().log(new Status(status,PLUGIN_ID,Status.OK,message,exception));
}
/**
* This method is called upon plug-in activation
--nextPart1258168.qdQ16aRYg4--
|
|
|
| Re: Patch needed to compile current ECF HEAD on 3.2.1 platform? [message #612049 is a reply to message #612048] |
Mon, 29 January 2007 00:50  |
Scott Lewis
Messages: 1038
Registered: July 2009 |
Senior Member |
|
|
Hi Mario,
Thanks, I've applied the patch and checked in (actually I changed things
a little bit, but the Status constructor uses the one available in 3.2).
You should be able to get the fix now (in repository...we'll have a
release that includes this within a couple of weeks).
We are considering making some plugins dependent upon 3.3 APIs, however,
as there are some things (particularly in the 3.3 UI that would prove
very useful...e.g. enhanced tooltips).
We would be interested in hearing from people in this newsgroup whether
introduction of 3.3 dependent APIs is a problem for people (at least for
some plugins...like the *.ui plugins). We will continue to have the API
plugins (e.g. core, sharedobject, identity, filetransfer, discovery,
datashare, remoteservices) compatible with 3.2.
Thanks Mario for catching this, and others please let us know what you
think about 3.3 v 3.2 API usage/dependencies.
Scott
Mario Scalas wrote:
> Hi all,
> I've checked out my ECF copy and saw that the following patch is needed
> to make it compile successfully on my 3.2.1 platform: is this wanted? (API
> changes in 3.3 perhaps?)
>
> What is there reference platform current ECF HEAD is to compile against?
> Stable 3.2 or HEAD (future 3.3)?
>
> Thanks
> Mario
>
>
>
> ------------------------------------------------------------ ------------
>
> ### Eclipse Workspace Patch 1.0
> #P org.eclipse.ecf.example.clients
> Index: src/org/eclipse/ecf/example/clients/Activator.java
> ============================================================ =======
> RCS file: /cvsroot/technology/org.eclipse.ecf/plugins/org.eclipse.ecf. example.clients/src/org/eclipse/ecf/example/clients/Activato r.java,v
> retrieving revision 1.2
> diff -u -r1.2 Activator.java
> --- src/org/eclipse/ecf/example/clients/Activator.java 26 Jan 2007 21:46:07 -0000 1.2
> +++ src/org/eclipse/ecf/example/clients/Activator.java 28 Jan 2007 20:15:26 -0000
> @@ -17,7 +17,7 @@
> public class Activator extends AbstractUIPlugin {
>
> private static Activator instance = null;
> -
> +
> public static final String PLUGIN_ID = "org.eclipse.ecf.example.clients"; //$NON-NLS-1$
> public Activator() {
> super();
> @@ -27,9 +27,9 @@
> public static Activator getDefault() {
> return instance;
> }
> -
> +
> public void log(int status, String message, Throwable exception) {
> - getLog().log(new Status(status,PLUGIN_ID,message,exception));
> + getLog().log(new Status(status,PLUGIN_ID,Status.OK,message,exception));
> }
> /**
> * This method is called upon plug-in activation
>
|
|
|
| Re: Patch needed to compile current ECF HEAD on 3.2.1 platform? [message #612050 is a reply to message #612049] |
Mon, 29 January 2007 22:57 |
Mario Scalas
Messages: 32
Registered: July 2009 |
Member |
|
|
Hi Scott,
Scott Lewis wrote:
> Hi Mario,
>
> Thanks, I've applied the patch and checked in (actually I changed things
> a little bit, but the Status constructor uses the one available in 3.2).
>
> You should be able to get the fix now (in repository...we'll have a
> release that includes this within a couple of weeks).
Good, I'm working with ECF HEAD now.
> We are considering making some plugins dependent upon 3.3 APIs, however,
> as there are some things (particularly in the 3.3 UI that would prove
> very useful...e.g. enhanced tooltips).
>
> We would be interested in hearing from people in this newsgroup whether
> introduction of 3.3 dependent APIs is a problem for people (at least for
> some plugins...like the *.ui plugins). We will continue to have the API
> plugins (e.g. core, sharedobject, identity, filetransfer, discovery,
> datashare, remoteservices) compatible with 3.2.
>
> Thanks Mario for catching this, and others please let us know what you
> think about 3.3 v 3.2 API usage/dependencies.
I've downloaded the latest 3.3 integration build
(eclipse-SDK-I20070123-1715-linux-gtk-x86_64.tar.gz) on my development
machine (Kubuntu Linux 6.10, Java 6.0, KDE 3.5.6 and GTK 2.6.10, all on
AMD64 architecture). It seems that dialogs have some problems with
positioning (they all appear on the top left corner, not in the middle of
the screen) and have some odd dimensions (very large width or just full
screen's height): nothing too bad that inficiate usability but makes me
think that something else may hide ... maybe there will be some need to
standardize on a particular 3.3 release build or milestone when doing ECF
releases to? Or just wait for the 3.3M5 release and then switch on that for
the *.ui plugins?
Just my .02 cents: I plan to use 3.3 for ECF development, at least if no
serious problem arises ;)
Mario
--
Mario Scalas
Ph.D. student
Collaborative Development Group
University of Bari - C.S. Dept.
Via E. Orabona, 4
70125 Bari - ITALY
web: http://cdg.di.uniba.it/scalas/
email: scalas (at) di.uniba.it
"Relax. You don't have to be a great designer --you just have to be
creatively lazy." (Kent Beck)
|
|
| |
| |
  |
Goto Forum:
Current Time: Sat Apr 20 02:00:20 GMT 2024
Powered by FUDForum. Page generated in 0.03710 seconds |
] 
Search
Help
Register
Login
Home
