Eclipse Community Forums: IMP » Proposed API change to IEditorService

Help

Home

Home » Eclipse Projects » IMP » Proposed API change to IEditorService

Show: Today's Messages :: Show Polls :: Message Navigator

Proposed API change to IEditorService [message #578014]

Fri, 06 August 2010 18:25

Adam Taylor
Messages: 12
Registered: August 2010

Junior Member

*** Problem: ***

https://bugs.eclipse.org/bugs/show_bug.cgi?id=322035

IMP does not have enough "knowledge" to open editors on all types of IEditorInput

*** Diagnosis: ***

EditorInputUtils can handle only certain types of IEditorInput. Need a way for language provider to handle other types

*** Proposed IMP API change: ***

Add the following methods:

public interface IEditorService{
// ...

public IFile getFile(IEditorInput editorInput);

public String getNameExtension(IEditorInput editorInput);

public IPath getPath(IEditorInput editorInput);

// ...
}

Report message to a moderator

Re: Proposed API change to IEditorService [message #578033 is a reply to message #578014]

Fri, 06 August 2010 18:47

Adam Taylor
Messages: 12
Registered: August 2010

Junior Member

Upon further review, LanguageServiceManager can return multiple instances of IEditorService. We need to add these methods to a service which has only one instance per language, or create a new service.

*** NEW Proposed IMP API change: ***

Create a new service with the following methods:

public interface IEditorInputService{

public IFile getFile(IEditorInput editorInput);

public String getNameExtension(IEditorInput editorInput);

public IPath getPath(IEditorInput editorInput);

}

and create the corresponding extension point

Report message to a moderator

Previous Topic:	Proposed API change to IEditorService
Next Topic:	Proposed API change to IMessageHandler

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Mon Oct 07 18:59:31 EDT 2013