| Re: [frascati] SCA API in the STP/SCA project [message #575079] |
Mon, 25 May 2009 05:28 |
|
Hi Lionel.
I CC'ed this question to the SCA Tools newsgroup.
Vincent.
Lionel Seinturier a écrit :
> Hi Stéphane,
>
> I have a couple of remarks about the SCA Java API that you committed
in the STP/SCA SVN:
>
>
http://dev.eclipse.org/svnroot/stp/org.eclipse.stp.sca-tools /org.eclipse.stp.sca/trunk/org.eclipse.stp.sca.osoa.java
>
> I'm not sure whether there is a mailing list where these remarks can
be sent, so I'm sending them to you privately. In any case such a ML
exists and I missed it, do not hesitate to mention it: I'll resend my
message for the record and the community.
>
>
> 1/ In interface Conversation: shouldn't method getConversionID() be
spelled getConversationID()?
>
> Version 1.00 of the specs (Java Client and Implementation
Specification) says:
>
> ----------------------------
> public interface Conversation {
> Object getConversionID();
> void end();
> }
>
> The ServiceReference (sic!!) Java interface has the following methods:
> * getConversationID() – Returns the identifier for this conversation.
If a user-defined identity had been supplied for this reference then its
value will be returned; otherwise the identity generated by the system
when the conversation was initiated will be returned.
> * end() – Ends this conversation.
> ----------------------------
>
> The code snippet declares getConversionID, but the comment provides
the more intuitive version getConversationID. I guess we can assume that
the code snippet contains a typo and that the correct version is
getConversationID.
>
> BTW it is also clear that the comment contains a typo: one should
read "The Conversation Java interface" and not "The ServiceReference
Java interface".
>
>
> 2/ Shouldn't class NoRegistredCallbackException be spelled
NoRegisteredCallbackException?
>
>
> 3/ It would be nice if the ConversationEndedException,
ServiceRuntimeException and ServiceUnavailableException exceptions would
declare four constructors to override the ones declared in RuntimeException:
> - no arg
> - (String)
> - (String,Throwable)
> - (Throwable)
>
>
> Lionel.
>
--
Vincent Zurczak
EBM WebSourcing
+33 (0) 4 38 12 16 77
|
|
|
Powered by
FUDForum. Page generated in 0.03339 seconds
] 
Search
Help
Register
Login
Home
