Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Language IDEs » AspectJ » what does AJDT do to the JavaBuildPath-Edit function?
what does AJDT do to the JavaBuildPath-Edit function? [message #54870] Mon, 11 July 2005 20:09 Go to next message
Michael Moser is currently offline Michael MoserFriend
Messages: 914
Registered: July 2009
Senior Member
Apparently, as soon as there is ONE Aspect-J project open, the
Properties-tab for the JavaBuildPath (even for projects that have no
Aspect-J nature) is modified such, that there is no Edit... button any
more using which one can exclude individual sub-folders and/or files
from a source directory.

First: why is this so?

Second: This drives me nuts, since I have a subdirectory with icons
(.gif files) in my project and obviously Windows creates a hidden
Thumbs.db file in such folders. This file is apparently locked and with
each rebuild this causes an error dialog to pop up telling me that this
resource is locked and eclipse can not access it:

FileNotFoundException thrown: <path here>\icons\Thumbs.db (Access is
denied)

Due to the inability to exclude that specific file (due to the missing
edit capability) one also can not tell Eclipse/AJDT to leave that damned
file alone.

Getta U hands off my thumbs!!! :-)

Michael
Re: what does AJDT do to the JavaBuildPath-Edit function? [message #54897 is a reply to message #54870] Mon, 11 July 2005 20:22 Go to previous messageGo to next message
Barry Kaplan is currently offline Barry KaplanFriend
Messages: 230
Registered: July 2009
Senior Member
This is not the only global side effect. Refactor-rename is also affected simply by having the ajdt plugin installed -- you don't even have to be using it!. (There is a bug for this, but sorry, I don't recall the number.) I must say its amazing that there are not way more of these little issues given what ajdt has to do reuse the jdt plugin.

-barry
Re: what does AJDT do to the JavaBuildPath-Edit function? [message #54950 is a reply to message #54870] Tue, 12 July 2005 09:53 Go to previous messageGo to next message
Eclipse UserFriend
Originally posted by: mchapman.uk.ibm.com

Michael,

That definitely should not be the case. My workspace contains a mix of
AspectJ and Java projects, and the AspectJ ones don't have the edit
button, but the Java ones do. Please raise a bug with more details of your
environment, and we'll see if we can work out why this isn't working as it
should for you.

Looks like we might need another bug for the file not found exception. You
shouldn't really need to exclude non-source files. Also, wouldn't it be
cleaner to have your icons directory outside the source folder
anyway?

Regards,

Matt.

On Mon, 11 Jul 2005 22:09:10 +0200, Michael Moser wrote:
> Apparently, as soon as there is ONE Aspect-J project open, the
> Properties-tab for the JavaBuildPath (even for projects that have no
> Aspect-J nature) is modified such, that there is no Edit... button any
> more using which one can exclude individual sub-folders and/or files
> from a source directory.
>
> First: why is this so?
>
> Second: This drives me nuts, since I have a subdirectory with icons
> (.gif files) in my project and obviously Windows creates a hidden
> Thumbs.db file in such folders. This file is apparently locked and with
> each rebuild this causes an error dialog to pop up telling me that this
> resource is locked and eclipse can not access it:
>
> FileNotFoundException thrown: <path here>\icons\Thumbs.db (Access is
> denied)
>
> Due to the inability to exclude that specific file (due to the missing
> edit capability) one also can not tell Eclipse/AJDT to leave that damned
> file alone.
>
> Getta U hands off my thumbs!!! :-)
>
> Michael
--
Matt Chapman
AJDT Development, http://www.eclipse.org/ajdt
Re: what does AJDT do to the JavaBuildPath-Edit function? [message #54975 is a reply to message #54897] Tue, 12 July 2005 10:02 Go to previous messageGo to next message
Eclipse UserFriend
Originally posted by: mchapman.uk.ibm.com

On Mon, 11 Jul 2005 13:22:38 -0700, Barry Kaplan wrote:
> This is not the only global side effect. Refactor-rename is also
> affected simply by having the ajdt plugin installed -- you don't even
> have to be using it!. (There is a bug for this, but sorry, I don't
> recall the number.) I must say its amazing that there are not way more
> of these little issues given what ajdt has to do reuse the jdt plugin.

Yes, the bug is 100018. I've just picked this up - we *really* don't want
the installation of ajdt to affect plain java projects. I think this is
new with eclipse 3.1.

Regards,

Matt.

--
Matt Chapman
AJDT Development, http://www.eclipse.org/ajdt
Re: what does AJDT do to the JavaBuildPath-Edit function? [message #55002 is a reply to message #54950] Tue, 12 July 2005 10:17 Go to previous messageGo to next message
Michael Moser is currently offline Michael MoserFriend
Messages: 914
Registered: July 2009
Senior Member
Hi Matt,

"Matt Chapman" <mchapman@uk.ibm.com> wrote in message
news:pan.2005.07.12.09.53.19.62863@uk.ibm.com...
> ...
> button, but the Java ones do. Please raise a bug with more details of
> your
> environment, and we'll see if we can work out why this isn't working
> as it
> should for you.

I'll try to boil this down to something easily reproducible.

> Looks like we might need another bug for the file not found exception.
> You
> shouldn't really need to exclude non-source files. Also, wouldn't it
> be
> cleaner to have your icons directory outside the source folder
> anyway?

In principle I agree, but the problem is with the
org.eclipse.jface.resource.ImageDescriptor class, which I use to load my
icons and which has a method:

public static ImageDescriptor createFromFile(Class location, String
filename) {...}


i.e. it requires a class as location relative to which to search for the
icons.

With that method I can not go up beyond (or sideways off) the location
of the class file, so I created a subdirectory with my icons in the
directory where that class sits

One can prefix additional path elements to the filename. In my case its
'filename = "icons/" + name + ".gif";'
Hm, maybe I should try with something like "../../icons/" or such, but I
doubt, that the java security manager would like that...

Michael
Re: what does AJDT do to the JavaBuildPath-Edit function? [message #55028 is a reply to message #54975] Tue, 12 July 2005 15:06 Go to previous messageGo to next message
Barry Kaplan is currently offline Barry KaplanFriend
Messages: 230
Registered: July 2009
Senior Member
Matt Chapman wrote:
> Yes, the bug is 100018. I've just picked this up - we *really* don't want
> the installation of ajdt to affect plain java projects. I think this is
> new with eclipse 3.1.

It is new with 3.1. And of course I know you don't want to spam java projects :-) Like I said, I'm very impressed with what has been done using the jdt given that it was not intended for the kind reuse ajdt imposes on it. I hope that the jdt team works to improve in this area, as it seems that others would like to extend the jdt for language extensions.

Thanks much Matt
Re: what does AJDT do to the JavaBuildPath-Edit function? [message #55055 is a reply to message #55002] Tue, 12 July 2005 15:48 Go to previous messageGo to next message
Eclipse UserFriend
Originally posted by: mchapman.uk.ibm.com

On Tue, 12 Jul 2005 12:17:48 +0200, Michael Moser wrote:
> In principle I agree, but the problem is with the
> org.eclipse.jface.resource.ImageDescriptor class, which I use to load my
> icons and which has a method:
>
> public static ImageDescriptor createFromFile(Class location, String
> filename) {...}

Fair enough. In AJDT we use ImageDescriptor.createFromURL(), deriving the
URL via Plugin.getBundle().getEntry(), so we haven't hit the problem.

Regards,

Matt.
Re: what does AJDT do to the JavaBuildPath-Edit function? [message #55081 is a reply to message #55028] Tue, 12 July 2005 15:54 Go to previous message
Eclipse UserFriend
Originally posted by: mchapman.uk.ibm.com

On Tue, 12 Jul 2005 08:06:06 -0700, Barry Kaplan wrote:
> It is new with 3.1. And of course I know you don't want to spam java
> projects :-) Like I said, I'm very impressed with what has been done
> using the jdt given that it was not intended for the kind reuse ajdt
> imposes on it. I hope that the jdt team works to improve in this area,
> as it seems that others would like to extend the jdt for language
> extensions.

Fyi, I've just committed a fix to bug 100018. It should be in the next dev
build to appear. There was a resource change listener that was listening
to too much. As well as fixing the editor closing problem, there is also a
small performance gain, as we now avoid processing resource deltas for
non-AJ projects (our main listener already did this, but there was a
second listener that didn't).

Regards,

Matt.
Re: what does AJDT do to the JavaBuildPath-Edit function? [message #589391 is a reply to message #54870] Mon, 11 July 2005 20:22 Go to previous message
Barry Kaplan is currently offline Barry KaplanFriend
Messages: 230
Registered: July 2009
Senior Member
This is not the only global side effect. Refactor-rename is also affected simply by having the ajdt plugin installed -- you don't even have to be using it!. (There is a bug for this, but sorry, I don't recall the number.) I must say its amazing that there are not way more of these little issues given what ajdt has to do reuse the jdt plugin.

-barry
Re: what does AJDT do to the JavaBuildPath-Edit function? [message #589414 is a reply to message #54870] Tue, 12 July 2005 09:53 Go to previous message
Matt Chapman is currently offline Matt ChapmanFriend
Messages: 429
Registered: July 2009
Senior Member
Michael,

That definitely should not be the case. My workspace contains a mix of
AspectJ and Java projects, and the AspectJ ones don't have the edit
button, but the Java ones do. Please raise a bug with more details of your
environment, and we'll see if we can work out why this isn't working as it
should for you.

Looks like we might need another bug for the file not found exception. You
shouldn't really need to exclude non-source files. Also, wouldn't it be
cleaner to have your icons directory outside the source folder
anyway?

Regards,

Matt.

On Mon, 11 Jul 2005 22:09:10 +0200, Michael Moser wrote:
> Apparently, as soon as there is ONE Aspect-J project open, the
> Properties-tab for the JavaBuildPath (even for projects that have no
> Aspect-J nature) is modified such, that there is no Edit... button any
> more using which one can exclude individual sub-folders and/or files
> from a source directory.
>
> First: why is this so?
>
> Second: This drives me nuts, since I have a subdirectory with icons
> (.gif files) in my project and obviously Windows creates a hidden
> Thumbs.db file in such folders. This file is apparently locked and with
> each rebuild this causes an error dialog to pop up telling me that this
> resource is locked and eclipse can not access it:
>
> FileNotFoundException thrown: <path here>\icons\Thumbs.db (Access is
> denied)
>
> Due to the inability to exclude that specific file (due to the missing
> edit capability) one also can not tell Eclipse/AJDT to leave that damned
> file alone.
>
> Getta U hands off my thumbs!!! :-)
>
> Michael
--
Matt Chapman
AJDT Development, http://www.eclipse.org/ajdt
Re: what does AJDT do to the JavaBuildPath-Edit function? [message #589421 is a reply to message #54897] Tue, 12 July 2005 10:02 Go to previous message
Matt Chapman is currently offline Matt ChapmanFriend
Messages: 429
Registered: July 2009
Senior Member
On Mon, 11 Jul 2005 13:22:38 -0700, Barry Kaplan wrote:
> This is not the only global side effect. Refactor-rename is also
> affected simply by having the ajdt plugin installed -- you don't even
> have to be using it!. (There is a bug for this, but sorry, I don't
> recall the number.) I must say its amazing that there are not way more
> of these little issues given what ajdt has to do reuse the jdt plugin.

Yes, the bug is 100018. I've just picked this up - we *really* don't want
the installation of ajdt to affect plain java projects. I think this is
new with eclipse 3.1.

Regards,

Matt.

--
Matt Chapman
AJDT Development, http://www.eclipse.org/ajdt
Re: what does AJDT do to the JavaBuildPath-Edit function? [message #589428 is a reply to message #54950] Tue, 12 July 2005 10:17 Go to previous message
Michael Moser is currently offline Michael MoserFriend
Messages: 914
Registered: July 2009
Senior Member
Hi Matt,

"Matt Chapman" <mchapman@uk.ibm.com> wrote in message
news:pan.2005.07.12.09.53.19.62863@uk.ibm.com...
> ...
> button, but the Java ones do. Please raise a bug with more details of
> your
> environment, and we'll see if we can work out why this isn't working
> as it
> should for you.

I'll try to boil this down to something easily reproducible.

> Looks like we might need another bug for the file not found exception.
> You
> shouldn't really need to exclude non-source files. Also, wouldn't it
> be
> cleaner to have your icons directory outside the source folder
> anyway?

In principle I agree, but the problem is with the
org.eclipse.jface.resource.ImageDescriptor class, which I use to load my
icons and which has a method:

public static ImageDescriptor createFromFile(Class location, String
filename) {...}


i.e. it requires a class as location relative to which to search for the
icons.

With that method I can not go up beyond (or sideways off) the location
of the class file, so I created a subdirectory with my icons in the
directory where that class sits

One can prefix additional path elements to the filename. In my case its
'filename = "icons/" + name + ".gif";'
Hm, maybe I should try with something like "../../icons/" or such, but I
doubt, that the java security manager would like that...

Michael
Re: what does AJDT do to the JavaBuildPath-Edit function? [message #589436 is a reply to message #54975] Tue, 12 July 2005 15:06 Go to previous message
Barry Kaplan is currently offline Barry KaplanFriend
Messages: 230
Registered: July 2009
Senior Member
Matt Chapman wrote:
> Yes, the bug is 100018. I've just picked this up - we *really* don't want
> the installation of ajdt to affect plain java projects. I think this is
> new with eclipse 3.1.

It is new with 3.1. And of course I know you don't want to spam java projects :-) Like I said, I'm very impressed with what has been done using the jdt given that it was not intended for the kind reuse ajdt imposes on it. I hope that the jdt team works to improve in this area, as it seems that others would like to extend the jdt for language extensions.

Thanks much Matt
Re: what does AJDT do to the JavaBuildPath-Edit function? [message #589445 is a reply to message #55002] Tue, 12 July 2005 15:48 Go to previous message
Matt Chapman is currently offline Matt ChapmanFriend
Messages: 429
Registered: July 2009
Senior Member
On Tue, 12 Jul 2005 12:17:48 +0200, Michael Moser wrote:
> In principle I agree, but the problem is with the
> org.eclipse.jface.resource.ImageDescriptor class, which I use to load my
> icons and which has a method:
>
> public static ImageDescriptor createFromFile(Class location, String
> filename) {...}

Fair enough. In AJDT we use ImageDescriptor.createFromURL(), deriving the
URL via Plugin.getBundle().getEntry(), so we haven't hit the problem.

Regards,

Matt.
Re: what does AJDT do to the JavaBuildPath-Edit function? [message #589448 is a reply to message #55028] Tue, 12 July 2005 15:54 Go to previous message
Matt Chapman is currently offline Matt ChapmanFriend
Messages: 429
Registered: July 2009
Senior Member
On Tue, 12 Jul 2005 08:06:06 -0700, Barry Kaplan wrote:
> It is new with 3.1. And of course I know you don't want to spam java
> projects :-) Like I said, I'm very impressed with what has been done
> using the jdt given that it was not intended for the kind reuse ajdt
> imposes on it. I hope that the jdt team works to improve in this area,
> as it seems that others would like to extend the jdt for language
> extensions.

Fyi, I've just committed a fix to bug 100018. It should be in the next dev
build to appear. There was a resource change listener that was listening
to too much. As well as fixing the editor closing problem, there is also a
small performance gain, as we now avoid processing resource deltas for
non-AJ projects (our main listener already did this, but there was a
second listener that didn't).

Regards,

Matt.
Previous Topic:erratic behaviour re. obsolete project references
Next Topic:another warning I don't understand...
Goto Forum:
  


Current Time: Thu Apr 25 16:51:56 GMT 2024

Powered by FUDForum. Page generated in 0.03868 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top