Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Eclipse Communications Framework (ECF) » ECF Rest: Bug 297239 (requestEntity)
ECF Rest: Bug 297239 (requestEntity) [message #507866] Thu, 14 January 2010 17:18 Go to next message
Andre Dietisheim is currently offline Andre Dietisheim
Messages: 130
Registered: July 2009
Senior Member
Hi Scott

I found some time to hack again today. I catched up with your latest
changes. I therefore dropped my unfinished approach and I try to
concentrate on submitting a patch that brings a mock to ecf.
I had an approach that provided different parameter types (Get-, Post-,
etc.) and double dispatched back to the service. There was pretty much
work ahead an your current implementation (that test by
postRequestType.useRequestEntity()) pretty much fullfills the need.

Just a remark: My impression is that the API is not very fluent so far.
Building a container first, an adapter afterwards, getting the service
and disposing the reference and the container in the end's quite a lot
of work and API). I was thinking about providing simplification. What
about a builder? Any other ideas?

Greetings
André
Re: ECF Rest: Bug 297239 (requestEntity) [message #508160 is a reply to message #507866] Sat, 16 January 2010 16:22 Go to previous message
Scott Lewis is currently offline Scott Lewis
Messages: 964
Registered: July 2009
Senior Member
Hi Andre,

Ande Dietisheim wrote:
> Hi Scott
>
> I found some time to hack again today. I catched up with your latest
> changes. I therefore dropped my unfinished approach and I try to
> concentrate on submitting a patch that brings a mock to ecf.
> I had an approach that provided different parameter types (Get-, Post-,
> etc.) and double dispatched back to the service. There was pretty much
> work ahead an your current implementation (that test by
> postRequestType.useRequestEntity()) pretty much fullfills the need.

Ok, great. There are some remaining issues with this post support
however...for example, how to handle/allow service proxies to be used.

>
> Just a remark: My impression is that the API is not very fluent so far.
> Building a container first, an adapter afterwards, getting the service
> and disposing the reference and the container in the end's quite a lot
> of work and API). I was thinking about providing simplification. What
> about a builder? Any other ideas?


Since the container/adapter structure allows ECF to support a variety of
APIs (in addition to remote services)...and deep extensibility, we
won't/can't eliminate that aspect of ECF. But you (and anyone else) are
more than welcome to propose/contribute API simplifications and/or
additions.

One possibility, for example, would be to have a new subclass of
RemoteServiceContainer...e.g. RestRemoteServiceContainer...although I
haven't thought this through at all.

We should probably move these discussions, though...from the newsgroup
to the ecf-dev at eclipse.org mailing list...just so that we can have a
more technical discussion...as more of the committers and regular
contributors regularly monitor that mailing list (than the newsgroup).

Thanks,

Scott
Re: ECF Rest: Bug 297239 (requestEntity) [message #625020 is a reply to message #507866] Sat, 16 January 2010 16:22 Go to previous message
Scott Lewis is currently offline Scott Lewis
Messages: 964
Registered: July 2009
Senior Member
Hi Andre,

Ande Dietisheim wrote:
> Hi Scott
>
> I found some time to hack again today. I catched up with your latest
> changes. I therefore dropped my unfinished approach and I try to
> concentrate on submitting a patch that brings a mock to ecf.
> I had an approach that provided different parameter types (Get-, Post-,
> etc.) and double dispatched back to the service. There was pretty much
> work ahead an your current implementation (that test by
> postRequestType.useRequestEntity()) pretty much fullfills the need.

Ok, great. There are some remaining issues with this post support
however...for example, how to handle/allow service proxies to be used.

>
> Just a remark: My impression is that the API is not very fluent so far.
> Building a container first, an adapter afterwards, getting the service
> and disposing the reference and the container in the end's quite a lot
> of work and API). I was thinking about providing simplification. What
> about a builder? Any other ideas?


Since the container/adapter structure allows ECF to support a variety of
APIs (in addition to remote services)...and deep extensibility, we
won't/can't eliminate that aspect of ECF. But you (and anyone else) are
more than welcome to propose/contribute API simplifications and/or
additions.

One possibility, for example, would be to have a new subclass of
RemoteServiceContainer...e.g. RestRemoteServiceContainer...although I
haven't thought this through at all.

We should probably move these discussions, though...from the newsgroup
to the ecf-dev at eclipse.org mailing list...just so that we can have a
more technical discussion...as more of the committers and regular
contributors regularly monitor that mailing list (than the newsgroup).

Thanks,

Scott
Previous Topic:ECF Rest: Bug 297239 (requestEntity)
Next Topic:Integrating the Communication perspective within my own RCP application
Goto Forum:
  


Current Time: Thu Apr 24 15:00:48 EDT 2014

Powered by FUDForum. Page generated in 0.04525 seconds