Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Web Tools Project (WTP) » Contribution of enhancements and bug fixes to the Web Page Editor
Contribution of enhancements and bug fixes to the Web Page Editor [message #504194] Thu, 17 December 2009 11:03 Go to next message
Vasanth Velusamy is currently offline Vasanth Velusamy
Messages: 31
Registered: July 2009
Member
Hi,

We, at Active Endpoints, are using a custom version of the web page
editor (org.eclipse.jst.pagedesigner plugin). We would like to
contribute the enhancements and bug fixes we made, back to the project.
Following is a brief summary of the changes we have made.

If one or more of these proposals are acceptable, can you please let me
know so that I can provide more details (use cases, patch, ...).

New Features / Enhancements:

(E1) Added an extension point that allows contribution of additional css
declaration styles. Earlier, if there is no css styling provided in the
html document, the default values from
org/eclipse/jst/pagedesigner/css2/html4.css were used. This extension
point allows extension contributors to provide additional css styling
(before looking for default values in html4.css).
(E2) Added an extension point that provides adapters to the HTMLEditor.
They are used in HTMLEditor.getAdapter(Class) method. This allows great
flexibility in making the html editor adapt to custom requirements.
(E3) Added an extension point that allows contributors to perform custom
operations when the editor is about to show preview (in the Preview
tab). Contributors are allowed to modify the preview content and/or
perform other operations.
- One extenstion contribution is to change any relative file references
in the html content to be absolute paths. Since the preview document is
created in the temp folder, any relative references will not be
available. Converting the references to be absolute paths makes them
available during preview. This is useful when users include any custom
images/stylesheets/javascript resources (with relative paths) in their
html document.
(E4) Added an extension point that allows contribution of drop target
listeners on the designer
(org.eclipse.jst.pagedesigner.editors.SimpleGraphicalEditor) 's viewer.
This allows for drag-n-drop of any arbitrary objects onto the editor.
(E5) Exposed the parent IEditorPart in
org.eclipse.jst.pagedesigner.viewer.HTMLGraphicalViewer through a public
getter method.
(E6) Made the web page editor to be the default editor for html files
(change in plugin.xml).


Bug fixes:

(B1) If there is no value for a css property, in the html document, made
org.eclipse.jst.pagedesigner.css2.property.BorderStyleMeta to return
null instead of ICSSPropertyID.VAL_NONE. This allows the defaults in
html4.css to be used.
(B2) In the web page editor's palette, made the JSP drawer to not be
displayed for any html (*.html, *.htm) files (since they are appropriate
only for jsp files).

The changes are against org.eclipse.jst.pagedesigner version 1.1.0.v20080605

Thanks,
Vasanth
Re: Contribution of enhancements and bug fixes to the Web Page Editor [message #504842 is a reply to message #504194] Tue, 22 December 2009 20:04 Go to previous messageGo to next message
David Williams is currently offline David Williams
Messages: 176
Registered: July 2009
Senior Member
Vasanth Velusamy wrote:

>
> If one or more of these proposals are acceptable, can you please let me
> know so that I can provide more details (use cases, patch, ...).
>

I'm not a committer on that subproject, but I'm sure they'd be interested.

The procedure in WTP (as all of Eclipse) is to open a bugzilla for the
component the code applies for (as enhancement request, or bug, as
appropriate). Explain the issue or use case, as you've done here, and
attach the patch. Normally, patches against cvs HEAD version is best.

While it sometimes takes a while before committers can review and give
some feedback (or accept or reject) a patch, they will eventually,
especially for bug fixes or enhancements they think generally useful to
others.

Let us know if there's more questions, or issues with the general process.
Re: Contribution of enhancements and bug fixes to the Web Page Editor [message #505033 is a reply to message #504842] Thu, 24 December 2009 14:02 Go to previous message
Vasanth Velusamy is currently offline Vasanth Velusamy
Messages: 31
Registered: July 2009
Member
David,

I've already created a defect report (id: 298425), but I haven't
submitted the patch yet. I figured that there would be a discussion as
to whether the suggested changes are acceptable, before anyone would
look at the code.

But maybe I will include the patch too.

Thanks for the clarification.

- Vasanth


David Williams wrote:
> Vasanth Velusamy wrote:
>
>>
>> If one or more of these proposals are acceptable, can you please let
>> me know so that I can provide more details (use cases, patch, ...).
>>
>
> I'm not a committer on that subproject, but I'm sure they'd be interested.
>
> The procedure in WTP (as all of Eclipse) is to open a bugzilla for the
> component the code applies for (as enhancement request, or bug, as
> appropriate). Explain the issue or use case, as you've done here, and
> attach the patch. Normally, patches against cvs HEAD version is best.
>
> While it sometimes takes a while before committers can review and give
> some feedback (or accept or reject) a patch, they will eventually,
> especially for bug fixes or enhancements they think generally useful to
> others.
>
> Let us know if there's more questions, or issues with the general process.
Previous Topic:What should I get when I use the org.eclipse.wst.xml.core.internal.contentmode.DOMContentBuilderImpl
Next Topic:Disable XML Comment Autocompletion
Goto Forum:
  


Current Time: Tue Jul 22 21:54:55 EDT 2014

Powered by FUDForum. Page generated in 0.02182 seconds