Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » EGit » UI dependencies in egit core
UI dependencies in egit core [message #503180] Fri, 11 December 2009 10:06 Go to next message
Thomas Hallgren is currently offline Thomas Hallgren
Messages: 3229
Registered: July 2009
Senior Member
Hi,
I find a dependency to org.eclipse.ui from the org.eclipse.egit.core. Looking closer I see that some operations
implement the IRunnableWithProgress interface from jface.

Since this makes it hard to use the egit.core in a headless environment, I would suggest you remove that dependency and
instead wrap the affected code in an IRunnableInProgress when using it in the org.eclipse.egit.ui component. An
alternative might be to use the IWorkspaceRunnable instead and then wrap that in a IRunnableWithProgress in the UI. That
way, you free the headless part from the need of a large number of UI bundles that are never needed.

Regards,
Thomas Hallgren
Re: UI dependencies in egit core [message #503185 is a reply to message #503180] Fri, 11 December 2009 10:26 Go to previous messageGo to next message
Christian Halstrick is currently offline Christian Halstrick
Messages: 106
Registered: July 2009
Senior Member
Hi,

if you intend to run in a headless environment wouldn't it be better to depend on the jgit only? In jgit we surely don't have this dependency.


Ciao
Chris
Re: UI dependencies in egit core [message #503191 is a reply to message #503185] Fri, 11 December 2009 10:43 Go to previous messageGo to next message
Thomas Hallgren is currently offline Thomas Hallgren
Messages: 3229
Registered: July 2009
Senior Member
On 2009-12-11 11:26, Chris wrote:
> Hi,
>
> if you intend to run in a headless environment wouldn't it be better to
> depend on the jgit only? In jgit we surely don't have this dependency.
>
That would likely mean duplicating a lot of code since I need to find the repositories used in the workspace, check-out
projects and share them, etc.

Regards,
Thomas Hallgren
Re: UI dependencies in egit core [message #503234 is a reply to message #503185] Fri, 11 December 2009 13:51 Go to previous message
Mykola Nikishov is currently offline Mykola Nikishov
Messages: 58
Registered: July 2009
Member
Chris <christian.halstrick@sap.com> writes:

> if you intend to run in a headless environment wouldn't it be better
> to depend on the jgit only? In jgit we surely don't have this
> dependency.

The next step in this direction should be merging of
org.eclipse.egit.core and org.eclipse.egit.ui into a single uber-bundle
org.eclipse.egit.

But it's the way to nowhere. For a headless environment with no Eclipse
support required at all JGit would be the right choice. When you need a
headless environment with some Eclipse features available (workspace or
commands for instance) (re)use org.eclipse.egit.core. And only if UI is
the must then (re)use org.eclipse.egit.ui.

--
MAN-UANIC
Re: UI dependencies in egit core [message #576585 is a reply to message #503180] Fri, 11 December 2009 10:26 Go to previous message
Christian Halstrick is currently offline Christian Halstrick
Messages: 106
Registered: July 2009
Senior Member
Hi,

if you intend to run in a headless environment wouldn't it be better to depend on the jgit only? In jgit we surely don't have this dependency.

--
Ciao
Chris


Ciao
Chris
Re: UI dependencies in egit core [message #576613 is a reply to message #576585] Fri, 11 December 2009 10:43 Go to previous message
Thomas Hallgren is currently offline Thomas Hallgren
Messages: 3229
Registered: July 2009
Senior Member
On 2009-12-11 11:26, Chris wrote:
> Hi,
>
> if you intend to run in a headless environment wouldn't it be better to
> depend on the jgit only? In jgit we surely don't have this dependency.
>
That would likely mean duplicating a lot of code since I need to find the repositories used in the workspace, check-out
projects and share them, etc.

Regards,
Thomas Hallgren
Re: UI dependencies in egit core [message #576624 is a reply to message #576585] Fri, 11 December 2009 13:51 Go to previous message
Mykola Nikishov is currently offline Mykola Nikishov
Messages: 58
Registered: July 2009
Member
Chris <christian.halstrick@sap.com> writes:

> if you intend to run in a headless environment wouldn't it be better
> to depend on the jgit only? In jgit we surely don't have this
> dependency.

The next step in this direction should be merging of
org.eclipse.egit.core and org.eclipse.egit.ui into a single uber-bundle
org.eclipse.egit.

But it's the way to nowhere. For a headless environment with no Eclipse
support required at all JGit would be the right choice. When you need a
headless environment with some Eclipse features available (workspace or
commands for instance) (re)use org.eclipse.egit.core. And only if UI is
the must then (re)use org.eclipse.egit.ui.

--
MAN-UANIC
Previous Topic:File permissions
Next Topic:Create patch with EGit
Goto Forum:
  


Current Time: Tue Sep 16 03:07:04 GMT 2014

Powered by FUDForum. Page generated in 0.02206 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software