Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Rich Client Platform (RCP) » Errors on preferences page
Errors on preferences page [message #498261] Mon, 16 November 2009 08:56 Go to next message
Eclipse UserFriend
Originally posted by: victor.conesa.justinmind.com

Hi all,

there are some issues with the code that handles enabling the Next and
Previous function that the arrow keys generate.

1) on first opening the Preferences dialog,
- the "General" pane title is selected in the tree list, but the selection
shows an inactive (greyed) highlight
- a flashing cursor appears in the filter field
- the orange "Forward" and "Back" widgets at upper right of the dialog are
both disabled (greyed out).

2) pressing the Tab key
- removes the flashing cursor from the filter field
- displays the phrase "type filter text" in grey text in the filter field
- selects the "General" pane title in the list at left, highlighting it
with the system highlight color
- but does *not* visually enable the "Forward" and "Back" buttons
- however, the tree list will respond to Down arrow key presses

3) pressing the Down arrow key once:
- deselects the current pane title in the tree list at left, correctly
un-highlighting it
- selects the next lower pane title in the tree list, highlighting it with
the system highlight color
- visually enables the "Back" button at upper right (though this may not
appear until several moves later, if doing rapid repeated Down arrow inputs)
- does not visually enable the "Forward" button
- however, the dialog does respond to Up or Down arrow key presses
- repeating this step moves the selected pane sequentially down the tree
list as expected, but
- the enabled/disabled visual states of the "Back" and "Forward"
buttons do not change

4) on pressing the Up arrow key
- selects the prior (vertically higher) pane title in the list at left,
highlighting it with the system highlight color
- deselects the current pane title in the list at left, correctly
un-highlighting it
- continues showing the "Back" button as enabled
- but does not enable the "Forward" button at upper right
- the dialog responds to Up or Down arrow key presses appropriately

in the meantime, all/any selection movements are apparently being pushed on
a history stack
- this also occurs if one moves around the tree list non-sequentially, by
selecting different titles directly with the mouse

5) if at any time the "Back" button is *clicked*
- the pane selection is moved backward "down" the history stack
- the "Forward" button at upper right is enabled

clicking the "Back" and "Forward" buttons thereafter
- relocates the pane title selection by moving up or down the history
stack

this is extremely confusing behavior!

strongly urge you consider;
- changing the "Back" and "Forward" buttons to move up or down the tree
list, only, in immediate mode (vs. tracking a history stack;)
- illuminating the "Forward" button at all selection locations other than
the lowest tree position
- illuminating the "Back" button at all selection locations other than the
highest tree position

also: I'm not really clear what "Key Scrolling" means in the small widget at
upper right of the Preferences dialog; but I think it allows me to turn off
using the Up and Down arrow keys to navigate the tree list. I don't
understand what usability goal merits such an unusual feature...
Re: Errors on preferences page [message #498845 is a reply to message #498261] Wed, 18 November 2009 18:52 Go to previous message
Wim Jongman is currently offline Wim JongmanFriend
Messages: 418
Registered: July 2009
Senior Member
>
> 1) on first opening the Preferences dialog,
> - the "General" pane title is selected in the tree list, but the selection
> shows an inactive (greyed) highlight
> - a flashing cursor appears in the filter field
> - the orange "Forward" and "Back" widgets at upper right of the dialog are
> both disabled (greyed out).

No problem so far.

>
> 2) pressing the Tab key
> - removes the flashing cursor from the filter field
> - displays the phrase "type filter text" in grey text in the filter field
> - selects the "General" pane title in the list at left, highlighting it
> with the system highlight color
> - but does *not* visually enable the "Forward" and "Back" buttons
> - however, the tree list will respond to Down arrow key presses

If the search box does not play in the history function (which it doesn't)
then so far everything is ok.

>
> 3) pressing the Down arrow key once:
> - deselects the current pane title in the tree list at left, correctly
> un-highlighting it
> - selects the next lower pane title in the tree list, highlighting it with
> the system highlight color
> - visually enables the "Back" button at upper right (though this may not
> appear until several moves later, if doing rapid repeated Down arrow
inputs)

Yes, I see. That could be a design decision. Rapid keymovements are not
triggered by this mechanism (Post Selection Listener), you could argue that
they should be included. I personally would not.

> - does not visually enable the "Forward" button
> - however, the dialog does respond to Up or Down arrow key presses
> - repeating this step moves the selected pane sequentially down the tree
> list as expected, but
> - the enabled/disabled visual states of the "Back" and "Forward"
> buttons do not change

Pressing the up OR down key triggers a NEXT action on the stack. This adds
actions to the BACK stack but not to the forward stack. So okay so far?

>
> 4) on pressing the Up arrow key
> - selects the prior (vertically higher) pane title in the list at left,
> highlighting it with the system highlight color
> - deselects the current pane title in the list at left, correctly
> un-highlighting it
> - continues showing the "Back" button as enabled
> - but does not enable the "Forward" button at upper right
> - the dialog responds to Up or Down arrow key presses appropriately

Sounds good :-)
>
> in the meantime, all/any selection movements are apparently being pushed on
> a history stack
> - this also occurs if one moves around the tree list non-sequentially, by
> selecting different titles directly with the mouse
>
> 5) if at any time the "Back" button is *clicked*
> - the pane selection is moved backward "down" the history stack
> - the "Forward" button at upper right is enabled
>
> clicking the "Back" and "Forward" buttons thereafter
> - relocates the pane title selection by moving up or down the history
> stack
>
> this is extremely confusing behavior!

it could be but it is consistent. Are there any UI guidelines stating that
this is wrong?

> strongly urge you consider;
> - changing the "Back" and "Forward" buttons to move up or down the tree
> list, only, in immediate mode (vs. tracking a history stack;)
> - illuminating the "Forward" button at all selection locations other than
> the lowest tree position
> - illuminating the "Back" button at all selection locations other than the
> highest tree position
>

> also: I'm not really clear what "Key Scrolling" means in the small widget
at
> upper right of the Preferences dialog; but I think it allows me to turn off
> using the Up and Down arrow keys to navigate the tree list. I don't
> understand what usability goal merits such an unusual feature...

Also not really clear but clicking it stops key scrolling altogether.
Previous Topic:Change Editor Tabs background color
Next Topic:OSGi service bundle start options - noobie
Goto Forum:
  


Current Time: Fri Dec 19 23:39:05 GMT 2014

Powered by FUDForum. Page generated in 0.08865 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software