Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » SWTBot » [swtbot4gef] Why is the constructor of SWTBotEditPart and SwtBotConnectionEditPart package-private?
[swtbot4gef] Why is the constructor of SWTBotEditPart and SwtBotConnectionEditPart package-private? [message #479787] Wed, 12 August 2009 14:10 Go to next message
Pascal G is currently offline Pascal GFriend
Messages: 157
Registered: July 2009
Senior Member
I've been wondering why those constructors are package-private. I didn't
see any good reason so I might of overlooked something. It prevents me
from creating new adapters from EditPart I find using a custom search...
It also prevents clients from creating subclasses of those adapter,
since they might need some custom behavior for their model-specific edit
parts.
Also, I don't see why the adapters need to have the parent in its
constructor: its just duplicate information since the EditPart already
has this information...

p.s.: the name of SwtBotConnectionEditPart is misspelled. Swt should be
all uppercase to match the other adapters.
--
Pascal Gélinas | Software Developer
*Nu Echo Inc.*
http://www.nuecho.com/ | http://blog.nuecho.com/

*Because performance matters.*
Re: [swtbot4gef] Why is the constructor of SWTBotEditPart and SwtBotConnectionEditPart package-priva [message #479811 is a reply to message #479787] Wed, 12 August 2009 15:33 Go to previous messageGo to next message
Mariot Chauvin is currently offline Mariot ChauvinFriend
Messages: 174
Registered: July 2009
Senior Member
Hi Pascal,

Could you raise an issue for that ?

Thanks,

Mariot


Pascal Gelinas a écrit :
> I've been wondering why those constructors are package-private. I didn't
> see any good reason so I might of overlooked something. It prevents me
> from creating new adapters from EditPart I find using a custom search...
> It also prevents clients from creating subclasses of those adapter,
> since they might need some custom behavior for their model-specific edit
> parts.
> Also, I don't see why the adapters need to have the parent in its
> constructor: its just duplicate information since the EditPart already
> has this information...
>
> p.s.: the name of SwtBotConnectionEditPart is misspelled. Swt should be
> all uppercase to match the other adapters.
Re: [swtbot4gef] Why is the constructor of SWTBotEditPart and SwtBotConnectionEditPart package-priva [message #479964 is a reply to message #479787] Thu, 13 August 2009 09:44 Go to previous message
Jens Kübler is currently offline Jens KüblerFriend
Messages: 16
Registered: July 2009
Junior Member
Pascal Gelinas schrieb:
> I've been wondering why those constructors are package-private. I didn't
> see any good reason so I might of overlooked something. It prevents me
> from creating new adapters from EditPart I find using a custom search...
> It also prevents clients from creating subclasses of those adapter,
> since they might need some custom behavior for their model-specific edit
> parts.
> Also, I don't see why the adapters need to have the parent in its
> constructor: its just duplicate information since the EditPart already
> has this information...
>
> p.s.: the name of SwtBotConnectionEditPart is misspelled. Swt should be
> all uppercase to match the other adapters.

You probably have already made the required changes, so we would be glad
if you could attach a patch to your issue if you have done so.

Thanks
Jens
Previous Topic:No getParent or getParentItem
Next Topic:SWTBot can't find the "File" menu
Goto Forum:
  


Current Time: Sat Nov 22 01:55:33 GMT 2014

Powered by FUDForum. Page generated in 0.01624 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software