Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Language IDEs » AJDT » AspectJ advices always yield a warning
AspectJ advices always yield a warning [message #38626] Sat, 17 July 2004 12:38 Go to next message
Michael Moser is currently offline Michael Moser
Messages: 914
Registered: July 2009
Senior Member
The new AJDT 1.1.11 seems to be working VERY nicely (at least as far
as I was able to test and play with it by now).

I only noticed one minor annoyance: I have enabled warnigs for missing
or erroneous javadoc comments in Eclipse and for some strange reason
each advice produces such a warning:

e.g. the advice
-------------------------------------
after() throwing(Throwable t):
loggedMethods() // to be defined by specialized aspects
&& !execution(* *.toString(..)) // to avoid recursion
since we are using this ourselves
&& !adviceexecution() // and another thing we don't want
to see...
{
...
}
-------------------------------------
produces a warning "Missing comment for public declaration ...."

I think this is already false in the first place, since IMHO this is
NOT a public declaration, but - even stranger - even if I then DO add
a javadoc comment to the advice, e.g.
-------------------------------------
/**
* advice after throwing an exception
*/

after() throwing(Throwable t):
loggedMethods() // to be defined by specialized aspects
&& !execution(* *.toString(..)) // to avoid recursion
since we are using this ourselves
&& !adviceexecution() // and another thing we don't want
to see...
{
...
}
-------------------------------------
.... I still get the mentioned warning.

Am I missing something? Or can one somehow get rid of these warnings
(I mean without globally disabling these Eclipse warnings of
course...)?

Michael
Re: AspectJ advices always yield a warning [message #38673 is a reply to message #38626] Sat, 17 July 2004 13:10 Go to previous message
Eclipse User
Originally posted by: mchapman.uk.ibm.com

Hi Michael,

Thanks for the feedback.

I hadn't enabled that javadoc warning before, but you're right, it
is clearly a bug. If possible please raise a bugzilla report for this, and
we'll take a look.

In the meantime, you can at least disable this option on a per project
basis (under properties > Java Compiler) which might be slightly better
than having to globally disable it.

Regards,

Matt.

On Sat, 17 Jul 2004 18:38:36 +0200, Michael Moser wrote:
> The new AJDT 1.1.11 seems to be working VERY nicely (at least as far
> as I was able to test and play with it by now).
>
> I only noticed one minor annoyance: I have enabled warnigs for missing
> or erroneous javadoc comments in Eclipse and for some strange reason
> each advice produces such a warning:
>
> e.g. the advice
> -------------------------------------
> after() throwing(Throwable t):
> loggedMethods() // to be defined by specialized aspects
> && !execution(* *.toString(..)) // to avoid recursion
> since we are using this ourselves
> && !adviceexecution() // and another thing we don't want
> to see...
> {
> ...
> }
> -------------------------------------
> produces a warning "Missing comment for public declaration ...."
>
> I think this is already false in the first place, since IMHO this is
> NOT a public declaration, but - even stranger - even if I then DO add
> a javadoc comment to the advice, e.g.
> -------------------------------------
> /**
> * advice after throwing an exception
> */
>
> after() throwing(Throwable t):
> loggedMethods() // to be defined by specialized aspects
> && !execution(* *.toString(..)) // to avoid recursion
> since we are using this ourselves
> && !adviceexecution() // and another thing we don't want
> to see...
> {
> ...
> }
> -------------------------------------
> ... I still get the mentioned warning.
>
> Am I missing something? Or can one somehow get rid of these warnings
> (I mean without globally disabling these Eclipse warnings of
> course...)?
>
> Michael
Re: AspectJ advices always yield a warning [message #581641 is a reply to message #38626] Sat, 17 July 2004 13:10 Go to previous message
Matt Chapman is currently offline Matt Chapman
Messages: 429
Registered: July 2009
Senior Member
Hi Michael,

Thanks for the feedback.

I hadn't enabled that javadoc warning before, but you're right, it
is clearly a bug. If possible please raise a bugzilla report for this, and
we'll take a look.

In the meantime, you can at least disable this option on a per project
basis (under properties > Java Compiler) which might be slightly better
than having to globally disable it.

Regards,

Matt.

On Sat, 17 Jul 2004 18:38:36 +0200, Michael Moser wrote:
> The new AJDT 1.1.11 seems to be working VERY nicely (at least as far
> as I was able to test and play with it by now).
>
> I only noticed one minor annoyance: I have enabled warnigs for missing
> or erroneous javadoc comments in Eclipse and for some strange reason
> each advice produces such a warning:
>
> e.g. the advice
> -------------------------------------
> after() throwing(Throwable t):
> loggedMethods() // to be defined by specialized aspects
> && !execution(* *.toString(..)) // to avoid recursion
> since we are using this ourselves
> && !adviceexecution() // and another thing we don't want
> to see...
> {
> ...
> }
> -------------------------------------
> produces a warning "Missing comment for public declaration ...."
>
> I think this is already false in the first place, since IMHO this is
> NOT a public declaration, but - even stranger - even if I then DO add
> a javadoc comment to the advice, e.g.
> -------------------------------------
> /**
> * advice after throwing an exception
> */
>
> after() throwing(Throwable t):
> loggedMethods() // to be defined by specialized aspects
> && !execution(* *.toString(..)) // to avoid recursion
> since we are using this ourselves
> && !adviceexecution() // and another thing we don't want
> to see...
> {
> ...
> }
> -------------------------------------
> ... I still get the mentioned warning.
>
> Am I missing something? Or can one somehow get rid of these warnings
> (I mean without globally disabling these Eclipse warnings of
> course...)?
>
> Michael
Previous Topic:AspectJ advices always yield a warning
Next Topic:warning in ajdt 1.1.11 (zip download)
Goto Forum:
  


Current Time: Fri Aug 29 04:19:24 EDT 2014

Powered by FUDForum. Page generated in 0.02354 seconds