Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Archived » OHF » PatientInfoType problem- patientSuffixName
PatientInfoType problem- patientSuffixName [message #34472] Mon, 08 October 2007 23:25 Go to next message
Jesse Pangburn is currently offline Jesse PangburnFriend
Messages: 166
Registered: July 2009
Senior Member
Hi,
In
org.eclipse.ohf.bridge/src/org/eclipse/ohf/bridge/types/Pati entInfoType.java
there is a method "setPatientSuffixName". This method is not called that
I can see (eclipse agrees), nor is there a corresponding
"getPatientSuffixName". This appears to be a remnant from an old version,
perhaps where the patient suffix wasn't inside a child PatientNameType
object?

The problem for me was that this method caused the WSDL generation to show
this "patientSuffixName" to be an element in the patientInfoType.
However, when the bridge sends the xml back, this patientSuffixName is of
course missing since there is no "get" method for it. So in my case,
since I'm doing doc/lit and verifying the XML response against the schema
from the WSDL, it's getting an error about this element missing. I
removed the setPatientSuffixName from my copy of the source code,
recompiled, and now the WSDL does not have it. Testing shows that it's
working fine without it, and of course the returned XML now matches the
schema from the WSDL.

As I am not a committer for this project, I figured I'd post this here to
see if anyone agreed and wanted to make that change to the code. Also, if
there's a better place for me to post these sort of code change
suggestions, please feel free to clue me in :-)

thanks,
Jesse
Re: PatientInfoType problem- patientSuffixName [message #34573 is a reply to message #34472] Tue, 09 October 2007 16:24 Go to previous messageGo to next message
Matthew DavisFriend
Messages: 269
Registered: July 2009
Senior Member
Hi Jesse,

Definitely looks like a bug to me. Please create a new bug in Bugzilla
(note that this is the proper way under Eclipse Foundation rules for you
to contribute fixes and changes).

https://bugs.eclipse.org/bugs/enter_bug.cgi?product=OHF

Please apply this against the "bridge" component so I get notified.

Thanks a bunch!
-Matt


Jesse Pangburn wrote:
> Hi,
> In
> org.eclipse.ohf.bridge/src/org/eclipse/ohf/bridge/types/Pati entInfoType.java
> there is a method "setPatientSuffixName". This method is not called
> that I can see (eclipse agrees), nor is there a corresponding
> "getPatientSuffixName". This appears to be a remnant from an old
> version, perhaps where the patient suffix wasn't inside a child
> PatientNameType object?
>
> The problem for me was that this method caused the WSDL generation to
> show this "patientSuffixName" to be an element in the patientInfoType.
> However, when the bridge sends the xml back, this patientSuffixName is
> of course missing since there is no "get" method for it. So in my case,
> since I'm doing doc/lit and verifying the XML response against the
> schema from the WSDL, it's getting an error about this element missing.
> I removed the setPatientSuffixName from my copy of the source code,
> recompiled, and now the WSDL does not have it. Testing shows that it's
> working fine without it, and of course the returned XML now matches the
> schema from the WSDL.
>
> As I am not a committer for this project, I figured I'd post this here
> to see if anyone agreed and wanted to make that change to the code.
> Also, if there's a better place for me to post these sort of code change
> suggestions, please feel free to clue me in :-)
>
> thanks,
> Jesse
>
Re: PatientInfoType problem- patientSuffixName [message #34607 is a reply to message #34573] Tue, 09 October 2007 20:09 Go to previous message
Jesse Pangburn is currently offline Jesse PangburnFriend
Messages: 166
Registered: July 2009
Senior Member
Hi Matt,
> Definitely looks like a bug to me. Please create a new bug in Bugzilla
> (note that this is the proper way under Eclipse Foundation rules for you
> to contribute fixes and changes).

> https://bugs.eclipse.org/bugs/enter_bug.cgi?product=OHF

> Please apply this against the "bridge" component so I get notified.

I created a bugzilla account for myself and entered this as a bug.

thanks,
Jesse
Re: PatientInfoType problem- patientSuffixName [message #581874 is a reply to message #34472] Tue, 09 October 2007 16:24 Go to previous message
Matthew DavisFriend
Messages: 269
Registered: July 2009
Senior Member
Hi Jesse,

Definitely looks like a bug to me. Please create a new bug in Bugzilla
(note that this is the proper way under Eclipse Foundation rules for you
to contribute fixes and changes).

https://bugs.eclipse.org/bugs/enter_bug.cgi?product=OHF

Please apply this against the "bridge" component so I get notified.

Thanks a bunch!
-Matt


Jesse Pangburn wrote:
> Hi,
> In
> org.eclipse.ohf.bridge/src/org/eclipse/ohf/bridge/types/Pati entInfoType.java
> there is a method "setPatientSuffixName". This method is not called
> that I can see (eclipse agrees), nor is there a corresponding
> "getPatientSuffixName". This appears to be a remnant from an old
> version, perhaps where the patient suffix wasn't inside a child
> PatientNameType object?
>
> The problem for me was that this method caused the WSDL generation to
> show this "patientSuffixName" to be an element in the patientInfoType.
> However, when the bridge sends the xml back, this patientSuffixName is
> of course missing since there is no "get" method for it. So in my case,
> since I'm doing doc/lit and verifying the XML response against the
> schema from the WSDL, it's getting an error about this element missing.
> I removed the setPatientSuffixName from my copy of the source code,
> recompiled, and now the WSDL does not have it. Testing shows that it's
> working fine without it, and of course the returned XML now matches the
> schema from the WSDL.
>
> As I am not a committer for this project, I figured I'd post this here
> to see if anyone agreed and wanted to make that change to the code.
> Also, if there's a better place for me to post these sort of code change
> suggestions, please feel free to clue me in :-)
>
> thanks,
> Jesse
>
Re: PatientInfoType problem- patientSuffixName [message #581893 is a reply to message #34573] Tue, 09 October 2007 20:09 Go to previous message
Jesse Pangburn is currently offline Jesse PangburnFriend
Messages: 166
Registered: July 2009
Senior Member
Hi Matt,
> Definitely looks like a bug to me. Please create a new bug in Bugzilla
> (note that this is the proper way under Eclipse Foundation rules for you
> to contribute fixes and changes).

> https://bugs.eclipse.org/bugs/enter_bug.cgi?product=OHF

> Please apply this against the "bridge" component so I get notified.

I created a bugzilla account for myself and entered this as a bug.

thanks,
Jesse
Previous Topic:OHF Bridge Installation
Next Topic:OHF's 2008 IHE Connectathon wiki
Goto Forum:
  


Current Time: Fri Dec 19 14:34:48 GMT 2014

Powered by FUDForum. Page generated in 0.05169 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software