Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Dynamic Languages Toolkit (DLTK) » refactoring sources - please let us know
refactoring sources - please let us know [message #33632] Thu, 23 October 2008 23:04 Go to next message
Charles Doucette is currently offline Charles DoucetteFriend
Messages: 125
Registered: July 2009
Senior Member
I appreciate the fact that you guys have developed DLTK and made it open
source so we can use it.
I appreciate the fact that you respond to this forum so we know how to use
it.
I was told that I should:
a) be using the latest 1.0 source tree that you are actively developing
b) use IBuildParticipant and the associated extension point
Unfortunately, that does not exist in the stable 1.0M2 release - only in the
latest integration build.
Thus, I have just upgraded to the integration build.
In the process - I have discovered many other changes:

1) The IBuildParticipant interface has changed to use IBuildContext instead
2) A while ago - you told me that your AST node would not be updated to
track line numbers - even though they are available at parse time - and that
we should use a line tracker. So, I wrote some code o create and use line
trackers (Eclipse's ILineTracker). Unfortunately, all of that code is moot
now that you have your own DLTK ISourceLineTracker.

So, what I'm asking, is that if you make incompatible changes, please
announce them so we can be prepared for them when you make the next release
available.

Thanks,
Chuck
Re: refactoring sources - please let us know [message #33735 is a reply to message #33632] Fri, 24 October 2008 07:19 Go to previous messageGo to next message
Alex Panchenko is currently offline Alex PanchenkoFriend
Messages: 342
Registered: July 2009
Senior Member
Hi Chuck,

Sometimes we have to make incompatible changes if they are required to
implement new features.

Historically the changes are announced on the dltk-dev@eclipse.org
mailing list. I would recommend you to subscribe to it. The link to
subscribe is available on the http://www.eclipse.org/dltk/
site.

These changes were announced on the mailing list and I have posted the
link to the message in the "parsers, builders, build types, and build
participants" news thread. Here is that link again
http://dev.eclipse.org/mhonarc/lists/dltk-dev/msg01142.html

Chuck Doucette wrote:
> I appreciate the fact that you guys have developed DLTK and made it open
> source so we can use it.
> I appreciate the fact that you respond to this forum so we know how to use
> it.
> I was told that I should:
> a) be using the latest 1.0 source tree that you are actively developing
> b) use IBuildParticipant and the associated extension point
> Unfortunately, that does not exist in the stable 1.0M2 release - only in the
> latest integration build.
> Thus, I have just upgraded to the integration build.
> In the process - I have discovered many other changes:
>
> 1) The IBuildParticipant interface has changed to use IBuildContext instead
> 2) A while ago - you told me that your AST node would not be updated to
> track line numbers - even though they are available at parse time - and that
> we should use a line tracker.

It depends on the parser if line numbers are provided from it.
Some parsers are just operating on the char arrays and they don't need
to track line boundaries/numbers. The essential information is just the
offset in the source.

> So, I wrote some code o create and use line
> trackers (Eclipse's ILineTracker). Unfortunately, all of that code is moot
> now that you have your own DLTK ISourceLineTracker.

We think that some languages could benefit from the standard
implementation provided by the DLTK. Unfortunately the mentioned
ILineTracker is provided by the org.eclipse.jface.text plugin and we
don't want dltk.core to depend on that plugin, so we have to provide own
interface for the same task.

> So, what I'm asking, is that if you make incompatible changes, please
> announce them so we can be prepared for them when you make the next release
> available.

We try to announce changes, it is just happens in different place - on
the mailing list. Also, most of the technical discussions happens there too.

Regards,
Alex
Re: refactoring sources - please let us know [message #33769 is a reply to message #33735] Fri, 24 October 2008 14:41 Go to previous messageGo to next message
Charles Doucette is currently offline Charles DoucetteFriend
Messages: 125
Registered: July 2009
Senior Member
Ok - I have subscribed to the dev mailing list.
Thanks for the suggestion.

Chuck

"Alex Panchenko" <alex@xored.com> wrote in message
news:gdrstm$l1n$1@build.eclipse.org...
> Hi Chuck,
>
> Sometimes we have to make incompatible changes if they are required to
> implement new features.
>
> Historically the changes are announced on the dltk-dev@eclipse.org mailing
> list. I would recommend you to subscribe to it. The link to subscribe is
> available on the http://www.eclipse.org/dltk/
> site.
>
> These changes were announced on the mailing list and I have posted the
> link to the message in the "parsers, builders, build types, and build
> participants" news thread. Here is that link again
> http://dev.eclipse.org/mhonarc/lists/dltk-dev/msg01142.html
>
> Chuck Doucette wrote:
>> I appreciate the fact that you guys have developed DLTK and made it open
>> source so we can use it.
>> I appreciate the fact that you respond to this forum so we know how to
>> use it.
>> I was told that I should:
>> a) be using the latest 1.0 source tree that you are actively developing
>> b) use IBuildParticipant and the associated extension point
>> Unfortunately, that does not exist in the stable 1.0M2 release - only in
>> the latest integration build.
>> Thus, I have just upgraded to the integration build.
>> In the process - I have discovered many other changes:
>>
>> 1) The IBuildParticipant interface has changed to use IBuildContext
>> instead
>> 2) A while ago - you told me that your AST node would not be updated to
>> track line numbers - even though they are available at parse time - and
>> that we should use a line tracker.
>
> It depends on the parser if line numbers are provided from it.
> Some parsers are just operating on the char arrays and they don't need to
> track line boundaries/numbers. The essential information is just the
> offset in the source.
>
>> So, I wrote some code o create and use line trackers (Eclipse's
>> ILineTracker). Unfortunately, all of that code is moot now that you have
>> your own DLTK ISourceLineTracker.
>
> We think that some languages could benefit from the standard
> implementation provided by the DLTK. Unfortunately the mentioned
> ILineTracker is provided by the org.eclipse.jface.text plugin and we don't
> want dltk.core to depend on that plugin, so we have to provide own
> interface for the same task.
>
>> So, what I'm asking, is that if you make incompatible changes, please
>> announce them so we can be prepared for them when you make the next
>> release available.
>
> We try to announce changes, it is just happens in different place - on the
> mailing list. Also, most of the technical discussions happens there too.
>
> Regards,
> Alex
Re: refactoring sources - please let us know [message #33803 is a reply to message #33632] Fri, 24 October 2008 20:42 Go to previous message
Eclipse UserFriend
Originally posted by: zx.code9.com

> So, what I'm asking, is that if you make incompatible changes, please
> announce them so we can be prepared for them when you make the next release
> available.

Maybe DLTK should adopt PDE API Tools?

http://www.google.com/url?sa=U&start=4&q=http://www. ibm.com/developerworks/opensource/library/os-eclipse-api-too ls/

That way, you can tell if you're breaking API. As an Eclipse project,
you shouldn't be breaking API in point releases.

http://www.google.com/url?sa=U&start=3&q=http://wiki .eclipse.org/Version_Numbering

Let me know if you have any questions.

I know it's hard to stablize on an API :)

Cheers,

~ Chris
Previous Topic:problemreporter bug in 0.95.1 released version
Next Topic:[BUILD] R1.0-I
Goto Forum:
  


Current Time: Thu Dec 18 09:41:38 GMT 2014

Powered by FUDForum. Page generated in 0.04839 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software