Eclipse Community Forums: EclipseLink » Suggestion: commit() method returning the number of committed.

Home » Eclipse Projects » EclipseLink » Suggestion: commit() method returning the number of committed.(Suggestion: commit() method returning the number of committed.)

Show: Today's Messages :: Show Polls :: Message Navigator

Suggestion: commit() method returning the number of committed. [message #908540]

Wed, 05 September 2012 10:44

Marvin Toll
Messages: 20
Registered: July 2009

Junior Member

It would be helpful to me... so I'm presuming others... to have a version of the commit() method similar to the following using the EntityTransaction interface as a model:

/**
* Commit the current resource transaction, writing any
* unflushed changes to the database. This version of the
* commit() method returns the number of SQL modification-
* related statements executed.
*
* @throws IllegalStateException if <code>isActive()</code> is false
* @throws RollbackException if the commit fails
*/
public int commits();

Perhaps obviously, this method would have immediate benefit in a (JUnit style) testing context - where it is difficult to assert if an "update" actually was persisted to the database.

_Marvin
PatternEnabled.com

Report message to a moderator

Re: Suggestion: commit() method returning the number of committed. [message #909060 is a reply to message #908540]

Thu, 06 September 2012 09:16

James Sutherland
Messages: 1844
Registered: July 2009

Senior Member

For our own testing we generally accomplish this by setting a custom logger into the Session that monitors SQL logging.

The class is org.eclipse.persistence.testing.framework.QuerySQLTracker, available from our Git repository under testing.

James : Wiki : Book : Blog

Report message to a moderator

Re: Suggestion: commit() method returning the number of committed. [message #909098 is a reply to message #909060]

Thu, 06 September 2012 10:24

Marvin Toll
Messages: 20
Registered: July 2009

Junior Member

Can you include a copy of the "assert" method you are using to ensure updates actually were persisted during unit testing?

_Marvin
PatternEnabled.com

Marvin Toll
CTO, Pattern Enabled Development
http://PatternEnabled.com

Report message to a moderator

Re: Suggestion: commit() method returning the number of committed. [message #909248 is a reply to message #909060]

Thu, 06 September 2012 16:06

Marvin Toll
Messages: 20
Registered: July 2009

Junior Member

James Sutherland wrote on Thu, 06 September 2012 09:16

For our own testing we generally accomplish this by setting a custom logger into the Session that monitors SQL logging.

The class is org.eclipse.persistence.testing.framework.QuerySQLTracker, available from our Git repository under testing.

Elaboration: foundation/eclipselink.core.test/src/org...

Marvin Toll
CTO, Pattern Enabled Development
http://PatternEnabled.com

Report message to a moderator

Previous Topic:	Eclipselink 2.3.2 + composite persistence units + bean validation (jsr303)
Next Topic:	Why is EclipseLink querying twice for the same entity?

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Fri May 24 05:05:39 EDT 2013